mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-26 03:20:37 +00:00
e66e885e5b
before this change, "backup" and "restore" commands always return 0 as their exist code no matter if the performed operation fails or not. inspired by the "task" commands of nodetool, let's return 1 with exit code if the operation fails. the tests are updated accordingly. Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
91 lines
2.8 KiB
Python
91 lines
2.8 KiB
Python
#
|
|
# Copyright 2024-present ScyllaDB
|
|
#
|
|
# SPDX-License-Identifier: AGPL-3.0-or-later
|
|
#
|
|
|
|
import pytest
|
|
|
|
from test.nodetool.rest_api_mock import expected_request
|
|
|
|
@pytest.mark.parametrize("table",
|
|
["cf",
|
|
pytest.param("",
|
|
marks=pytest.mark.xfail(
|
|
reason="full keyspace restore not implemented yet"))])
|
|
@pytest.mark.parametrize("nowait,task_state,task_error", [(False, "failed", "error"),
|
|
(False, "done", ""),
|
|
(True, "", "")])
|
|
def test_restore(nodetool, scylla_only, table, nowait, task_state, task_error):
|
|
endpoint = "s3.us-east-2.amazonaws.com"
|
|
bucket = "bucket-foo"
|
|
keyspace = "ks"
|
|
|
|
snapshot = "ss"
|
|
params = {"endpoint": endpoint,
|
|
"bucket": bucket,
|
|
"snapshot": snapshot,
|
|
"keyspace": keyspace}
|
|
if table:
|
|
params["table"] = table
|
|
|
|
task_id = "2c4a3e5f"
|
|
start_time = "2024-08-08T14:29:25Z"
|
|
end_time = "2024-08-08T14:30:42Z"
|
|
task_status = {
|
|
"id": task_id,
|
|
"type": "download_sstables",
|
|
"kind": "node",
|
|
"scope": "node",
|
|
"state": task_state,
|
|
"is_abortable": False,
|
|
"start_time": start_time,
|
|
"end_time": end_time,
|
|
"error": task_error,
|
|
"sequence_number": 0,
|
|
"shard": 0,
|
|
"progress_total": 1.0,
|
|
"progress_completed": 1.0,
|
|
"children_ids": []
|
|
}
|
|
expected_requests = [
|
|
expected_request(
|
|
"POST",
|
|
"/storage_service/restore",
|
|
params,
|
|
response=task_id)
|
|
]
|
|
args = ["restore",
|
|
"--endpoint", endpoint,
|
|
"--bucket", bucket,
|
|
"--snapshot", snapshot,
|
|
"--keyspace", keyspace]
|
|
if table:
|
|
args.extend(["--table", table])
|
|
if nowait:
|
|
args.append("--nowait")
|
|
res = nodetool(*args, expected_requests=expected_requests)
|
|
assert task_id in res.stdout
|
|
else:
|
|
# wait for the completion of backup task
|
|
expected_requests.append(
|
|
expected_request(
|
|
"GET",
|
|
f"/task_manager/wait_task/{task_id}",
|
|
response=task_status))
|
|
res = nodetool(*args, expected_requests=expected_requests, check_return_code=False)
|
|
if task_state == "done":
|
|
expected_returncode = 0
|
|
expected_output = f"""{task_state}
|
|
start: {start_time}
|
|
end: {end_time}
|
|
"""
|
|
else:
|
|
expected_returncode = 1
|
|
expected_output = f"""{task_state}: {task_error}
|
|
start: {start_time}
|
|
end: {end_time}
|
|
"""
|
|
assert res.returncode == expected_returncode
|
|
assert res.stdout == expected_output
|