4ffc39d885
Currently we hold group0_guard only during DDL statement's execute() function, but unfortunately some statements access underlying schema state also during check_access() and validate() calls which are called by the query_processor before it calls execute. We need to cover those calls with group0_guard as well and also move retry loop up. This patch does it by introducing new function to cql_statement class take_guard(). Schema altering statements return group0 guard while others do not return any guard. Query processor takes this guard at the beginning of a statement execution and retries if service::group0_concurrent_modification is thrown. The guard is passed to the execute in query_state structure. Fixes: #13942 Message-ID: <ZNsynXayKim2XAFr@scylladb.com>
36 lines
1.0 KiB
C++
36 lines
1.0 KiB
C++
/*
|
|
* Copyright (C) 2021-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <seastar/core/sstring.hh>
|
|
|
|
#include "cql3/statements/service_level_statement.hh"
|
|
#include "cql3/statements/sl_prop_defs.hh"
|
|
#include "service/qos/qos_common.hh"
|
|
|
|
namespace cql3 {
|
|
namespace statements {
|
|
|
|
class create_service_level_statement final : public service_level_statement {
|
|
sstring _service_level;
|
|
qos::service_level_options _slo;
|
|
bool _if_not_exists;
|
|
|
|
public:
|
|
create_service_level_statement(sstring service_level, shared_ptr<sl_prop_defs> attrs, bool if_not_exists);
|
|
std::unique_ptr<cql3::statements::prepared_statement> prepare(data_dictionary::database db, cql_stats &stats) override;
|
|
virtual future<> check_access(query_processor& qp, const service::client_state&) const override;
|
|
virtual future<::shared_ptr<cql_transport::messages::result_message>>
|
|
execute(query_processor&, service::query_state&, const query_options&, std::optional<service::group0_guard> guard) const override;
|
|
};
|
|
|
|
}
|
|
|
|
}
|