mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
299219833bf3ce97ee4e7e43f47b765649ebbf72
scylladb/tools
History
Pavel Emelyanov 5866d265c3 Merge ' tools/utils: tool_app_template: handle the case of no args ' from Botond Dénes 
Currently, `tool_app_template::run_async()` crashes when invoked with empty argv (with just `argv[0]` populated). This can happen if the tool app is invoked without any further args, e.g. just invoking `scylla nodetool`. The crash happens because unconditional dereferencing of `argv[1]` to get the current operation.

To fix, add an early-exit for this case, just printing a usage message and exiting with exit code 2.

Fixes: #16451

Closes scylladb/scylladb#16456

* github.com:scylladb/scylladb:
  test: add regression tests for invoking tools with no args
  tools/utils: tool_app_template: handle the case of no args
  tools/utils: tool_app_template: remove "scylla-" prefix from app name
2023-12-20 19:04:40 +02:00
..
cqlsh @ 426fa0eaa7
Update tools/cqlsh submodule
2023-10-11 17:29:23 +03:00
java @ b7ebfd38ef
Update tools/java submodule (native nodetool)
2023-12-18 14:50:25 +02:00
jmx @ 80ce5996df
Update ./tools/jmx and ./tools/java submodules
2023-11-26 13:35:38 +02:00
python3 @ 3e833f123e
Update tools/python3 submodule
2023-09-11 21:38:02 +03:00
scylla-sstable-scripts
tools: add scylla-sstable-scripts directory
2023-01-09 09:46:57 -05:00
scyllatop
…
testing/dist-check
…
toolchain
install-dependencies.sh : Add packages for supporting code coverage
2023-12-11 13:12:05 +02:00
CMakeLists.txt
build: cmake: add check-header target
2023-11-13 10:27:06 +02:00
entry_point.hh
tools: introduce scylla-nodetool
2023-09-14 05:25:14 -04:00
json_writer.hh
tools,mutation: extract the low-level json utilities into mutation/json.hh
2023-07-19 01:28:28 -04:00
lua_sstable_consumer.cc
everywhere: reduce dependencies on i_partitioner.hh
2023-11-05 20:47:44 +02:00
lua_sstable_consumer.hh
Introduce schema/ module
2023-02-15 11:01:50 +02:00
schema_loader.cc
reader_concurrency_semaphore: add register_metrics constructor parameter
2023-12-13 06:25:45 -05:00
schema_loader.hh
tools/schema_loader: add load_schema_from_schema_tables()
2023-04-12 03:14:43 -04:00
scylla-nodetool.cc
tools/utils: tool_app_template: remove "scylla-" prefix from app name
2023-12-19 04:04:57 -05:00
scylla-sstable.cc
tools/utils: tool_app_template: remove "scylla-" prefix from app name
2023-12-19 04:04:57 -05:00
scylla-types.cc
tools/utils: tool_app_template: remove "scylla-" prefix from app name
2023-12-19 04:04:57 -05:00
sstable_consumer.hh
tools/sstable_consumer: more consistent method naming
2023-01-09 09:46:57 -05:00
utils.cc
tools/utils: tool_app_template: handle the case of no args
2023-12-19 04:08:33 -05:00
utils.hh
tools: Add db config + extensions to tool app run
2023-10-30 10:20:53 +00:00