mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-21 00:50:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
2c727f37fbacbb024077760f3449685ccfb9ece6
scylladb/cql3/statements
History
Nadav Har'El 7ab48b405f CQL: always validate NetworkTopologyStrategy replication factor 
The replication factor passed to NetworkTopologyStrategy (which we call
by the confusing name "auto expand") may or may not be used (see
explanation why in #8881), but regardless, we should validate that it's
a legal number and not some non-numeric junk, and we should report the error.

Before this patch, the two commands

CREATE KEYSPACE name WITH REPLICATION = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 }
ALTER KEYSPACE name WITH REPLICATION = { 'class' : 'NetworkTopologyStrategy', 'replication_factor' : 'foo' }

succeed despite the invalid replication factor "foo". After this patch,
the second command fails.

The problem fixed here is reproduced by the existing test
test_keyspace.py::test_alter_keyspace_invalid when switching it to use
NetworkTopologyStrategy, as suggested by issue #8638.

Fixes #8880
Refs #8881

Signed-off-by: Nadav Har'El <nyh@scylladb.com>
Message-Id: <20210620100442.194610-1-nyh@scylladb.com>
2021-06-30 16:49:46 +03:00
..
raw
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
alter_keyspace_statement.cc
cql: allow restricting SimpleStrategy in ALTER KEYSPACE
2021-06-13 14:45:40 +03:00
alter_keyspace_statement.hh
cql: allow restricting SimpleStrategy in ALTER KEYSPACE
2021-06-13 14:45:40 +03:00
alter_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
alter_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
alter_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
alter_table_statement.cc
cql: add configurable restriction of DateTieredCompactionStrategy
2021-06-24 20:59:27 +03:00
alter_table_statement.hh
cql: add configurable restriction of DateTieredCompactionStrategy
2021-06-24 20:59:27 +03:00
alter_type_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
alter_type_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
alter_view_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
alter_view_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
attach_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
attach_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
authentication_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
authentication_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
authorization_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
authorization_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
batch_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
batch_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
bound.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cas_request.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cas_request.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cf_prop_defs.cc
cql: add configurable restriction of DateTieredCompactionStrategy
2021-06-24 20:59:27 +03:00
cf_prop_defs.hh
cql: add configurable restriction of DateTieredCompactionStrategy
2021-06-24 20:59:27 +03:00
cf_properties.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cf_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_function_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_function_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_index_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_index_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_keyspace_statement.cc
cql: create_keyspace_statement: move logger out of header file
2021-06-13 14:45:40 +03:00
create_keyspace_statement.hh
cql: create_keyspace_statement: move logger out of header file
2021-06-13 14:45:40 +03:00
create_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
create_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
create_table_statement.cc
cql: add configurable restriction of DateTieredCompactionStrategy
2021-06-24 20:59:27 +03:00
create_table_statement.hh
cql: add configurable restriction of DateTieredCompactionStrategy
2021-06-24 20:59:27 +03:00
create_type_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
create_type_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_view_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_view_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
delete_statement.cc
features: assume MC_SSTABLE and UNBOUNDED_RANGE_TOMBSTONES are always enabled
2021-06-25 10:12:00 +02:00
delete_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
detach_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
detach_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_function_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_function_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_index_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_index_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_keyspace_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_keyspace_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_table_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_table_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_type_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_type_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_view_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_view_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
function_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
function_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
grant_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
grant_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
grant_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_prop_defs.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_prop_defs.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_target.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_target.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
ks_prop_defs.cc
CQL: always validate NetworkTopologyStrategy replication factor
2021-06-30 16:49:46 +03:00
ks_prop_defs.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
list_permissions_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_permissions_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_roles_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_service_level_attachments_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
list_service_level_attachments_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
list_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_users_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_users_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
modification_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
modification_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
permission_altering_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
permission_altering_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
prepared_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
property_definitions.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
property_definitions.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
request_validations.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
revoke_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
revoke_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
revoke_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
role-management-statements.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
schema_altering_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
schema_altering_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
select_statement.cc
cql3: use existing constant for max result in indexed statements
2021-06-10 11:08:54 +03:00
select_statement.hh
cql3: use existing constant for max result in indexed statements
2021-06-10 11:08:54 +03:00
service_level_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
sl_prop_defs.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
sl_prop_defs.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
statement_type.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
truncate_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
truncate_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
update_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
update_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
use_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
use_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00