mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-27 11:55:15 +00:00
7ab48b405f
The replication factor passed to NetworkTopologyStrategy (which we call by the confusing name "auto expand") may or may not be used (see explanation why in #8881), but regardless, we should validate that it's a legal number and not some non-numeric junk, and we should report the error. Before this patch, the two commands CREATE KEYSPACE name WITH REPLICATION = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 } ALTER KEYSPACE name WITH REPLICATION = { 'class' : 'NetworkTopologyStrategy', 'replication_factor' : 'foo' } succeed despite the invalid replication factor "foo". After this patch, the second command fails. The problem fixed here is reproduced by the existing test test_keyspace.py::test_alter_keyspace_invalid when switching it to use NetworkTopologyStrategy, as suggested by issue #8638. Fixes #8880 Refs #8881 Signed-off-by: Nadav Har'El <nyh@scylladb.com> Message-Id: <20210620100442.194610-1-nyh@scylladb.com>