Kefu Chai
74dd6dc185
Revert "test: string_format_test: don't compare std::string with sstring"
...
This reverts commit 3c54d5ec5e .
The reverted change fixed the FTBFS of the test in question with Clang 16,
which rightly stopped convert the LHS of `"hello" == sstring{"hello"}` to
the type of the type acceptable by the member operator even we have a
constructor for this conversion, like
class sstring {
public:
bar_t(const char*);
bool operator==(const sstring&) const;
bool operator!=(const sstring&) const;
};
because we have an operator!=, as per the draft of C++ standard
https://eel.is/c++draft/over.match.oper#4 :
> A non-template function or function template F named operator==
> is a rewrite target with first operand o unless a search for the
> name operator!= in the scope S from the instantiation context of
> the operator expression finds a function or function template
> that would correspond ([basic.scope.scope]) to F if its name were
> operator==, where S is the scope of the class type of o if F is a
> class member, and the namespace scope of which F is a member
> otherwise.
in 397f4b51c3 , the seastar submodule was
updated. in which, we now have a dedicated overload for the `const char*`
case. so the compiler is now able to compile the expression like
`"hello" == sstring{"hello"}` in C++20 now.
so, in this change, the workaround is reverted.
Closes #14040
2023-05-29 23:03:24 +03:00
..
2023-03-07 17:54:53 +08:00
2023-05-02 11:04:05 +03:00
2023-04-07 20:32:28 +08:00
2023-02-28 21:56:53 +08:00
2023-02-01 20:14:51 -03:00
2023-03-22 13:48:50 +02:00
2023-02-01 20:14:51 -03:00
2023-05-04 02:37:29 +02:00
2023-03-21 13:15:12 +02:00
2023-02-15 11:01:50 +02:00
2023-02-14 11:19:03 +02:00
2023-02-01 20:14:51 -03:00
2023-05-07 17:17:36 +03:00
2023-02-15 11:01:50 +02:00
2023-03-21 13:15:12 +02:00
2023-02-19 12:58:22 +08:00
2023-02-01 20:14:51 -03:00
2023-05-17 09:51:51 +03:00
2023-02-01 20:14:51 -03:00
2023-03-22 04:58:01 -04:00
2023-02-15 11:01:50 +02:00
2023-02-01 20:14:51 -03:00
2023-04-19 05:20:42 -04:00
2023-05-24 22:58:43 +02:00
2023-05-23 08:52:56 +03:00
2023-05-07 17:17:36 +03:00
2023-02-15 11:01:50 +02:00
2023-05-07 17:17:36 +03:00
2023-02-15 11:01:50 +02:00
2023-05-23 08:52:56 +03:00
2023-04-17 14:08:37 +03:00
2023-05-24 08:43:41 +03:00
2023-02-01 20:14:51 -03:00
2023-04-27 10:24:46 +03:00
2023-02-15 11:09:04 +02:00
2023-02-28 21:56:53 +08:00
2023-02-01 20:14:51 -03:00
2023-04-29 13:11:31 +02:00
2023-02-28 21:56:53 +08:00
2023-02-01 20:14:51 -03:00
2023-05-02 07:58:34 +03:00
2023-02-01 20:14:51 -03:00
2023-02-01 20:14:51 -03:00
2023-02-15 11:01:50 +02:00
2023-02-28 21:56:53 +08:00
2023-05-23 08:52:56 +03:00
2023-02-01 20:14:51 -03:00
2023-04-24 14:06:43 +03:00
2023-02-01 20:14:51 -03:00
2023-02-01 20:14:51 -03:00
2023-02-01 20:14:51 -03:00
2023-02-01 20:14:51 -03:00
2023-02-19 21:05:45 +02:00
2023-02-19 21:05:45 +02:00
2023-02-01 20:14:51 -03:00
2023-05-23 10:40:55 +03:00
2023-02-01 20:14:51 -03:00
2023-04-20 23:39:18 +02:00
2023-02-01 20:14:51 -03:00
2023-02-01 20:14:51 -03:00
2023-02-01 20:14:51 -03:00
2023-04-17 14:08:37 +03:00
2023-05-23 18:46:52 +03:00
2023-02-15 11:01:50 +02:00
2023-04-05 10:32:58 +02:00
2023-05-02 09:42:41 -04:00
2023-02-15 11:01:50 +02:00
2023-05-23 08:52:56 +03:00
2023-05-24 22:58:43 +02:00
2023-02-28 21:56:53 +08:00
2023-05-04 03:35:15 +02:00
2023-05-22 17:56:27 +02:00
2023-02-15 11:01:50 +02:00
2023-04-24 10:49:37 +02:00
2023-02-14 11:19:03 +02:00
2023-05-23 08:52:56 +03:00
2023-02-01 20:14:51 -03:00
2023-02-01 20:14:51 -03:00
2023-02-15 11:01:50 +02:00
2023-02-14 11:19:03 +02:00
2023-04-26 09:00:25 +03:00
2023-02-28 21:56:53 +08:00
2023-05-14 14:14:23 +03:00
2023-02-03 19:04:32 +01:00
2023-02-28 21:56:53 +08:00
2023-02-01 20:14:51 -03:00
2023-02-28 21:56:53 +08:00
2023-04-26 22:09:17 +02:00
2023-02-01 20:14:51 -03:00
2023-05-24 22:58:43 +02:00
2023-05-16 12:23:18 +03:00
2023-05-23 08:52:56 +03:00
2023-03-22 13:59:47 +02:00
2023-05-23 08:52:56 +03:00
2023-02-15 11:01:50 +02:00
2023-03-07 17:54:53 +08:00
2023-04-21 09:43:53 +03:00
2023-05-11 16:31:23 +03:00
2023-04-27 10:24:46 +03:00
2023-04-27 10:24:46 +03:00
2023-02-28 21:56:53 +08:00
2023-05-24 08:43:41 +03:00
2023-05-18 09:01:50 +03:00
2023-02-01 20:14:51 -03:00
2023-05-24 09:23:24 +03:00
2023-05-27 11:10:47 +03:00
2023-05-11 12:32:22 +08:00
2023-05-23 11:29:04 +03:00
2023-02-17 17:58:26 +03:00
2023-05-06 18:24:48 +08:00
2023-05-17 11:31:07 +03:00
2023-05-23 10:40:54 +03:00
2023-03-22 13:59:47 +02:00
2023-04-23 21:34:02 +03:00
2023-04-29 13:11:31 +02:00
2023-04-24 10:49:36 +02:00
2023-05-29 23:03:24 +03:00
2023-03-27 01:44:00 -04:00
2023-04-24 10:49:37 +02:00
2023-05-15 10:19:39 +03:00
2023-05-21 13:17:42 +04:00
2023-04-17 14:08:37 +03:00
2023-02-15 11:09:04 +02:00
2023-02-01 20:14:51 -03:00
2023-02-01 20:14:51 -03:00
2023-02-19 21:05:45 +02:00
2023-03-09 17:51:15 +01:00
2023-05-23 08:52:56 +03:00
2023-04-26 14:09:58 +08:00
2023-05-23 10:14:05 +03:00
2023-02-01 20:14:51 -03:00
2023-02-01 20:14:51 -03:00
2023-02-01 20:14:51 -03:00
2023-03-16 20:34:18 +08:00
2023-03-06 13:17:21 +03:00
2023-02-15 11:01:50 +02:00
2023-02-01 20:14:51 -03:00
2023-03-28 18:18:48 +02:00
2023-03-28 18:18:48 +02:00