mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-20 16:40:35 +00:00
0f6d9ffd22
Prepared LIST statements were not calculating metadata in PREPARE path, and sent empty string hash to client causing problematic behaviour where metadat_id was not recalculated correctly. This patch moves metadata construction into get_result_metadata() for the affected LIST statements and reuse that metadata when building the result set. This gives PREPARE a stable metadata id for LIST ROLES, LIST USERS, LIST PERMISSIONS and the service-level variants. This patch also adds a new boost test that verifies that when an EXECUTE request carries an empty result metadata id while the server has a real metadata id for the result set, the response is marked METADATA_CHANGED and includes the full result metadata plus the server metadata id. This covers the recovery path for clients that send an empty or otherwise unusable metadata id instead of a matching cached one.
44 lines
1.2 KiB
C++
44 lines
1.2 KiB
C++
/*
|
|
* Copyright (C) 2016-present ScyllaDB
|
|
*
|
|
* Modified by ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: (LicenseRef-ScyllaDB-Source-Available-1.1 and Apache-2.0)
|
|
*/
|
|
|
|
#include "utils/assert.hh"
|
|
#include "cql3/column_specification.hh"
|
|
#include "cql3/column_identifier.hh"
|
|
|
|
namespace cql3 {
|
|
|
|
column_specification::column_specification(std::string_view ks_name_, std::string_view cf_name_, ::shared_ptr<column_identifier> name_, data_type type_)
|
|
: ks_name(ks_name_)
|
|
, cf_name(cf_name_)
|
|
, name(name_)
|
|
, type(type_)
|
|
{ }
|
|
|
|
|
|
bool column_specification::all_in_same_table(const std::vector<lw_shared_ptr<column_specification>>& names)
|
|
{
|
|
throwing_assert(!names.empty());
|
|
|
|
auto first = names.front();
|
|
return std::all_of(std::next(names.begin()), names.end(), [first] (auto&& spec) {
|
|
return spec->ks_name == first->ks_name && spec->cf_name == first->cf_name;
|
|
});
|
|
}
|
|
|
|
lw_shared_ptr<column_specification> make_column_spec(std::string_view ks_name, std::string_view cf_name, sstring name, data_type type) {
|
|
return make_lw_shared<column_specification>(
|
|
ks_name,
|
|
cf_name,
|
|
::make_shared<column_identifier>(std::move(name), true),
|
|
std::move(type));
|
|
}
|
|
|
|
}
|