9628c3a4a5
The "keyspace" and "cf" pair of options are now parsed similarly to how recently changed ss::force_keyspace_compaction handler does. The "scrub_mode" query param is saved directly into sstring variable and its presense is checked by .empty() call. If the parameter is missing, the request::get_query_param() would return empty string, so the change is correct. The "skip_corrupted" is boolean option, other options are already parsed by hand, without the help of req_params facilities. There's a test that validates the work of req_params::process() of scrub endpoint -- it passes "invalid" options. This test is temporarily removed according to the PR description. Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
Tests for the Scylla REST API.
Tests use the requests library and the pytest frameworks (both are available from Linux distributions, or with "pip install").
To run all tests using test.py, just run ./test.py api/run.
To run all tests against an already-running local installation of Scylla,
just run pytest. The "--host" and "--api-port"
can be used to give a different location for the running Scylla.
More conveniently, we have a script - "run" - which does all the work necessary to start Scylla, and run the tests on it. The Scylla process is run in a temporary directory which is automatically deleted when the test ends.
"run" automatically picks the most recently compiled version of Scylla in
build/*/scylla - but this choice of Scylla executable can be overridden with
the SCYLLA environment variable.
Additional options can be passed to "pytest" or to "run" to control which tests to run:
- To run all tests in a single file, do
pytest test_system.py. - To run a single specific test, do
pytest test_system.py::test_system_uptime_ms. - To run the same test or tests 100 times, add the
--count=100option. This is faster than runningrun100 times, because Scylla is only run once, and also counts for you how many of the runs failed. Forpytestto support the--countoption, you need to install a pytest extension:pip install pytest-repeat
Additional useful pytest options, especially useful for debugging tests:
- -v: show the names of each individual test running instead of just dots.
- -s: show the full output of running tests (by default, pytest captures the test's output and only displays it if a test fails)