f3609fc813
Some gcc versions incorrectly complain:
tests/log_histogram_test.cc:87:22: error: ‘opts1’ is not a valid template argument for type ‘const log_histogram_options&’ because object ‘opts1’ has not external linkage
size_t hist_key<node<opts1>>(const node<opts1>& n) { return n.v; }
Apparently this is a bug in gcc:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52036
Fixes #2307.
Message-Id: <1493108791-11247-1-git-send-email-tgrabiec@scylladb.com>
104 lines
2.9 KiB
C++
104 lines
2.9 KiB
C++
/*
|
|
* Copyright (C) 2017 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
|
|
#define BOOST_TEST_MODULE core
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
#include <iostream>
|
|
|
|
#include "utils/log_histogram.hh"
|
|
|
|
template<const log_histogram_options& opts>
|
|
struct node : public log_histogram_hook<opts> {
|
|
size_t v;
|
|
node(size_t v) : v(v) {}
|
|
};
|
|
|
|
template<const log_histogram_options& opts>
|
|
void test_with_options() {
|
|
std::vector<std::unique_ptr<node<opts>>> nodes;
|
|
|
|
log_histogram<node<opts>, opts> hist;
|
|
|
|
BOOST_REQUIRE(hist.empty());
|
|
|
|
unsigned i = 0;
|
|
for (; i < opts.min_size; ++i) {
|
|
nodes.push_back(std::make_unique<node<opts>>(i));
|
|
hist.push(*nodes.back());
|
|
BOOST_REQUIRE(!hist.contains_above_min());
|
|
BOOST_REQUIRE(!hist.empty());
|
|
}
|
|
|
|
for (; i <= opts.max_size; ++i) {
|
|
nodes.push_back(std::make_unique<node<opts>>(i));
|
|
hist.push(*nodes.back());
|
|
BOOST_REQUIRE(hist.contains_above_min());
|
|
BOOST_REQUIRE(!hist.empty());
|
|
}
|
|
|
|
size_t count = 0;
|
|
|
|
// Check monotonicity of buckets
|
|
size_t prev_key = 0;
|
|
for (auto&& bucket : hist.buckets()) {
|
|
size_t max_key = 0;
|
|
for (auto&& t : bucket) {
|
|
++count;
|
|
auto key = t.v;
|
|
if (prev_key) {
|
|
assert(key > prev_key);
|
|
}
|
|
max_key = std::max(max_key, key);
|
|
}
|
|
if (max_key) {
|
|
prev_key = max_key;
|
|
}
|
|
}
|
|
|
|
BOOST_REQUIRE(count == (opts.max_size + 1));
|
|
}
|
|
|
|
extern constexpr log_histogram_options opts1{(1 << 4) + 3, 3, (1 << 6) + 2};
|
|
extern constexpr log_histogram_options opts2{(1 << 4) + 2, 1, (1 << 17) + 2};
|
|
extern constexpr log_histogram_options opts3{(1 << 4) + 1, 0, (1 << 17) + 2};
|
|
extern constexpr log_histogram_options opts4{(1 << 4) + 0, 3, (1 << 17)};
|
|
|
|
template<>
|
|
size_t hist_key<node<opts1>>(const node<opts1>& n) { return n.v; }
|
|
|
|
template<>
|
|
size_t hist_key<node<opts2>>(const node<opts2>& n) { return n.v; }
|
|
|
|
template<>
|
|
size_t hist_key<node<opts3>>(const node<opts3>& n) { return n.v; }
|
|
|
|
template<>
|
|
size_t hist_key<node<opts4>>(const node<opts4>& n) { return n.v; }
|
|
|
|
BOOST_AUTO_TEST_CASE(test_log_histogram) {
|
|
test_with_options<opts1>();
|
|
test_with_options<opts2>();
|
|
test_with_options<opts3>();
|
|
test_with_options<opts4>();
|
|
}
|