Tomasz Grabiec 43c7144133 sstables: writer: Validate that partition is closed when the input mutation stream ends ...

Not emitting partition_end for a partition is incorrect. Sstable
writer assumes that it is emitted. If it's not, the sstable will not
be written correctly. The partition index entry for the last partition
will be left partially written, which will may result in errors during
reads. Also, statistics and sstable key ranges will not include the
last partition.

It's better to catch this problem at the time of writing, and not
generate bad sstables.

Another way of handling this would be to implicitly generate a
partition_end, but I don't think that we should do this. We cannot
trust the mutation stream when invariants are violated, we don't know
if this was really the last partition which was supposed to be
written. So it's safer to fail the write.

Enabled for both mc and la/ka.

2019-08-02 11:13:54 +02:00

..

types.hh

sstable: rename the is_boundary predicate

2019-01-11 14:36:49 +02:00

writer.cc

sstables: writer: Validate that partition is closed when the input mutation stream ends

2019-08-02 11:13:54 +02:00

writer.hh

sstable: mc: writer: Move attaching of mc-specific components out of generic code

2019-03-18 11:15:18 +01:00