mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-26 11:30:36 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
33d2da94ab8558f13df30399bdc4c4f7d9be2ce4
scylladb/test/boost
History
Botond Dénes 33d2da94ab reader_concurrency_semaphore: execution_loop(): trigger admission check when _ready_list is empty 
The execution loop consumes permits from the _ready_list and executes
them. The _ready_list usually contains a single permit. When the
_ready_list is not empty, new permits are queued until it becomes empty.
The execution loops relies on admission checks triggered by the read
releasing resouces, to bring in any queued read into the _ready_list,
while it is executing the current read. But in some cases the current
read might not free any resorces and thus fail to trigger an admission
check and the currently queued permits will sit in the queue until
another source triggers an admission check.
I don't yet know how this situation can occur, if at all, but it is
reproducible with a simple unit test, so it is best to cover this
corner-case in the off-chance it happens in the wild.
Add an explicit admission check to the execution loop, after the
_ready_list is exhausted, to make sure any waiters that can be admitted
with an empty _ready_list are admitted immediately and execution
continues.

Fixes: #13540

Closes #13541

(cherry picked from commit b790f14456)
2023-12-07 16:04:55 +02:00
..
aggregate_fcts_test.cc
treewide: clean up stray license blurbs
2022-02-13 14:16:16 +02:00
allocation_strategy_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
alternator_unit_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
anchorless_list_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
auth_passwords_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
auth_resource_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
auth_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
batchlog_manager_test.cc
schema, everywhere: define and use table_id as a strong type
2022-08-08 08:09:41 +03:00
big_decimal_test.cc
treewide: clean up stray license blurbs
2022-02-13 14:16:16 +02:00
bptree_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
broken_sstable_test.cc
sstables: Keep track of first partition's first pos and last partition's last pos
2022-09-14 13:09:51 -03:00
btree_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
bytes_ostream_test.cc
bytes_ostream: base on managed_bytes
2022-07-12 00:23:29 +03:00
cache_flat_mutation_reader_test.cc
position_in_partition: Make after_key() work with non-full keys
2022-12-14 14:47:33 +01:00
cached_file_test.cc
cached_file: Evict unused pages that aren't linked to LRU yet
2023-07-28 13:56:28 +02:00
caching_options_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
canonical_mutation_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cartesian_product_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
castas_fcts_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cdc_generation_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cdc_test.cc
test/boost: cdc_test: remove test_cdc_across_shards
2022-06-23 16:14:41 +02:00
cell_locker_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
checksum_utils_test.cc
checksum_utils_test: supply valid input to crc32_combine()
2022-06-21 11:58:13 +03:00
chunked_managed_vector_test.cc
utils/chunked_managed_vector: Fix sigsegv during reserve()
2022-04-12 16:37:11 +03:00
chunked_vector_test.cc
db: range_tombstone_list: Avoid quadratic behavior when applying
2022-08-05 20:34:07 +03:00
clustering_ranges_walker_test.cc
position_in_partition: Make after_key() work with non-full keys
2022-12-14 14:47:33 +01:00
column_mapping_test.cc
schema, everywhere: define and use table_id as a strong type
2022-08-08 08:09:41 +03:00
commitlog_test.cc
replica: Adapt table::active_memtable() to compaction groups
2022-12-19 11:15:14 -03:00
compound_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
compress_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
config_test.cc
db: config: add BROADCAST_TABLES feature flag
2022-09-05 11:11:08 +02:00
continuous_data_consumer_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
counter_test.cc
everywhere: define locator::host_id as a strong tagged_uuid type
2022-08-12 06:01:44 +03:00
cql_auth_query_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cql_auth_syntax_test.cc
cql3: add a cql3::util::quote() function
2022-02-07 11:33:57 +02:00
cql_functions_test.cc
result_message: add result_message::exception
2022-02-08 11:08:42 +01:00
cql_query_group_test.cc
treewide: use non-experimental std::source_location
2022-11-30 11:06:43 +02:00
cql_query_large_test.cc
treewide: drop cql_serialization_format
2023-01-03 19:54:13 +02:00
cql_query_like_test.cc
treewide: use non-experimental std::source_location
2022-11-30 11:06:43 +02:00
cql_query_test.cc
Merge 'service:forward_service: use long type instead of counter in function mocking' from Michał Jadwiszczak
2023-05-07 14:27:29 +03:00
crc_test.cc
utils: spell "barrett" correctly
2022-11-16 16:30:38 +02:00
data_listeners_test.cc
mutation_reader: move filtering reader into readers/
2022-03-30 15:42:51 +03:00
database_test.cc
test: Fix sporadic failures of database_test
2023-11-30 17:31:07 +02:00
dirty_memory_manager_test.cc
dirty_memory_manager: move to replica module
2022-12-06 22:24:17 +02:00
double_decker_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
duration_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
dynamic_bitset_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
enum_option_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
enum_set_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
error_injection_test.cc
test: error_injection: test_inject_noop: do no rely on wall clock timing
2022-06-21 11:58:13 +03:00
estimated_histogram_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
exception_container_test.cc
exception_container: do not throw in accept
2022-02-16 10:06:10 +02:00
exceptions_fallback_test.cc
utils/exceptions: add try_catch
2022-07-05 16:41:09 +02:00
exceptions_optimized_test.cc
utils/exceptions: add try_catch
2022-07-05 16:41:09 +02:00
exceptions_test.inc.cc
utils: add make_nested_exception_ptr
2022-07-05 16:41:09 +02:00
expr_test.cc
cql3, transport, tests: remove "unset" from value type system
2023-01-16 21:10:56 +02:00
extensions_test.cc
database: rename {flush,snapshot}_on_all and make static
2022-08-07 12:53:05 +03:00
filtering_test.cc
treewide: use system-#include (angle brackets) for seastar
2022-04-26 14:46:42 +03:00
flat_mutation_reader_test.cc
Merge 'readers/nonforwarding: don't emit partition_end on next_partition,fast_forward_to' from Gusev Petr
2023-03-16 10:42:03 +02:00
flush_queue_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
fragmented_temporary_buffer_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
frozen_mutation_test.cc
test/lib: Remove sstable_utils.hh from simple_schema.hh
2022-12-08 15:37:33 +02:00
gossiping_property_file_snitch_test.cc
code: Deglobalize snitch
2022-10-20 12:33:41 +03:00
group0_test.cc
test: use correct timestamp resolution in test_group0_history_clearing_old_entries
2023-07-27 15:46:37 +02:00
hash_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
hashers_test.cc
test/lib: Remove sstable_utils.hh from simple_schema.hh
2022-12-08 15:37:33 +02:00
hint_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
idl_test.cc
idl: make idl headers self-sufficient
2022-08-08 08:02:27 +03:00
index_with_paging_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
input_stream_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
intrusive_array_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
json_cql_query_test.cc
type_json: support integers in scientific format
2022-02-22 12:55:38 +01:00
json_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
keys_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
large_paging_state_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
like_matcher_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
limiting_data_source_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
linearizing_input_stream_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
lister_test.cc
lister: Make lister::dir_entry_types an enum_set
2022-11-17 19:01:45 +03:00
loading_cache_test.cc
test: loading_cache_test: fix use-after-free in test_loading_cache_remove_leaves_no_old_entries_behind
2022-11-03 17:23:40 +02:00
locator_topology_test.cc
topology.cc: remove_endpoint: _dc_racks removal fix
2023-08-11 14:29:37 +03:00
log_heap_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
logalloc_standard_allocator_segment_pool_backend_test.cc
test/boost: add alternative variant of logalloc test
2022-09-16 14:57:23 +03:00
logalloc_test.cc
test/boost/logalloc_test: make test_compaction_with_multiple_regions exception-safe
2022-09-16 12:16:57 +03:00
managed_bytes_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
managed_vector_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
map_difference_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
memtable_test.cc
replica: Adapt table::active_memtable() to compaction groups
2022-12-19 11:15:14 -03:00
multishard_combining_reader_as_mutation_source_test.cc
treewide: use non-experimental std::source_location
2022-11-30 11:06:43 +02:00
multishard_mutation_query_test.cc
deletable_row: add column_kind parameter to is_live
2022-12-06 11:21:16 +01:00
murmur_hash_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
mutation_fragment_test.cc
position_in_partition: Make after_key() work with non-full keys
2022-12-14 14:47:33 +01:00
mutation_query_test.cc
test/lib: Remove sstable_utils.hh from simple_schema.hh
2022-12-08 15:37:33 +02:00
mutation_reader_test.cc
combined: mergers: remove recursion in operator()()
2023-07-11 11:09:25 +03:00
mutation_test.cc
Merge 'atomic_cell: compare value last' from Benny Halevy
2023-07-12 10:09:56 +03:00
mutation_writer_test.cc
test/lib: Remove sstable_utils.hh from simple_schema.hh
2022-12-08 15:37:33 +02:00
mvcc_test.cc
boost/mvcc_test: use failure_injecting_allocation_strategy where it is meant to
2023-01-10 12:01:36 +01:00
network_topology_strategy_test.cc
topology: get rid of pending state
2022-12-13 14:17:18 +02:00
nonwrapping_range_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
observable_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
partitioner_test.cc
compaction: refactor dht::subtract_ranges out of get_ranges_for_invalidation
2022-11-21 15:48:26 +02:00
per_partition_rate_limit_test.cc
query: add tombstone-limit to read-command
2022-08-10 06:01:47 +03:00
querier_cache_test.cc
Merge 'semaphore mismatch: don't throw an error if both semaphores belong to user' from Michał Jadwiszczak
2023-08-09 10:20:53 +03:00
query_processor_test.cc
query_processor: remove default internal query caching behavior
2022-05-01 08:33:55 +03:00
radix_tree_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
range_assert.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
range_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
range_tombstone_list_assertions.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
range_tombstone_list_test.cc
position_in_partition: Make after_key() work with non-full keys
2022-12-14 14:47:33 +01:00
rate_limiter_test.cc
db: add rate_limiter
2022-06-22 20:16:48 +02:00
reader_concurrency_semaphore_test.cc
reader_concurrency_semaphore: execution_loop(): trigger admission check when _ready_list is empty
2023-12-07 16:04:55 +02:00
repair_test.cc
test/lib: Remove sstable_utils.hh from simple_schema.hh
2022-12-08 15:37:33 +02:00
restrictions_test.cc
treewide: drop cql_serialization_format
2023-01-03 19:54:13 +02:00
result_utils_test.cc
utils/result_try: prevent exceptions from being caught multiple times
2022-03-15 11:42:42 +02:00
reusable_buffer_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
role_manager_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
row_cache_test.cc
tests: row_cache: Add reproducer for reader producing missing closing range tombstone
2023-05-15 18:02:40 +02:00
rust_test.cc
tests: add rust example
2022-05-11 16:49:31 +02:00
schema_change_test.cc
Merge 'schema_mutations, migration_manager: Ignore empty partitions in per-table digest' from Tomasz Grabiec
2023-11-21 01:29:28 +01:00
schema_changes_test.cc
tests: trivial flat_reader_assertions{,_v2} conversions
2022-05-10 22:10:40 +03:00
schema_loader_test.cc
tools/schema_loader: auto-create the keyspace for all statements
2022-02-17 15:24:24 +02:00
schema_registry_test.cc
Merge 'schema_mutations, migration_manager: Ignore empty partitions in per-table digest' from Tomasz Grabiec
2023-11-21 01:29:28 +01:00
secondary_index_test.cc
test_secondary_index_collections: change insert/create index order
2023-08-24 14:09:08 +03:00
serialization_test.cc
test/boost/serialization_test.cc: add test for reverse vector
2022-11-14 16:06:24 +01:00
serialized_action_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
service_level_controller_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
small_vector_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
snitch_reset_test.cc
code: Deglobalize snitch
2022-10-20 12:33:41 +03:00
sstable_3_x_test.cc
deletable_row: add column_kind parameter to is_live
2022-12-06 11:21:16 +01:00
sstable_compaction_test.cc
test: Verify that off-strategy can do incremental compaction
2023-10-22 17:05:33 -03:00
sstable_conforms_to_mutation_source_test.cc
Merge 'readers: evictable_reader: don't accidentally consume the entire partition' from Kamil Braun
2023-06-29 12:04:35 +03:00
sstable_datafile_test.cc
table: Optimize creation of reader excluding staging for view building
2023-07-20 16:46:15 +03:00
sstable_directory_test.cc
tests: Disclosure private filename() calls
2022-12-15 10:14:49 +03:00
sstable_move_test.cc
tests: Disclosure private filename() calls
2022-12-15 10:14:49 +03:00
sstable_mutation_test.cc
Merge 'Remove flat_mutation_reader (v1)' from Michael Livshin
2022-06-03 07:26:29 +03:00
sstable_partition_index_cache_test.cc
sstable: partition_index_cache: Fix abort on bad_alloc during page loading
2022-05-25 09:27:04 +03:00
sstable_resharding_test.cc
replica: Kill table::calculate_shard_from_sstable_generation()
2023-01-09 20:17:57 +02:00
sstable_set_test.cc
test/lib: Remove sstable_utils.hh from simple_schema.hh
2022-12-08 15:37:33 +02:00
sstable_test.cc
sstables: track decompressed buffers
2023-01-08 15:34:28 +02:00
sstable_test.hh
replica: Kill table::calculate_shard_from_sstable_generation()
2023-01-09 20:17:57 +02:00
stall_free_test.cc
utils: clear_gently: do not clear null unique_ptr
2023-04-24 17:51:01 +03:00
statement_restrictions_test.cc
treewide: use non-experimental std::source_location
2022-11-30 11:06:43 +02:00
storage_proxy_test.cc
storage_proxy: Make split_stats resilient to being called from different scheduling group
2023-07-12 09:24:56 +03:00
suite.yaml
test/boost: add alternative variant of logalloc test
2022-09-16 14:57:23 +03:00
summary_test.cc
Add summary_test
2022-07-27 16:58:52 +03:00
test_table.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
top_k_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
total_order_check.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
tracing_test.cc
tracing: Wire tracing test back
2022-10-13 17:59:13 +03:00
transport_test.cc
cql3, transport, tests: remove "unset" from value type system
2023-01-16 21:10:56 +02:00
types_test.cc
treewide: drop cql_serialization_format
2023-01-03 19:54:13 +02:00
user_function_test.cc
config: fix printing of experimental feature list
2022-07-11 09:17:30 +02:00
user_types_test.cc
udt: disallow dropping a user type used in a user function
2023-04-17 13:13:35 +02:00
utf8_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
UUID_test.cc
test: uuid: cement the assumption that default and null uuid are equal
2022-02-16 10:19:47 +02:00
view_build_test.cc
Merge 'view_updating_consumer: account empty partitions memory usage' from Botond Dénes
2023-07-31 03:43:44 -04:00
view_complex_test.cc
compaction_manager: major: switch to table_state
2022-07-16 21:35:06 -03:00
view_schema_ckey_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
view_schema_pkey_test.cc
materialized views: allow empty strings in views and indexes
2022-03-08 15:34:26 +02:00
view_schema_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
vint_serialization_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
virtual_reader_test.cc
size_estimates_virtual_reader: Pass sys_ks argument to get_local_ranges()
2022-10-06 18:00:09 +03:00
virtual_table_mutation_source_test.cc
test/lib: Remove sstable_utils.hh from simple_schema.hh
2022-12-08 15:37:33 +02:00
virtual_table_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
wasm_alloc_test.cc
test: assert that WASM allocations can fail without crashing
2023-01-06 14:07:29 +01:00
wasm_test.cc
wasm: limit memory allocated using mmap
2023-01-06 14:07:29 +01:00