mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-23 10:00:35 +00:00
a7ef826c2b
" Validation compaction -- although I still maintain that it is a good descriptive name -- was an unfortunate choice for the underlying functionality because Origin has burned the name already as it uses it for a compaction type used during repair. This opens the door for confusion for users coming from Cassandra who will associate Validation compaction with the purpose it is used for in Origin. Additionally, since Origin's validation compaction was not user initiated, it didn't have a corresponding `nodetool` command to start it. Adding such a command would create an operational difference between us and Origin. To avoid all this we fold validation compaction into scrub compaction, under a new "validation" mode. I decided against using the also suggested `--dry-mode` flag as I feel that a new mode is a more natural choice, we don't have to define how it interacts with all the other modes, unlike with a `--dry-mode` flag. Fixes: #7736 Tests: unit(dev), manual(REST API) " * 'scrub-validation-mode/v2' of https://github.com/denesb/scylla: compaction/compaction_descriptor: add comment to Validation compaction type compaction/compaction_descriptor: compaction_options: remove validate api: storage_service: validate_keyspace -> scrub_keyspace (validate mode) compaction/compaction_manager: hide perform_sstable_validation() compaction: validation compaction -> scrub compaction (validate mode) compaction/compaction_descriptor: compaction_options: add options() accessor compaction/compaction_descriptor: compaction_options::scrub::mode: add validate