3682c06157
The test test_metrics.py::test_update_item_increases_metrics_for_new_item_size_only tests whether the Alternator metrics report the exactly-DynamoDB-compatible WCU number. It is parameterized with two cases - one that uses alternator_force_read_before_write and one which doesn't. The case that uses alternator_force_read_before_write is expected to measure the "accurate" WCU, and currently it doesn't, so the test rightly xfails. But the case that doesn't use alternator_force_read_before_write is not expected to measure the "accurate" WCU and has a different expectation, so this case actually passes. But because the entire test is marked xfail, it is reported as "XPASS" - unexpected pass. Fix this by marking only the "True" case with xfail, while the "False" case is not marked. After this pass, the True case continues to XFAIL and the False case passes normally, instead of XPASS. Also removed a sentence promising that the failing case will be solved "by the next PR". Clearly this didn't happen. Maybe we even have such a PR open (?), but it won't the "the next PR" even if merged today. Signed-off-by: Nadav Har'El <nyh@scylladb.com>
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cqlpy - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.