mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-12 19:02:12 +00:00
e84a09911a
we have three format()s in our arsenal: * seastar::format() * fmt::format() * std::format() the first one is used most frequently. but it has two limitations: 1. it returns seastar::sstring instead of std::string. under some circumstances, the caller of the format() function actually expects std::string, in that case a deep copy is performed to construct an instance of std::string. this incurs unnecessary performance overhead. but this limitation is a by-design behavior. 2. it does not do compile-time format check. this can be improved at the Seastar's end. to address these two problems, we switch the callers who expect std::string to fmt::format(). to minimize the impact and to reduce the risk, the switch will be performed piecemeal. Signed-off-by: Kefu Chai <kefu.chai@scylladb.com> Closes scylladb/scylladb#17212