3a6208b319
As discussed in https://github.com/scylladb/scylladb/pull/24606#discussion_r2281870939 clear_gently of shared pointers should release the wrapped object reference and when the object's use_count reaches 1, the object itself would be cleared_gently, before it's destroyed. This behavior is similar to the way we clear gently containers like arrays or vectors, and so it is extended in this patch to smart pointers like unique_ptr and foreign_ptr. The unit tests are adjusted respectively to expect the smart pointers to be reset after clear_gently, plus the use of `reset()` for `foreign_ptr<shared_ptr<>>` was replaced by `clear_gently().get()` which now ensures the reference to a shared object is released, and awaited for, if it happens on a foreign owner shard, unlike reset of a foreign_ptr that kicks off destroy of that shared object in the background on the owner shard - causing flakiness. Fixes #25723 Signed-off-by: Benny Halevy <bhalevy@scylladb.com> Closes scylladb/scylladb#25759
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cqlpy - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.