1aacfdf460
The API req->param["name"] to access parameters in the path part of the URL was buggy - it forgot to do URL decoding and the result of our use of it in Scylla was bugs like #5883 - where special characters in certain REST API requests got botched up (encoded by the client, then not decoded by the server). The solution is to replace all uses of req->param["name"] by the new req->get_path_param("name"), which does the decoding correctly. Unfortunately we needed to change 104 (!) callers in this patch, but the transformation is mostly mechanical and there is no functional changes in this patch. Another set of changes was to bring req, not req->param, to a few functions that want to get the path param. This patch avoids the numerous deprecation warnings we had before, and more importantly, it fixes #5883. Signed-off-by: Nadav Har'El <nyh@scylladb.com>
115 lines
4.2 KiB
C++
115 lines
4.2 KiB
C++
/*
|
|
* Copyright (C) 2023-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#include "api/api.hh"
|
|
#include "api/api-doc/storage_service.json.hh"
|
|
#include "api/api-doc/endpoint_snitch_info.json.hh"
|
|
#include "locator/token_metadata.hh"
|
|
|
|
using namespace seastar::httpd;
|
|
|
|
namespace api {
|
|
|
|
namespace ss = httpd::storage_service_json;
|
|
using namespace json;
|
|
|
|
void set_token_metadata(http_context& ctx, routes& r, sharded<locator::shared_token_metadata>& tm) {
|
|
ss::local_hostid.set(r, [&tm](std::unique_ptr<http::request> req) {
|
|
auto id = tm.local().get()->get_my_id();
|
|
return make_ready_future<json::json_return_type>(id.to_sstring());
|
|
});
|
|
|
|
ss::get_tokens.set(r, [&tm] (std::unique_ptr<http::request> req) {
|
|
return make_ready_future<json::json_return_type>(stream_range_as_array(tm.local().get()->sorted_tokens(), [](const dht::token& i) {
|
|
return fmt::to_string(i);
|
|
}));
|
|
});
|
|
|
|
ss::get_node_tokens.set(r, [&tm] (std::unique_ptr<http::request> req) {
|
|
gms::inet_address addr(req->get_path_param("endpoint"));
|
|
auto& local_tm = *tm.local().get();
|
|
const auto host_id = local_tm.get_host_id_if_known(addr);
|
|
return make_ready_future<json::json_return_type>(stream_range_as_array(host_id ? local_tm.get_tokens(*host_id): std::vector<dht::token>{}, [](const dht::token& i) {
|
|
return fmt::to_string(i);
|
|
}));
|
|
});
|
|
|
|
ss::get_leaving_nodes.set(r, [&tm](const_req req) {
|
|
const auto& local_tm = *tm.local().get();
|
|
const auto& leaving_host_ids = local_tm.get_leaving_endpoints();
|
|
std::unordered_set<gms::inet_address> eps;
|
|
eps.reserve(leaving_host_ids.size());
|
|
for (const auto host_id: leaving_host_ids) {
|
|
eps.insert(local_tm.get_endpoint_for_host_id(host_id));
|
|
}
|
|
return container_to_vec(eps);
|
|
});
|
|
|
|
ss::get_moving_nodes.set(r, [](const_req req) {
|
|
std::unordered_set<sstring> addr;
|
|
return container_to_vec(addr);
|
|
});
|
|
|
|
ss::get_joining_nodes.set(r, [&tm](const_req req) {
|
|
const auto& local_tm = *tm.local().get();
|
|
const auto& points = local_tm.get_bootstrap_tokens();
|
|
std::unordered_set<gms::inet_address> eps;
|
|
eps.reserve(points.size());
|
|
for (const auto& [token, host_id]: points) {
|
|
eps.insert(local_tm.get_endpoint_for_host_id(host_id));
|
|
}
|
|
return container_to_vec(eps);
|
|
});
|
|
|
|
ss::get_host_id_map.set(r, [&tm](const_req req) {
|
|
std::vector<ss::mapper> res;
|
|
return map_to_key_value(tm.local().get()->get_endpoint_to_host_id_map_for_reading(), res);
|
|
});
|
|
|
|
static auto host_or_broadcast = [&tm](const_req req) {
|
|
auto host = req.get_query_param("host");
|
|
return host.empty() ? tm.local().get()->get_topology().my_address() : gms::inet_address(host);
|
|
};
|
|
|
|
httpd::endpoint_snitch_info_json::get_datacenter.set(r, [&tm](const_req req) {
|
|
auto& topology = tm.local().get()->get_topology();
|
|
auto ep = host_or_broadcast(req);
|
|
if (!topology.has_endpoint(ep)) {
|
|
// Cannot return error here, nodetool status can race, request
|
|
// info about just-left node and not handle it nicely
|
|
return locator::endpoint_dc_rack::default_location.dc;
|
|
}
|
|
return topology.get_datacenter(ep);
|
|
});
|
|
|
|
httpd::endpoint_snitch_info_json::get_rack.set(r, [&tm](const_req req) {
|
|
auto& topology = tm.local().get()->get_topology();
|
|
auto ep = host_or_broadcast(req);
|
|
if (!topology.has_endpoint(ep)) {
|
|
// Cannot return error here, nodetool status can race, request
|
|
// info about just-left node and not handle it nicely
|
|
return locator::endpoint_dc_rack::default_location.rack;
|
|
}
|
|
return topology.get_rack(ep);
|
|
});
|
|
}
|
|
|
|
void unset_token_metadata(http_context& ctx, routes& r) {
|
|
ss::local_hostid.unset(r);
|
|
ss::get_tokens.unset(r);
|
|
ss::get_node_tokens.unset(r);
|
|
ss::get_leaving_nodes.unset(r);
|
|
ss::get_moving_nodes.unset(r);
|
|
ss::get_joining_nodes.unset(r);
|
|
ss::get_host_id_map.unset(r);
|
|
httpd::endpoint_snitch_info_json::get_datacenter.unset(r);
|
|
httpd::endpoint_snitch_info_json::get_rack.unset(r);
|
|
}
|
|
|
|
}
|