in in {fmt} before v10, it provides the specialization of `fmt::formatter<..>`
for `std::string_view` as well as the specialization of `fmt::formatter<..>`
for `fmt::string_view` which is an implementation builtin in {fmt} for
compatibility of pre-C++17. and this type is used even if the code is
compiled with C++ stadandard greater or equal to C++17. also, before v10,
the `fmt::formatter<std::string_view>::format()` is defined so it accepts
`std::string_view`. after v10, `fmt::formatter<std::string_view>` still
exists, but it is now defined using `format_as()` machinery, so it's
`format()` method does not actually accept `std::string_view`, it
accepts `fmt::string_view`, as the former can be converted to
`fmt::string_view`.
this is why we can inherit from `fmt::formatter<std::string_view>` and
use `formatter<std::string_view>::format(foo, ctx);` to implement the
`format()` method with {fmt} v9, but we cannot do this with {fmt} v10,
and we would have following compilation failure:
```
FAILED: service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o
/home/kefu/.local/bin/clang++ -DFMT_DEPRECATED_OSTREAM -DFMT_SHARED -DSCYLLA_BUILD_MODE=release -DSEASTAR_API_LEVEL=7 -DSEASTAR_LOGGER_COMPILE_TIME_FMT -DSEASTAR_LOGGER_TYPE_STDOUT -DSEASTAR_SCHEDULING_GROUPS_COUNT=16 -DSEASTAR_SSTRING -DXXH_PRIVATE_API -DCMAKE_INTDIR=\"RelWithDebInfo\" -I/home/kefu/dev/scylladb -I/home/kefu/dev/scylladb/build/gen -I/home/kefu/dev/scylladb/seastar/include -I/home/kefu/dev/scylladb/build/seastar/gen/include -I/home/kefu/dev/scylladb/build/seastar/gen/src -ffunction-sections -fdata-sections -O3 -g -gz -std=gnu++20 -fvisibility=hidden -Wall -Werror -Wextra -Wno-error=deprecated-declarations -Wimplicit-fallthrough -Wno-c++11-narrowing -Wno-deprecated-copy -Wno-mismatched-tags -Wno-missing-field-initializers -Wno-overloaded-virtual -Wno-unsupported-friend -Wno-enum-constexpr-conversion -Wno-unused-parameter -ffile-prefix-map=/home/kefu/dev/scylladb=. -march=westmere -mllvm -inline-threshold=2500 -fno-slp-vectorize -U_FORTIFY_SOURCE -Werror=unused-result -MD -MT service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o -MF service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o.d -o service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o -c /home/kefu/dev/scylladb/service/topology_state_machine.cc
/home/kefu/dev/scylladb/service/topology_state_machine.cc:254:41: error: no matching member function for call to 'format'
254 | return formatter<std::string_view>::format(it->second, ctx);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
/usr/include/fmt/core.h:2759:22: note: candidate function template not viable: no known conversion from 'seastar::basic_sstring<char, unsigned int, 15>' to 'const fmt::basic_string_view<char>' for 1st argument
2759 | FMT_CONSTEXPR auto format(const T& val, FormatContext& ctx) const
| ^ ~~~~~~~~~~~~
```
because the inherited `format()` method actually comes from
`fmt::formatter<fmt::string_view>`. to reduce the confusion, in this
change, we just inherit from `fmt::format<string_view>`, where
`string_view` is actually `fmt::string_view`. this follows
the document at
https://fmt.dev/latest/api.html#formatting-user-defined-types,
and since there is less indirection under the hood -- we do not
use the specialization created by `FMT_FORMAT_AS` which inherit
from `formatter<fmt::string_view>`, hopefully this can improve
the compilation speed a little bit. also, this change addresses
the build failure with {fmt} v10.
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
Closes scylladb/scylladb#18299
139 lines
5.8 KiB
C++
139 lines
5.8 KiB
C++
/*
|
|
* Copyright (C) 2019-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "utils/chunked_vector.hh"
|
|
#include "schema/schema_fwd.hh"
|
|
#include "gc_clock.hh"
|
|
#include "mutation/atomic_cell.hh"
|
|
#include <iosfwd>
|
|
#include <forward_list>
|
|
|
|
class abstract_type;
|
|
class compaction_garbage_collector;
|
|
class row_tombstone;
|
|
|
|
class collection_mutation;
|
|
|
|
// An auxiliary struct used to (de)construct collection_mutations.
|
|
// Unlike collection_mutation which is a serialized blob, this struct allows to inspect logical units of information
|
|
// (tombstone and cells) inside the mutation easily.
|
|
struct collection_mutation_description {
|
|
tombstone tomb;
|
|
// FIXME: use iterators?
|
|
// we never iterate over `cells` more than once, so there is no need to store them in memory.
|
|
// In some cases instead of constructing the `cells` vector, it would be more efficient to provide
|
|
// a one-time-use forward iterator which returns the cells.
|
|
utils::chunked_vector<std::pair<bytes, atomic_cell>> cells;
|
|
|
|
// Expires cells based on query_time. Expires tombstones based on max_purgeable and gc_before.
|
|
// Removes cells covered by tomb or this->tomb.
|
|
bool compact_and_expire(column_id id, row_tombstone tomb, gc_clock::time_point query_time,
|
|
can_gc_fn&, gc_clock::time_point gc_before, compaction_garbage_collector* collector = nullptr);
|
|
|
|
// Packs the data to a serialized blob.
|
|
collection_mutation serialize(const abstract_type&) const;
|
|
};
|
|
|
|
// Similar to collection_mutation_description, except that it doesn't store the cells' data, only observes it.
|
|
struct collection_mutation_view_description {
|
|
tombstone tomb;
|
|
// FIXME: use iterators? See the fixme in collection_mutation_description; the same considerations apply here.
|
|
utils::chunked_vector<std::pair<bytes_view, atomic_cell_view>> cells;
|
|
|
|
// Copies the observed data, storing it in a collection_mutation_description.
|
|
collection_mutation_description materialize(const abstract_type&) const;
|
|
|
|
// Packs the data to a serialized blob.
|
|
collection_mutation serialize(const abstract_type&) const;
|
|
};
|
|
|
|
class collection_mutation_input_stream {
|
|
std::forward_list<bytes> _linearized;
|
|
managed_bytes_view _src;
|
|
public:
|
|
collection_mutation_input_stream(const managed_bytes_view& src) : _src(src) {}
|
|
template <Trivial T>
|
|
T read_trivial() {
|
|
return ::read_simple<T>(_src);
|
|
}
|
|
bytes_view read_linearized(size_t n);
|
|
managed_bytes_view read_fragmented(size_t n);
|
|
bool empty() const;
|
|
};
|
|
|
|
// Given a collection_mutation_view, returns an auxiliary struct allowing the inspection of each cell.
|
|
// The function needs to be given the type of stored data to reconstruct the structural information.
|
|
collection_mutation_view_description deserialize_collection_mutation(const abstract_type&, collection_mutation_input_stream&);
|
|
|
|
class collection_mutation_view {
|
|
public:
|
|
managed_bytes_view data;
|
|
|
|
// Is this a noop mutation?
|
|
bool is_empty() const;
|
|
|
|
// Is any of the stored cells live (not deleted nor expired) at the time point `tp`,
|
|
// given the later of the tombstones `t` and the one stored in the mutation (if any)?
|
|
// Requires a type to reconstruct the structural information.
|
|
bool is_any_live(const abstract_type&, tombstone t = tombstone(), gc_clock::time_point tp = gc_clock::time_point::min()) const;
|
|
|
|
// The maximum of timestamps of the mutation's cells and tombstone.
|
|
api::timestamp_type last_update(const abstract_type&) const;
|
|
|
|
// Given a function that operates on a collection_mutation_view_description,
|
|
// calls it on the corresponding description of `this`.
|
|
template <typename F>
|
|
inline decltype(auto) with_deserialized(const abstract_type& type, F f) const {
|
|
collection_mutation_input_stream stream(data);
|
|
return f(deserialize_collection_mutation(type, stream));
|
|
}
|
|
|
|
class printer {
|
|
const abstract_type& _type;
|
|
const collection_mutation_view& _cmv;
|
|
public:
|
|
printer(const abstract_type& type, const collection_mutation_view& cmv)
|
|
: _type(type), _cmv(cmv) {}
|
|
friend fmt::formatter<printer>;
|
|
};
|
|
};
|
|
|
|
// A serialized mutation of a collection of cells.
|
|
// Used to represent mutations of collections (lists, maps, sets) or non-frozen user defined types.
|
|
// It contains a sequence of cells, each representing a mutation of a single entry (element or field) of the collection.
|
|
// Each cell has an associated 'key' (or 'path'). The meaning of each (key, cell) pair is:
|
|
// for sets: the key is the serialized set element, the cell contains no data (except liveness information),
|
|
// for maps: the key is the serialized map element's key, the cell contains the serialized map element's value,
|
|
// for lists: the key is a timeuuid identifying the list entry, the cell contains the serialized value,
|
|
// for user types: the key is an index identifying the field, the cell contains the value of the field.
|
|
// The mutation may also contain a collection-wide tombstone.
|
|
class collection_mutation {
|
|
public:
|
|
managed_bytes _data;
|
|
|
|
collection_mutation() {}
|
|
collection_mutation(const abstract_type&, collection_mutation_view);
|
|
collection_mutation(const abstract_type&, managed_bytes);
|
|
operator collection_mutation_view() const;
|
|
};
|
|
|
|
collection_mutation merge(const abstract_type&, collection_mutation_view, collection_mutation_view);
|
|
|
|
collection_mutation difference(const abstract_type&, collection_mutation_view, collection_mutation_view);
|
|
|
|
// Serializes the given collection of cells to a sequence of bytes ready to be sent over the CQL protocol.
|
|
bytes_ostream serialize_for_cql(const abstract_type&, collection_mutation_view);
|
|
|
|
template <>
|
|
struct fmt::formatter<collection_mutation_view::printer> : fmt::formatter<string_view> {
|
|
auto format(const collection_mutation_view::printer&, fmt::format_context& ctx) const
|
|
-> decltype(ctx.out());
|
|
};
|