223214439b
This hourly reevaluation is there to help tablets that have very low write activity, which can go a long time without flushing a memtable, and it's important to reevaluate compaction as data can get expired. Today it can happen that we reevaluate a table that is being compacted actively, which is waste of cpu as the reevaluation will happen anyway when there are changes to sstable set. This waste can be amplified with a significant tablet count in a given shard. Eventually, we could make the revaluation time per table based on expiration histogram, but until we get there, let's avoid this waste by only reevaluating tables that are compaction idle for more than 1h. Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com> Closes scylladb/scylladb#18280
53 lines
1.4 KiB
C++
53 lines
1.4 KiB
C++
/*
|
|
* Copyright (C) 2023-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <seastar/core/gate.hh>
|
|
#include <seastar/core/rwlock.hh>
|
|
#include <seastar/core/condition-variable.hh>
|
|
#include "seastarx.hh"
|
|
|
|
#include "compaction/compaction_fwd.hh"
|
|
#include "compaction/compaction_backlog_manager.hh"
|
|
#include "gc_clock.hh"
|
|
|
|
namespace compaction {
|
|
|
|
struct compaction_state {
|
|
// Used both by compaction tasks that refer to the compaction_state
|
|
// and by any function running under run_with_compaction_disabled().
|
|
seastar::gate gate;
|
|
|
|
// Prevents table from running major and minor compaction at the same time.
|
|
seastar::rwlock lock;
|
|
|
|
// Raised by any function running under run_with_compaction_disabled();
|
|
long compaction_disabled_counter = 0;
|
|
|
|
// Signaled whenever a compaction task completes.
|
|
condition_variable compaction_done;
|
|
|
|
std::optional<compaction_backlog_tracker> backlog_tracker;
|
|
|
|
std::unordered_set<sstables::shared_sstable> sstables_requiring_cleanup;
|
|
compaction::owned_ranges_ptr owned_ranges_ptr;
|
|
|
|
gc_clock::time_point last_regular_compaction;
|
|
|
|
explicit compaction_state(table_state& t);
|
|
compaction_state(compaction_state&&) = delete;
|
|
~compaction_state();
|
|
|
|
bool compaction_disabled() const noexcept {
|
|
return compaction_disabled_counter > 0;
|
|
}
|
|
};
|
|
|
|
} // namespace compaction_manager
|