mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-29 19:21:01 +00:00
4ffc39d885
Currently we hold group0_guard only during DDL statement's execute() function, but unfortunately some statements access underlying schema state also during check_access() and validate() calls which are called by the query_processor before it calls execute. We need to cover those calls with group0_guard as well and also move retry loop up. This patch does it by introducing new function to cql_statement class take_guard(). Schema altering statements return group0 guard while others do not return any guard. Query processor takes this guard at the beginning of a statement execution and retries if service::group0_concurrent_modification is thrown. The guard is passed to the execute in query_state structure. Fixes: #13942 Message-ID: <ZNsynXayKim2XAFr@scylladb.com>
94 lines
4.1 KiB
C++
94 lines
4.1 KiB
C++
/*
|
|
* Copyright (C) 2021-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#include "seastarx.hh"
|
|
#include "cql3/statements/list_service_level_statement.hh"
|
|
#include "cql3/column_identifier.hh"
|
|
#include "service/qos/service_level_controller.hh"
|
|
#include "transport/messages/result_message.hh"
|
|
#include "utils/overloaded_functor.hh"
|
|
#include "service/client_state.hh"
|
|
#include "service/query_state.hh"
|
|
|
|
namespace cql3 {
|
|
|
|
namespace statements {
|
|
|
|
list_service_level_statement::list_service_level_statement(sstring service_level, bool describe_all) :
|
|
_service_level(service_level), _describe_all(describe_all) {
|
|
}
|
|
|
|
std::unique_ptr<cql3::statements::prepared_statement>
|
|
cql3::statements::list_service_level_statement::prepare(
|
|
data_dictionary::database db, cql_stats &stats) {
|
|
return std::make_unique<prepared_statement>(::make_shared<list_service_level_statement>(*this));
|
|
}
|
|
|
|
future<> list_service_level_statement::check_access(query_processor& qp, const service::client_state &state) const {
|
|
return state.ensure_has_permission(auth::command_desc{.permission = auth::permission::DESCRIBE, .resource = auth::root_service_level_resource()});
|
|
}
|
|
|
|
future<::shared_ptr<cql_transport::messages::result_message>>
|
|
list_service_level_statement::execute(query_processor& qp,
|
|
service::query_state &state,
|
|
const query_options &,
|
|
std::optional<service::group0_guard> guard) const {
|
|
|
|
static auto make_column = [] (sstring name, const shared_ptr<const abstract_type> type) {
|
|
return make_lw_shared<column_specification>(
|
|
"QOS",
|
|
"service_levels",
|
|
::make_shared<column_identifier>(std::move(name), true),
|
|
type);
|
|
};
|
|
|
|
static thread_local const std::vector<lw_shared_ptr<column_specification>> metadata({make_column("service_level", utf8_type),
|
|
make_column("timeout", duration_type),
|
|
make_column("workload_type", utf8_type)
|
|
});
|
|
|
|
return make_ready_future().then([this, &state] () {
|
|
if (_describe_all) {
|
|
return state.get_service_level_controller().get_distributed_service_levels();
|
|
} else {
|
|
return state.get_service_level_controller().get_distributed_service_level(_service_level);
|
|
}
|
|
})
|
|
.then([] (qos::service_levels_info sl_info) {
|
|
auto d = [] (const qos::service_level_options::timeout_type& duration) -> bytes_opt {
|
|
return std::visit(overloaded_functor{
|
|
[&] (const qos::service_level_options::unset_marker&) {
|
|
return bytes_opt();
|
|
},
|
|
[&] (const qos::service_level_options::delete_marker&) {
|
|
return bytes_opt();
|
|
},
|
|
[&] (const lowres_clock::duration& d) -> bytes_opt {
|
|
auto nanos = std::chrono::duration_cast<std::chrono::nanoseconds>(d).count();
|
|
return duration_type->decompose(cql_duration(months_counter{0}, days_counter{0}, nanoseconds_counter{nanos}));
|
|
},
|
|
}, duration);
|
|
};
|
|
auto rs = std::make_unique<result_set>(metadata);
|
|
for (auto &&[sl_name, slo] : sl_info) {
|
|
bytes_opt workload = slo.workload == qos::service_level_options::workload_type::unspecified
|
|
? bytes_opt()
|
|
: utf8_type->decompose(qos::service_level_options::to_string(slo.workload));
|
|
rs->add_row(std::vector<bytes_opt>{
|
|
utf8_type->decompose(sl_name),
|
|
d(slo.timeout),
|
|
workload});
|
|
}
|
|
|
|
auto rows = ::make_shared<cql_transport::messages::result_message::rows>(result(std::move(std::move(rs))));
|
|
return ::static_pointer_cast<cql_transport::messages::result_message>(rows);
|
|
});
|
|
}
|
|
}
|
|
}
|