mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-21 00:50:35 +00:00
1e7360ef6d
If the len2 argument to crc32_combine() is zero, then the crc2 argument must also be zero. fast_crc32_combine() explicitly checks for len2==0, in which case it ignores crc2 (which is the same as if it were zero). zlib's crc32_combine() used to have that check prior to version 1.2.12, but then lost it, making its necessary for callers to be more careful. Also add the len2==0 check to the dummy fast_crc32_combine() implementation, because it delegates to zlib's. Signed-off-by: Michael Livshin <michael.livshin@scylladb.com> Closes #10731
84 lines
2.4 KiB
C++
84 lines
2.4 KiB
C++
/*
|
|
* Copyright (C) 2018-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#define BOOST_TEST_MODULE core
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
#include "sstables/checksum_utils.hh"
|
|
#include "test/lib/make_random_string.hh"
|
|
#include <seastar/core/print.hh>
|
|
|
|
template<typename ReferenceImpl, typename Impl>
|
|
static
|
|
void test_combine() {
|
|
auto check = [](size_t len2) {
|
|
constexpr auto crc1 = 0x12381237;
|
|
// len2==0 implies crc2==0. Newer zlib versions don't hold the
|
|
// caller's hands anymore in this case, so make sure we don't
|
|
// supply invalid input:
|
|
const auto crc2 = len2 == 0 ? 0 : 0x73747474;
|
|
auto c1 = Impl::checksum_combine(crc1, crc2, len2);
|
|
auto c2 = ReferenceImpl::checksum_combine(crc1, crc2, len2);
|
|
BOOST_REQUIRE_EQUAL(c1, c2);
|
|
};
|
|
|
|
check(0);
|
|
check(1);
|
|
check(2);
|
|
check(3);
|
|
check(8);
|
|
check(255);
|
|
check(256);
|
|
check(1023);
|
|
check(1024);
|
|
check(1025);
|
|
check(0xffff);
|
|
check(0x10000);
|
|
check(0xdeadbeef);
|
|
check(0xffffffff);
|
|
check(0x100000000);
|
|
check(0x200000000);
|
|
check(0x10000000001);
|
|
check(0x7eadbeefcafebabe);
|
|
check(0x7fffffffffffffff);
|
|
}
|
|
|
|
template<typename ReferenceImpl, typename Impl>
|
|
static
|
|
void test() {
|
|
auto rolling = Impl::init_checksum();
|
|
BOOST_REQUIRE_EQUAL(rolling, ReferenceImpl::init_checksum());
|
|
|
|
for (auto size : {0, 1, 2, 10, 13, 16, 17, 22, 31, 1024, 2000, 80000}) {
|
|
auto data = make_random_string(size);
|
|
|
|
auto current = Impl::checksum(data.data(), data.size());
|
|
auto ref_current = ReferenceImpl::checksum(data.data(), data.size());
|
|
BOOST_REQUIRE_EQUAL(current, ref_current);
|
|
|
|
auto new_rolling = Impl::checksum(rolling, data.data(), data.size());
|
|
auto ref_new_rolling = ReferenceImpl::checksum(rolling, data.data(), data.size());
|
|
BOOST_REQUIRE_EQUAL(new_rolling, ref_new_rolling);
|
|
|
|
auto new_rolling_via_combine = Impl::checksum_combine(rolling, current, data.size());
|
|
BOOST_REQUIRE_EQUAL(new_rolling, new_rolling_via_combine);
|
|
|
|
rolling = new_rolling;
|
|
}
|
|
|
|
test_combine<ReferenceImpl, Impl>();
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(test_libdeflate_matches_zlib) {
|
|
test<zlib_crc32_checksummer, libdeflate_crc32_checksummer>();
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(test_default_matches_zlib) {
|
|
test<zlib_crc32_checksummer, crc32_utils>();
|
|
}
|