mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-01 21:55:50 +00:00
in in {fmt} before v10, it provides the specialization of `fmt::formatter<..>`
for `std::string_view` as well as the specialization of `fmt::formatter<..>`
for `fmt::string_view` which is an implementation builtin in {fmt} for
compatibility of pre-C++17. and this type is used even if the code is
compiled with C++ stadandard greater or equal to C++17. also, before v10,
the `fmt::formatter<std::string_view>::format()` is defined so it accepts
`std::string_view`. after v10, `fmt::formatter<std::string_view>` still
exists, but it is now defined using `format_as()` machinery, so it's
`format()` method does not actually accept `std::string_view`, it
accepts `fmt::string_view`, as the former can be converted to
`fmt::string_view`.
this is why we can inherit from `fmt::formatter<std::string_view>` and
use `formatter<std::string_view>::format(foo, ctx);` to implement the
`format()` method with {fmt} v9, but we cannot do this with {fmt} v10,
and we would have following compilation failure:
```
FAILED: service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o
/home/kefu/.local/bin/clang++ -DFMT_DEPRECATED_OSTREAM -DFMT_SHARED -DSCYLLA_BUILD_MODE=release -DSEASTAR_API_LEVEL=7 -DSEASTAR_LOGGER_COMPILE_TIME_FMT -DSEASTAR_LOGGER_TYPE_STDOUT -DSEASTAR_SCHEDULING_GROUPS_COUNT=16 -DSEASTAR_SSTRING -DXXH_PRIVATE_API -DCMAKE_INTDIR=\"RelWithDebInfo\" -I/home/kefu/dev/scylladb -I/home/kefu/dev/scylladb/build/gen -I/home/kefu/dev/scylladb/seastar/include -I/home/kefu/dev/scylladb/build/seastar/gen/include -I/home/kefu/dev/scylladb/build/seastar/gen/src -ffunction-sections -fdata-sections -O3 -g -gz -std=gnu++20 -fvisibility=hidden -Wall -Werror -Wextra -Wno-error=deprecated-declarations -Wimplicit-fallthrough -Wno-c++11-narrowing -Wno-deprecated-copy -Wno-mismatched-tags -Wno-missing-field-initializers -Wno-overloaded-virtual -Wno-unsupported-friend -Wno-enum-constexpr-conversion -Wno-unused-parameter -ffile-prefix-map=/home/kefu/dev/scylladb=. -march=westmere -mllvm -inline-threshold=2500 -fno-slp-vectorize -U_FORTIFY_SOURCE -Werror=unused-result -MD -MT service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o -MF service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o.d -o service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o -c /home/kefu/dev/scylladb/service/topology_state_machine.cc
/home/kefu/dev/scylladb/service/topology_state_machine.cc:254:41: error: no matching member function for call to 'format'
254 | return formatter<std::string_view>::format(it->second, ctx);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
/usr/include/fmt/core.h:2759:22: note: candidate function template not viable: no known conversion from 'seastar::basic_sstring<char, unsigned int, 15>' to 'const fmt::basic_string_view<char>' for 1st argument
2759 | FMT_CONSTEXPR auto format(const T& val, FormatContext& ctx) const
| ^ ~~~~~~~~~~~~
```
because the inherited `format()` method actually comes from
`fmt::formatter<fmt::string_view>`. to reduce the confusion, in this
change, we just inherit from `fmt::format<string_view>`, where
`string_view` is actually `fmt::string_view`. this follows
the document at
https://fmt.dev/latest/api.html#formatting-user-defined-types,
and since there is less indirection under the hood -- we do not
use the specialization created by `FMT_FORMAT_AS` which inherit
from `formatter<fmt::string_view>`, hopefully this can improve
the compilation speed a little bit. also, this change addresses
the build failure with {fmt} v10.
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
Closes scylladb/scylladb#18299
160 lines
5.4 KiB
C++
160 lines
5.4 KiB
C++
/*
|
|
* Copyright (C) 2020-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#include <seastar/core/app-template.hh>
|
|
#include <seastar/core/thread.hh>
|
|
#include <map>
|
|
#include <fmt/core.h>
|
|
|
|
constexpr int TEST_NODE_SIZE = 16;
|
|
|
|
#include "tree_test_key.hh"
|
|
#include "utils/bptree.hh"
|
|
#include "bptree_validation.hh"
|
|
#include "collection_stress.hh"
|
|
|
|
using namespace bplus;
|
|
using namespace seastar;
|
|
|
|
using test_key = tree_test_key_base;
|
|
|
|
class test_data {
|
|
int _value;
|
|
public:
|
|
test_data() : _value(0) {}
|
|
test_data(test_key& k) : _value((int)k + 10) {}
|
|
|
|
operator unsigned long() const { return _value; }
|
|
bool match_key(const test_key& k) const { return _value == (int)k + 10; }
|
|
};
|
|
|
|
template <> struct fmt::formatter<test_data> : fmt::formatter<string_view> {
|
|
auto format(test_data d, fmt::format_context& ctx) const {
|
|
return fmt::format_to(ctx.out(), "{}", static_cast<unsigned long>(d));
|
|
}
|
|
};
|
|
|
|
using test_tree = tree<test_key, test_data, test_key_compare, TEST_NODE_SIZE, key_search::both, with_debug::yes>;
|
|
using test_node = typename test_tree::node;
|
|
using test_validator = validator<test_key, test_data, test_key_compare, TEST_NODE_SIZE>;
|
|
using test_iterator_checker = iterator_checker<test_key, test_data, test_key_compare, TEST_NODE_SIZE>;
|
|
|
|
int main(int argc, char **argv) {
|
|
namespace bpo = boost::program_options;
|
|
app_template app;
|
|
app.add_options()
|
|
("count", bpo::value<int>()->default_value(4132), "number of keys to fill the tree with")
|
|
("iters", bpo::value<int>()->default_value(9), "number of iterations")
|
|
("keys", bpo::value<std::string>()->default_value("rand"), "how to generate keys (rand, asc, desc)")
|
|
("verb", bpo::value<bool>()->default_value(false), "be verbose");
|
|
|
|
return app.run(argc, argv, [&app] {
|
|
auto count = app.configuration()["count"].as<int>();
|
|
auto iters = app.configuration()["iters"].as<int>();
|
|
auto ks = app.configuration()["keys"].as<std::string>();
|
|
auto verb = app.configuration()["verb"].as<bool>();
|
|
|
|
return seastar::async([count, iters, ks, verb] {
|
|
auto t = std::make_unique<test_tree>(test_key_compare{});
|
|
std::map<int, unsigned long> oracle;
|
|
test_validator tv;
|
|
auto* itc = new test_iterator_checker(tv, *t);
|
|
|
|
stress_config cfg;
|
|
cfg.count = count;
|
|
cfg.iters = iters;
|
|
cfg.keys = ks;
|
|
cfg.verb = verb;
|
|
auto rep = 0, itv = 0;
|
|
|
|
stress_collection(cfg,
|
|
/* insert */ [&] (int key) {
|
|
test_key k(key);
|
|
|
|
if (rep % 2 != 1) {
|
|
auto ir = t->emplace(copy_key(k), k);
|
|
assert(ir.second);
|
|
} else {
|
|
auto ir = t->lower_bound(k);
|
|
ir.emplace_before(copy_key(k), test_key_compare{}, k);
|
|
}
|
|
oracle[key] = key + 10;
|
|
|
|
if (itv++ % 7 == 0) {
|
|
if (!itc->step()) {
|
|
delete itc;
|
|
itc = new test_iterator_checker(tv, *t);
|
|
}
|
|
}
|
|
},
|
|
/* erase */ [&] (int key) {
|
|
test_key k(key);
|
|
|
|
if (itc->here(k)) {
|
|
delete itc;
|
|
itc = nullptr;
|
|
}
|
|
|
|
if (rep % 3 != 2) {
|
|
t->erase(k);
|
|
} else {
|
|
auto ri = t->find(k);
|
|
auto ni = ri;
|
|
ni++;
|
|
auto eni = ri.erase(test_key_compare{});
|
|
assert(ni == eni);
|
|
}
|
|
oracle.erase(key);
|
|
|
|
if (itc == nullptr) {
|
|
itc = new test_iterator_checker(tv, *t);
|
|
}
|
|
|
|
if (itv++ % 5 == 0) {
|
|
if (!itc->step()) {
|
|
delete itc;
|
|
itc = new test_iterator_checker(tv, *t);
|
|
}
|
|
}
|
|
},
|
|
/* validate */ [&] {
|
|
if (verb) {
|
|
fmt::print("Validating\n");
|
|
tv.print_tree(*t, '|');
|
|
}
|
|
tv.validate(*t);
|
|
},
|
|
/* step */ [&] (stress_step step) {
|
|
if (step == stress_step::iteration_finished) {
|
|
rep++;
|
|
}
|
|
|
|
if (step == stress_step::before_erase) {
|
|
auto sz = t->size_slow();
|
|
if (sz != (size_t)count) {
|
|
fmt::print("Size {} != count {}\n", sz, count);
|
|
throw "size";
|
|
}
|
|
|
|
auto ti = t->begin();
|
|
for (auto oe : oracle) {
|
|
if ((unsigned long)*ti != oe.second) {
|
|
fmt::print("Data mismatch {} vs {}\n", oe.second, *ti);
|
|
throw "oracle";
|
|
}
|
|
ti++;
|
|
}
|
|
}
|
|
}
|
|
);
|
|
|
|
delete itc;
|
|
});
|
|
});
|
|
}
|