Files
scylladb/utils/anchorless_list.hh
Kefu Chai f5b05cf981 treewide: use defaulted operator!=() and operator==()
in C++20, compiler generate operator!=() if the corresponding
operator==() is already defined, the language now understands
that the comparison is symmetric in the new standard.

fortunately, our operator!=() is always equivalent to
`! operator==()`, this matches the behavior of the default
generated operator!=(). so, in this change, all `operator!=`
are removed.

in addition to the defaulted operator!=, C++20 also brings to us
the defaulted operator==() -- it is able to generated the
operator==() if the member-wise lexicographical comparison.
under some circumstances, this is exactly what we need. so,
in this change, if the operator==() is also implemented as
a lexicographical comparison of all memeber variables of the
class/struct in question, it is implemented using the default
generated one by removing its body and mark the function as
`default`. moreover, if the class happen to have other comparison
operators which are implemented using lexicographical comparison,
the default generated `operator<=>` is used in place of
the defaulted `operator==`.

sometimes, we fail to mark the operator== with the `const`
specifier, in this change, to fulfil the need of C++ standard,
and to be more correct, the `const` specifier is added.

also, to generate the defaulted operator==, the operand should
be `const class_name&`, but it is not always the case, in the
class of `version`, we use `version` as the parameter type, to
fulfill the need of the C++ standard, the parameter type is
changed to `const version&` instead. this does not change
the semantic of the comparison operator. and is a more idiomatic
way to pass non-trivial struct as function parameters.

please note, because in C++20, both operator= and operator<=> are
symmetric, some of the operators in `multiprecision` are removed.
they are the symmetric form of the another variant. if they were
not removed, compiler would, for instance, find ambiguous
overloaded operator '=='.

this change is a cleanup to modernize the code base with C++20
features.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes #13687
2023-04-27 10:24:46 +03:00

203 lines
6.3 KiB
C++

/*
* Copyright (C) 2016-present ScyllaDB
*/
/*
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
#pragma once
#include <iterator>
template<typename T>
class anchorless_list_base_hook {
anchorless_list_base_hook<T>* _next = nullptr;
anchorless_list_base_hook<T>* _prev = nullptr;
public:
template <typename ValueType>
class iterator {
anchorless_list_base_hook<T>* _position;
public:
using iterator_category = std::bidirectional_iterator_tag;
using value_type = ValueType;
using difference_type = ssize_t;
using pointer = ValueType*;
using reference = ValueType&;
public:
explicit iterator(anchorless_list_base_hook<T>* pos) : _position(pos) { }
ValueType& operator*() { return *static_cast<ValueType*>(_position); }
ValueType* operator->() { return static_cast<ValueType*>(_position); }
iterator& operator++() {
_position = _position->_next;
return *this;
}
iterator operator++(int) {
iterator it = *this;
operator++();
return it;
}
iterator& operator--() {
_position = _position->_prev;
return *this;
}
iterator operator--(int) {
iterator it = *this;
operator--();
return it;
}
bool operator==(const iterator&) const = default;
};
template <typename ValueType>
class reverse_iterator {
anchorless_list_base_hook<T>* _position;
public:
using iterator_category = std::forward_iterator_tag;
using value_type = ValueType;
using difference_type = ssize_t;
using pointer = ValueType*;
using reference = ValueType&;
public:
explicit reverse_iterator(anchorless_list_base_hook<T>* pos) : _position(pos) { }
ValueType& operator*() { return *static_cast<ValueType*>(_position); }
ValueType* operator->() { return static_cast<ValueType*>(_position); }
reverse_iterator& operator++() {
_position = _position->_prev;
return *this;
}
reverse_iterator operator++(int) {
reverse_iterator it = *this;
operator++();
return it;
}
bool operator==(const reverse_iterator& other) const = default;
};
class range {
anchorless_list_base_hook<T>* _begin;
anchorless_list_base_hook<T>* _end;
public:
using iterator = anchorless_list_base_hook::iterator<T>;
using const_iterator = anchorless_list_base_hook::iterator<const T>;
range(anchorless_list_base_hook<T>* b, anchorless_list_base_hook<T>* e)
: _begin(b), _end(e) { }
iterator begin() { return iterator(_begin); }
iterator end() { return iterator(_end); }
const_iterator begin() const { return const_iterator(_begin); }
const_iterator end() const { return const_iterator(_end); }
};
class reversed_range {
anchorless_list_base_hook<T>* _begin;
anchorless_list_base_hook<T>* _end;
public:
using iterator = anchorless_list_base_hook::reverse_iterator<T>;
using const_iterator = anchorless_list_base_hook::reverse_iterator<const T>;
reversed_range(anchorless_list_base_hook<T>* b, anchorless_list_base_hook<T>* e)
: _begin(b), _end(e) { }
iterator begin() { return iterator(_begin); }
iterator end() { return iterator(_end); }
const_iterator begin() const { return const_iterator(_begin); }
const_iterator end() const { return const_iterator(_end); }
};
public:
anchorless_list_base_hook() = default;
anchorless_list_base_hook(const anchorless_list_base_hook&) = delete;
anchorless_list_base_hook(anchorless_list_base_hook&& other) noexcept
: _next(other._next)
, _prev(other._prev)
{
if (_next) {
_next->_prev = this;
}
if (_prev) {
_prev->_next = this;
}
other._next = nullptr;
other._prev = nullptr;
}
anchorless_list_base_hook& operator=(const anchorless_list_base_hook&) = delete;
anchorless_list_base_hook& operator=(anchorless_list_base_hook&& other) noexcept
{
if (this != &other) {
this->~anchorless_list_base_hook();
new (this) anchorless_list_base_hook(std::move(other));
}
return *this;
}
~anchorless_list_base_hook() {
erase();
}
// Inserts this after elem.
void insert_after(T& elem) {
auto e = static_cast<anchorless_list_base_hook*>(&elem);
_next = e->_next;
e->_next = this;
_prev = e;
if (_next) {
_next->_prev = this;
}
}
// Inserts the chain starting at head after this elem.
// Assumes !head.prev() and !next().
void splice(T& head) {
auto e = static_cast<anchorless_list_base_hook*>(&head);
_next = e;
e->_prev = this;
}
// Inserts this before elem.
void insert_before(T& elem) {
auto e = static_cast<anchorless_list_base_hook*>(&elem);
_prev = e->_prev;
e->_prev = this;
_next = e;
if (_prev) {
_prev->_next = this;
}
}
void erase() {
if (_next) {
_next->_prev = _prev;
}
if (_prev) {
_prev->_next = _next;
}
_next = nullptr;
_prev = nullptr;
}
bool is_front() const { return !_prev; }
bool is_back() const { return !_next; }
bool is_single() const { return is_front() && is_back(); }
T* next() const {
return static_cast<T*>(_next);
}
T* prev() const {
return static_cast<T*>(_prev);
}
T* last() const {
// FIXME: Optimize
auto v = this;
while (v->_next) {
v = v->_next;
}
return const_cast<T*>(static_cast<const T*>(v));
}
iterator<T> iterator_to() {
return iterator<T>(this);
}
range all_elements() {
auto begin = this;
while (begin->_prev) {
begin = begin->_prev;
}
return range(begin, nullptr);
}
reversed_range all_elements_reversed() {
return reversed_range(last(), nullptr);
}
range elements_from_this() {
return range(this, nullptr);
}
};