mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
3ef201d67a7521fc82b42e2ba992a16cc337ca5d
scylladb/test/boost
History
Pavel Emelyanov 0cd3a6993b sstables: Don't rely on lexicographical prefix comparison 
When creating a deletion log for a bunch of sstables the code checks
that all sstables share the same "storage" by lexicographically
comparing their prefixes. That's not correct, as filesystem paths may
refer to the same directory even if not being equal.

So far that's been mostly OK, because paths manipulations were done in
simple forms without producing unequal paths. Patch 8a061bd8 (sstables,
code: Introduce and use change_state() call) triggerred a corner case.

    fs::path foo("/foo");
    sstring sub("");
    foo = foo / sub;

produces a correct path of "/foo/", but the trailing slash breaks the
aforementioned assumption about prefixes comparison. As a result, when
an sstable moves between, say, staging and normal locations it may gain
a trailing slash breaking the deletion log creation code.

The fix is to restrict the deletion log creation not to rely on path
strings comparison completely and trim the trailing slash if it happens.

A test is included.

fixes: #13085

Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>

Closes #13090
2023-03-12 20:06:47 +02:00
..
aggregate_fcts_test.cc
test: do not initialize a time_t with braces
2023-03-07 17:54:53 +08:00
allocation_strategy_test.cc
…
alternator_unit_test.cc
…
anchorless_list_test.cc
…
auth_passwords_test.cc
…
auth_resource_test.cc
move to_string.hh to utils/
2023-02-15 11:09:04 +02:00
auth_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
batchlog_manager_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
big_decimal_test.cc
…
bptree_test.cc
…
broken_sstable_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
btree_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
bytes_ostream_test.cc
…
cache_flat_mutation_reader_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
cached_file_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
caching_options_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
canonical_mutation_test.cc
Introduce mutation/ module
2023-02-14 11:19:03 +02:00
cartesian_product_test.cc
…
castas_fcts_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
cdc_generation_test.cc
…
cdc_test.cc
types: move types.{cc,hh} into types
2023-02-19 21:05:45 +02:00
cell_locker_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
checksum_utils_test.cc
…
chunked_managed_vector_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
chunked_vector_test.cc
test/boost/chunked_vector_test: remove defaulted exception_safe_class's move ctor
2023-02-19 12:58:22 +08:00
clustering_ranges_walker_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
CMakeLists.txt
build: cmake: add more tests
2023-03-04 13:11:25 +08:00
column_mapping_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
commitlog_test.cc
commitlog: Create commitlog_replayer with system keyspace
2023-03-06 13:28:36 +03:00
compound_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
compress_test.cc
…
config_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
continuous_data_consumer_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
counter_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
cql_auth_query_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
cql_auth_syntax_test.cc
…
cql_functions_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
cql_query_group_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
cql_query_large_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
cql_query_like_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
cql_query_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
crc_test.cc
utils: spell "barrett" correctly
2022-11-16 16:30:38 +02:00
data_listeners_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
database_test.cc
commitlog: Create commitlog_replayer with system keyspace
2023-03-06 13:28:36 +03:00
dirty_memory_manager_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
double_decker_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
duration_test.cc
…
dynamic_bitset_test.cc
…
enum_option_test.cc
…
enum_set_test.cc
move to_string.hh to utils/
2023-02-15 11:09:04 +02:00
error_injection_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
estimated_histogram_test.cc
…
exception_container_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
exceptions_fallback_test.cc
…
exceptions_optimized_test.cc
…
exceptions_test.inc.cc
…
expr_test.cc
expr_test: more tests for preparing bind variables with type hints
2023-03-09 18:31:45 +01:00
extensions_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
filtering_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
flat_mutation_reader_test.cc
Merge 'readers/nonforwarding: don't emit partition_end on next_partition,fast_forward_to' from Gusev Petr
2023-03-01 09:58:14 +02:00
flush_queue_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
fragmented_temporary_buffer_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
frozen_mutation_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
gossiping_property_file_snitch_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
group0_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
hash_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
hashers_test.cc
utils: move hashing related files to utils/ module
2023-02-17 07:19:52 +02:00
hint_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
idl_test.cc
idl: make idl headers self-sufficient
2022-08-08 08:02:27 +03:00
index_with_paging_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
input_stream_test.cc
…
intrusive_array_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
json_cql_query_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
json_test.cc
…
keys_test.cc
types: move types.{cc,hh} into types
2023-02-19 21:05:45 +02:00
large_paging_state_test.cc
types: move types.{cc,hh} into types
2023-02-19 21:05:45 +02:00
like_matcher_test.cc
…
limiting_data_source_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
linearizing_input_stream_test.cc
…
lister_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
loading_cache_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
log_heap_test.cc
…
logalloc_standard_allocator_segment_pool_backend_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
logalloc_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
managed_bytes_test.cc
…
managed_vector_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
map_difference_test.cc
…
memtable_test.cc
test: memtable_test: mark dummy variable for loop [[maybe_unused]]
2023-02-28 21:56:55 +08:00
multishard_combining_reader_as_mutation_source_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
multishard_mutation_query_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
murmur_hash_test.cc
…
mutation_fragment_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
mutation_query_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
mutation_reader_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
mutation_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
mutation_writer_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
mvcc_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
network_topology_strategy_test.cc
topology: optimize compare_endpoints
2023-02-15 11:48:24 +02:00
nonwrapping_range_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
observable_test.cc
…
partitioner_test.cc
types: move types.{cc,hh} into types
2023-02-19 21:05:45 +02:00
per_partition_rate_limit_test.cc
Introduce mutation/ module
2023-02-14 11:19:03 +02:00
querier_cache_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
query_processor_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
radix_tree_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
range_assert.hh
…
range_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
range_tombstone_list_assertions.hh
Introduce mutation/ module
2023-02-14 11:19:03 +02:00
range_tombstone_list_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
rate_limiter_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
reader_concurrency_semaphore_test.cc
reader_concurrency_semaphore:: clear_inactive_reads(): defer evicting to evict()
2023-03-07 08:45:04 +03:00
recent_entries_map_test.cc
utils: introduce recent_entries_map datatype to track least recent visited entries.
2023-02-03 19:04:32 +01:00
repair_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
restrictions_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
result_utils_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
reusable_buffer_test.cc
…
role_manager_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
row_cache_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
rust_test.cc
…
schema_change_test.cc
Merge 'Allow setting permissions for user-defined functions' from Wojciech Mitros
2023-03-12 14:04:34 +02:00
schema_changes_test.cc
test,sstables: Remove path from make_sstable_easy()
2023-03-09 08:21:48 +03:00
schema_loader_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
schema_registry_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
secondary_index_test.cc
test: do not initialize plain number with {}
2023-03-07 17:54:53 +08:00
serialization_test.cc
types: move types.{cc,hh} into types
2023-02-19 21:05:45 +02:00
serialized_action_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
service_level_controller_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
small_vector_test.cc
utils: small_vector: define operator<=>
2023-02-28 20:04:22 +02:00
snitch_reset_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
sstable_3_x_test.cc
test,sstables: Remove path from make_sstable_easy()
2023-03-09 08:21:48 +03:00
sstable_compaction_test.cc
test,sstables: Remove path from make_sstable_easy()
2023-03-09 08:21:48 +03:00
sstable_conforms_to_mutation_source_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
sstable_datafile_test.cc
test,sstables: Remove path from make_sstable_easy()
2023-03-09 08:21:48 +03:00
sstable_directory_test.cc
Merge 'Sanitize with_sstable_directory() helper in tests' from Pavel Emelyanov
2023-02-10 07:11:38 +02:00
sstable_move_test.cc
sstables: Don't rely on lexicographical prefix comparison
2023-03-12 20:06:47 +02:00
sstable_mutation_test.cc
test,sstables: Remove path from make_sstable_easy()
2023-03-09 08:21:48 +03:00
sstable_partition_index_cache_test.cc
sstables: partition_index_cache: clean up an unused type alias
2023-02-17 17:58:26 +03:00
sstable_resharding_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
sstable_set_test.cc
test,sstables: Remove path from make_sstable_easy()
2023-03-09 08:21:48 +03:00
sstable_test.cc
test: Remove last occurrence of test_env::do_with(rval, ...)
2023-03-09 08:21:48 +03:00
sstable_test.hh
Introduce schema/ module
2023-02-15 11:01:50 +02:00
stall_free_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
statement_restrictions_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
storage_proxy_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
suite.yaml
test.py: Add option to run scylla tests with multiple compaction groups
2023-02-01 20:17:16 -03:00
summary_test.cc
Add summary_test
2022-07-27 16:58:52 +03:00
test_table.cc
…
top_k_test.cc
…
total_order_check.hh
move to_string.hh to utils/
2023-02-15 11:09:04 +02:00
tracing_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
transport_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
types_test.cc
types: move types.{cc,hh} into types
2023-02-19 21:05:45 +02:00
user_function_test.cc
cql3: enforce permissions on DROP FUNCTION
2023-03-09 17:51:15 +01:00
user_types_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
utf8_test.cc
…
UUID_test.cc
utils: UUID: throw marshal_exception when fail to parse uuid
2023-03-06 12:59:41 +02:00
view_build_test.cc
test: Make cql_test_env::get_system_keyspace() return sharded
2023-03-06 13:17:21 +03:00
view_complex_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
view_schema_ckey_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
view_schema_pkey_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
view_schema_test.cc
materialized views: verify CLUSTERING ORDER BY clause
2023-02-27 15:09:42 +02:00
vint_serialization_test.cc
…
virtual_reader_test.cc
test: Make cql_test_env::get_system_keyspace() return sharded
2023-03-06 13:17:21 +03:00
virtual_table_mutation_source_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
virtual_table_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
wasm_alloc_test.cc
wasm: move compilation to an alien thread
2023-03-09 11:54:38 +01:00
wasm_test.cc
wasm: move compilation to an alien thread
2023-03-09 11:54:38 +01:00