mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-01 13:45:53 +00:00
" There are several issues with it - it's scattered between main() and storage_service methods - yet another incarnation of it also sits in the cql-test-env - the prepare_to_join() and join_token_ring() names are lying to readers, as sometimes node joins the ring in prepare- stage - storage service has to carry several private fields to keep the state between prepare- and join- parts - some storage service dependencies are only needed to satisfy joining, but since they cannot start early enough, they are pushed to storage service uninitialized "in the hope" that it won't use them until join This patch puts joining steps in one place and enlightens storage service not to carry unneeded dependencies/state onboard. And eliminates one more usage of global proxy instance while at it. branch: https://github.com/xemul/scylla/tree/br-merge-init-server-and-join-cluster tests: https://jenkins.scylladb.com/job/releng/job/Scylla-CI/466/ refs: #2795 " * 'br-merge-init-server-and-join-cluster' of https://github.com/xemul/scylla: storage_service: Remove global proxy call storage_service: Remove sys_dist_ks from storage_service dependencies storage_service: Remove cdc_gen_service from storage_service dependencies storage_service: Make _cdc_gen_id local variable storage_service: Make _bootstrap_tokens local variable storage_service: Merge prepare- and join- private members storage_service: Move some code up the file storage_service: Coroutinize join_token_ring storage_service: Fix indentation after previous patch storage_service: Execute its .bootstrap() into async() storage_service: Dont assume async context in mark_existing_views_as_built storage_service: Merge init-server and join-cluster main, storage_service: Move wait for gossip to settle main, storage_service: Move passive announce subscription main, storage_service: Move early group0 join call