mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
403f66ecad6bc773712c69c4a80ebd172eb48b13
scylladb/tests
History
Avi Kivity 403f66ecad Revert "Revert "compaction: fix use-after-free when calculating backlog after schema change"" 
This reverts commit 841ceac4f9. It was reverted because the test
failed; this turned out due to a miscompile of the test.

With this additional fix, the test compiles correctly:

--- a/tests/sstable_datafile_test.cc
+++ b/tests/sstable_datafile_test.cc
@@ -4785,11 +4785,11 @@ SEASTAR_TEST_CASE(backlog_tracker_correctness_after_stop_tracking_compaction) {

             auto fut = sstables::compact_sstables(sstables::compaction_descriptor(ssts), *cf, sst_gen);

             bool stopped_tracking = false;
             for (auto& info : cf._data->cm.get_compactions()) {
-                if (info->cf == &*cf) {
+                if (info->cf == cf->schema()->cf_name()) {
                     info->stop_tracking();
                     stopped_tracking = true;
                 }
             }
             BOOST_REQUIRE(stopped_tracking);

info->cf is an sstring, and &*cf is a table*. It's not clear how the compiler
was able to compare an sstring and a pointer.
2019-04-12 21:45:59 +03:00
..
perf
Merge "Optimize checksum_combine() for CRC32" from Tomek
2018-12-08 13:42:43 +02:00
snitch_property_files
…
sstables
Merge "sstables: mc: Write and read static compact tables the same way as Cassandra" from Tomasz
2019-03-24 16:34:42 +02:00
aggregate_fcts_test.cc
tests/aggregate_fcts_test: Fix formatting of create_table()
2018-09-28 09:45:27 +02:00
allocation_strategy_test.cc
…
anchorless_list_test.cc
…
auth_passwords_test.cc
auth: Shorten random_device instance life-span
2018-09-12 12:14:21 +01:00
auth_resource_test.cc
…
auth_test.cc
query_processor: require clients to specify timeout configuration
2018-05-14 09:41:06 +03:00
batchlog_manager_test.cc
treewide: require type for creating atomic_cell
2018-05-31 15:51:11 +01:00
big_decimal_test.cc
…
bytes_ostream_test.cc
bytes_ostream: add remove_suffix()
2018-06-25 09:21:47 +01:00
cache_flat_mutation_reader_test.cc
mvcc: Use RAII to ensure that partition versions are merged
2018-06-27 21:51:04 +02:00
caching_options_test.cc
…
canonical_mutation_test.cc
tests: reduce dependencies in test_services.hh
2018-03-12 20:05:23 +02:00
cartesian_product_test.cc
…
castas_fcts_test.cc
cql3: add result class
2018-06-25 09:21:47 +01:00
cell_locker_test.cc
tests/cell_locker_test: Prevent timeout underflow
2018-06-19 16:26:52 +03:00
checksum_utils_test.cc
Merge "Optimize checksum_combine() for CRC32" from Tomek
2018-12-08 13:42:43 +02:00
chunked_vector_test.cc
…
clustering_ranges_walker_test.cc
…
commitlog_test.cc
Merge "hinted handoff: give a sender a low priority" from Vlad
2018-10-24 09:43:39 +03:00
compound_test.cc
…
compress_test.cc
…
config_test.cc
…
continuous_data_consumer_test.cc
Merge seastar upstream
2018-04-29 11:03:21 +03:00
counter_test.cc
atomic_cell: introduce fragmented buffer value interface
2018-05-31 15:51:11 +01:00
cql_assertions.cc
Merge 'Fix for a select statement with filtered columns' from Eliran
2018-10-24 09:44:46 +03:00
cql_assertions.hh
Merge 'Fix for a select statement with filtered columns' from Eliran
2018-10-24 09:44:46 +03:00
cql_auth_query_test.cc
auth: Grant all permissions to object creator
2018-03-14 01:54:31 -04:00
cql_auth_syntax_test.cc
…
cql_query_test.cc
Merge "Add DEFAULT UNSET support to JSON" from Piotr
2019-02-22 15:52:16 +02:00
cql_test_env.cc
Merge "Fix window during init where waiting for a feature can be ignored" from Avi
2019-03-20 17:25:35 +08:00
cql_test_env.hh
Merge 'Generating view updates during streaming' from Piotr
2018-11-15 17:46:20 +02:00
crc_test.cc
…
database_test.cc
tests: Check that database conforms to mutation source
2018-06-26 18:54:44 +02:00
duration_test.cc
…
dynamic_bitset_test.cc
Merge seastar upstream
2018-04-29 11:03:21 +03:00
ec2_snitch_test.cc
locator: de-inline production_snitch_base
2018-03-11 18:22:49 +02:00
enum_set_test.cc
…
eventually.hh
tests/mutation_reader_test: Extract eventually_true() to eventually.hh
2018-08-27 19:24:05 +01:00
extensions_test.cc
Extract sstable::component_type to separete header
2018-04-24 11:29:57 +02:00
failure_injecting_allocation_strategy.hh
lsa: add free() that does not require object size
2018-05-09 16:52:26 +01:00
filtering_test.cc
cql3: really ensure retrieval of columns for filtering
2019-01-23 21:11:05 +02:00
flat_mutation_reader_assertions.hh
tests: Extend reader assertions to check clustering keys made full.
2018-09-25 18:02:46 -07:00
flat_mutation_reader_test.cc
tests/flat_mutation_reader_test: extend multi-range reader tests
2018-09-28 14:27:55 +03:00
flush_queue_test.cc
tests/flush_queue_test: Don't assume continuations run immediately
2018-03-05 15:22:33 +02:00
fragmented_temporary_buffer_test.cc
Merge "Fix commitlog chunks overwriting each other" from Paweł
2019-03-04 17:58:46 +02:00
frozen_mutation_test.cc
flat_mutation_reader: make timeout opt-out rather than opt-in
2018-09-20 11:31:24 +02:00
gce_snitch_test.cc
locator: de-inline production_snitch_base
2018-03-11 18:22:49 +02:00
gossip_test.cc
Merge "Fix window during init where waiting for a feature can be ignored" from Avi
2019-03-20 17:25:35 +08:00
gossip.cc
Merge "Fix window during init where waiting for a feature can be ignored" from Avi
2019-03-20 17:25:35 +08:00
gossiping_property_file_snitch_test.cc
…
hash_test.cc
…
hint_test.cc
commitlog: use memory_output_stream
2018-09-18 17:22:59 +01:00
idl_test.cc
tests: fix a typo in idl_test.cc
2018-06-15 09:56:45 +01:00
imr_test.cc
tests/imr: add test for exception safety in imr::utils::object::make()
2018-08-01 16:50:58 +01:00
index_reader_assertions.hh
tests: Use std::adjacent_find in index_reader_assertions::has_monotonic_positions()
2018-07-20 13:51:13 -07:00
input_stream_test.cc
…
json_cql_query_test.cc
Merge " Fix INSERT JSON with null values" from Piotr
2019-02-22 15:52:46 +02:00
json_test.cc
tests: add JSON unit test
2018-07-25 13:16:06 +02:00
keys_test.cc
keys_test: add a test for nodetool_style string
2018-05-28 18:12:12 +03:00
limiting_data_source_test.cc
Add tests for make_limiting_data_source
2018-04-16 21:00:35 +02:00
loading_cache_test.cc
tests: loading_cache_test: configure a validity timeout in test_loading_cache_loading_different_keys to a greater value
2018-09-05 10:19:59 +03:00
log_heap_test.cc
…
logalloc_test.cc
Configure logalloc memory size during initialization
2018-06-11 15:34:14 +03:00
lsa_async_eviction_test.cc
…
lsa_sync_eviction_test.cc
Configure logalloc memory size during initialization
2018-06-11 15:34:14 +03:00
make_random_string.hh
…
managed_vector_test.cc
…
map_difference_test.cc
…
memory_footprint.cc
treewide: require type for creating atomic_cell
2018-05-31 15:51:11 +01:00
memtable_snapshot_source.hh
flat_mutation_reader: make timeout opt-out rather than opt-in
2018-09-20 11:31:24 +02:00
memtable_test.cc
flat_mutation_reader: make timeout opt-out rather than opt-in
2018-09-20 11:31:24 +02:00
message.cc
gossip: Reduce continuous memory usage
2018-07-17 20:15:32 +08:00
meta_test.cc
tests: introduce tests for metaprogramming helpers
2018-05-31 10:09:01 +01:00
multishard_mutation_query_test.cc
Merge "Make inactive shard readers evictable" from Botond
2018-12-04 12:13:13 +02:00
multishard_writer_test.cc
flat_mutation_reader: make timeout opt-out rather than opt-in
2018-09-20 11:31:24 +02:00
murmur_hash_test.cc
…
mutation_assertions.hh
tests/mutation_assertions.hh: add missing include
2018-09-03 10:31:44 +03:00
mutation_diff
tests: mutation_diff: Ignore differences in memory addresses
2018-07-17 16:32:04 +03:00
mutation_fragment_test.cc
flat_mutation_reader: make timeout opt-out rather than opt-in
2018-09-20 11:31:24 +02:00
mutation_query_test.cc
mutation_query_test: add test for result size calculation
2018-09-06 20:54:57 +03:00
mutation_reader_test.cc
Merge "Make inactive shard readers evictable" from Botond
2018-12-04 12:13:13 +02:00
mutation_source_test.cc
tests: mutation_source_test: generate valid utf-8 data
2019-01-08 14:53:55 +02:00
mutation_source_test.hh
Merge 'Add tests for schema changes' from Paweł
2018-12-18 14:57:50 +00:00
mutation_test.cc
Merge 'Add tests for schema changes' from Paweł
2018-12-18 14:57:50 +00:00
mvcc_test.cc
Merge "Fix use-after-free when destroying partition_snapshots in the background"from Tomasz
2018-12-28 13:37:29 +02:00
network_topology_strategy_test.cc
locator: fix abstract_replication_strategy::get_ranges() and friends violating sort order
2018-10-23 07:36:21 +00:00
nonwrapping_range_test.cc
…
normalizing_reader.cc
tests: Multiple fixes for draining and clearing range tombstones in normalizing_reader.
2018-09-26 19:24:10 -07:00
normalizing_reader.hh
tests: Introduce normalizing_reader helper for SSTables tests.
2018-09-25 17:55:52 -07:00
observable_test.cc
observable: allow an observable to disconnect() twice without penalty
2018-07-11 10:15:01 +01:00
partition_data_test.cc
tests: test imr representation of cells
2018-05-31 15:51:11 +01:00
partitioner_test.cc
…
perf_row_cache_update.cc
flat_mutation_reader: make timeout opt-out rather than opt-in
2018-09-20 11:31:24 +02:00
querier_cache.cc
querier_cache: check that the query wasn't evicted during registering
2018-12-18 14:34:33 +02:00
query_processor_test.cc
…
random-utils.hh
Merge 'Add tests for schema changes' from Paweł
2018-12-18 14:57:50 +00:00
range_assert.hh
…
range_test.cc
…
range_tombstone_list_assertions.hh
…
range_tombstone_list_test.cc
…
result_set_assertions.cc
…
result_set_assertions.hh
…
reusable_buffer_test.cc
tests/reusable_buffer: test fragmented_temporary_buffer support
2018-07-18 12:28:06 +01:00
role_manager_test.cc
…
row_cache_alloc_stress.cc
flat_mutation_reader: make timeout opt-out rather than opt-in
2018-09-20 11:31:24 +02:00
row_cache_stress_test.cc
flat_mutation_reader: make timeout opt-out rather than opt-in
2018-09-20 11:31:24 +02:00
row_cache_test.cc
row_cache: Fix abort in cache populating read concurrent with memtable flush
2019-03-22 09:31:59 -03:00
row_locker_test.cc
db: add row locking metrics
2018-05-22 16:52:58 +02:00
schema_change_test.cc
db: schema_tables: Treat drop of scylla_tables.version as an alter
2018-04-27 17:12:33 +03:00
schema_registry_test.cc
…
secondary_index_test.cc
secondary indexes: fail attempts to create a CUSTOM INDEX
2018-12-12 00:32:35 +00:00
serialized_action_test.cc
…
simple_schema.hh
atomic_cell: introduce fragmented buffer value interface
2018-05-31 15:51:11 +01:00
snitch_reset_test.cc
…
sstable_3_x_test.cc
Merge "sstables: mc: Write and read static compact tables the same way as Cassandra" from Tomasz
2019-03-24 16:34:42 +02:00
sstable_datafile_test.cc
Revert "Revert "compaction: fix use-after-free when calculating backlog after schema change""
2019-04-12 21:45:59 +03:00
sstable_mutation_test.cc
Merge "sstables: mc: Write and read static compact tables the same way as Cassandra" from Tomasz
2019-03-24 16:34:42 +02:00
sstable_resharding_test.cc
row_cache: deglobalise row cache tracker
2018-06-25 09:37:43 +01:00
sstable_test.cc
sstables: Write Statistics.db offset map entries in the same order as Cassandra
2018-12-04 14:30:19 +02:00
sstable_test.hh
Merge "Fix tombstone histogram when writing SSTables 3.x" from Vladimir
2018-12-08 14:08:44 +02:00
sstable_utils.cc
database, sstables, tests: add large_partition_handler
2018-05-04 14:38:13 +02:00
sstable_utils.hh
tests: Allow random_mutation_generator to generate mutations belong to remote shrard
2018-06-28 17:20:28 +08:00
storage_proxy_test.cc
…
streaming_histogram_test.cc
…
test_services.hh
tests: reduce dependencies in test_services.hh
2018-03-12 20:05:23 +02:00
test-serialization.cc
…
tmpdir.hh
…
total_order_check.hh
Remove to_boost_visitor heler.
2018-03-14 23:49:07 +00:00
transport_test.cc
transport: switch to fragmented_temporary_buffer
2018-07-18 12:28:06 +01:00
types_test.cc
types: Make seastar::inet_address the "native" type for CQL inet.
2018-04-24 23:12:07 +01:00
UUID_test.cc
tests/uuid: add more tests including make_randm_uuid()
2018-07-26 12:03:37 +01:00
view_build_test.cc
Materialized views: limit size of row batching during bulk view building
2019-02-16 21:54:41 +02:00
view_complex_test.cc
view_complex_test: fix another ttl
2019-03-31 12:28:37 +03:00
view_schema_test.cc
Merge "db/view: Apply tracked tombstones for new updates" from Duarte
2019-03-27 21:56:21 +00:00
vint_serialization_test.cc
Cover serialized_size_from_first_byte in tests
2018-04-16 20:26:44 +02:00
virtual_reader_test.cc
db/view/view_builder: Don't timeout waiting for view to be built
2018-12-05 19:20:36 +00:00