af485f5226
In commit 3e39985c7a we added the Cassandra-compatible system table
system."IndexInfo" (note the capitalized table name) which lists built
indexes. Because we already had a table of built materialized views, and
indexes are implemented as materialized views, the index list was
implemented as a virtual table based on the view list.
However, the *name* of each materialized view listed in the list of
views looks like something_index, with the suffix "_index", while the
name of the table we need to print is "something". We forgot to do this
transformation in the virtual table - and this is what this patch does.
This bug can confuse applications which use this system table to wait for
an index to be built. Several tests translated from Cassandra's unit
tests, in cassandra_tests/validation/entities/secondary_index_test.py fail
in wait_for_index() because of this incompatibility, and pass after this
patch.
This patch also changes the unit test that enshrined the previous, wrong,
behavior, to test for the correct behavior. This problem is typical of
C++ unit tests which cannot be run against Cassandra.
Fixes #8600
Unfortunately, although this patch fixes "typical" applications (including
all tests which I tried) - applications which read from IndexInfo in a
"typical" method to look for a specific index being ready, the
implementation is technically NOT correct: The problem is that index
names are not sorted in the right order, because they are sorted with
the "_index" prefix.
To give an example, the index names "a" should be listed before "a1", but
the view names "a1_index" comes before "a_index" (because in ASCII, 1
comes before underscore). I can't think of any way to fix this bug
without completely reimplementing IndexInfo in a different way - probably
based on a temporary memtable (which is fine as this is not a
performance-critical operation). We'll need to do this rewrite eventually,
and I'll open a new issue.
Signed-off-by: Nadav Har'El <nyh@scylladb.com>
Message-Id: <20210509140113.1084497-1-nyh@scylladb.com>
262 lines
16 KiB
C++
262 lines
16 KiB
C++
/*
|
|
* Copyright (C) 2016 ScyllaDB
|
|
*
|
|
* Modified by ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <boost/range/irange.hpp>
|
|
#include <boost/range/adaptors.hpp>
|
|
#include <boost/range/algorithm.hpp>
|
|
#include <boost/test/unit_test.hpp>
|
|
#include <stdint.h>
|
|
|
|
#include <seastar/testing/test_case.hh>
|
|
#include "test/lib/cql_test_env.hh"
|
|
#include "test/lib/cql_assertions.hh"
|
|
#include "test/lib/test_services.hh"
|
|
|
|
#include "index/secondary_index_manager.hh"
|
|
#include "db/size_estimates_virtual_reader.hh"
|
|
#include "db/system_keyspace.hh"
|
|
#include "db/view/view_builder.hh"
|
|
#include <seastar/core/future-util.hh>
|
|
#include "cql3/query_processor.hh"
|
|
#include "cql3/untyped_result_set.hh"
|
|
#include "dht/i_partitioner.hh"
|
|
#include "transport/messages/result_message.hh"
|
|
|
|
using namespace std::literals::chrono_literals;
|
|
|
|
SEASTAR_TEST_CASE(test_query_size_estimates_virtual_table) {
|
|
return do_with_cql_env_thread([] (cql_test_env& e) {
|
|
auto ranges = db::size_estimates::test_get_local_ranges(e.local_db()).get0();
|
|
auto start_token1 = utf8_type->to_string(ranges[3].start);
|
|
auto start_token2 = utf8_type->to_string(ranges[5].start);
|
|
auto end_token1 = utf8_type->to_string(ranges[3].end);
|
|
auto end_token2 = utf8_type->to_string(ranges[55].end);
|
|
|
|
// Should not timeout.
|
|
e.execute_cql("select * from system.size_estimates;").discard_result().get();
|
|
|
|
auto rs = e.execute_cql("select * from system.size_estimates where keyspace_name = 'ks';").get0();
|
|
assert_that(rs).is_rows().with_size(0);
|
|
|
|
e.execute_cql("create table cf1(pk text PRIMARY KEY, v int);").discard_result().get();
|
|
e.execute_cql("create table cf2(pk text PRIMARY KEY, v int);").discard_result().get();
|
|
|
|
rs = e.execute_cql("select * from system.size_estimates where keyspace_name = 'ks';").get0();
|
|
assert_that(rs).is_rows().with_size(512);
|
|
|
|
rs = e.execute_cql("select * from system.size_estimates where keyspace_name = 'ks' limit 100;").get0();
|
|
assert_that(rs).is_rows().with_size(100);
|
|
|
|
rs = e.execute_cql("select * from system.size_estimates where keyspace_name = 'ks' and table_name = 'cf1';").get0();
|
|
assert_that(rs).is_rows().with_size(256);
|
|
|
|
rs = e.execute_cql("select * from system.size_estimates where keyspace_name = 'ks' and table_name > 'cf1';").get0();
|
|
assert_that(rs).is_rows().with_size(256);
|
|
|
|
rs = e.execute_cql("select * from system.size_estimates where keyspace_name = 'ks' and table_name >= 'cf1';").get0();
|
|
assert_that(rs).is_rows().with_size(512);
|
|
|
|
rs = e.execute_cql("select * from system.size_estimates where keyspace_name = 'ks' and table_name < 'cf2';").get0();
|
|
assert_that(rs).is_rows().with_size(256);
|
|
|
|
rs = e.execute_cql("select * from system.size_estimates where keyspace_name = 'ks' and table_name <= 'cf2';").get0();
|
|
assert_that(rs).is_rows().with_size(512);
|
|
|
|
rs = e.execute_cql("select * from system.size_estimates where keyspace_name = 'ks' and table_name in ('cf1', 'cf2');").get0();
|
|
assert_that(rs).is_rows().with_size(512);
|
|
|
|
rs = e.execute_cql("select * from system.size_estimates where keyspace_name = 'ks' and table_name >= 'cf1' and table_name <= 'cf1';").get0();
|
|
assert_that(rs).is_rows().with_size(256);
|
|
|
|
rs = e.execute_cql("select * from system.size_estimates where keyspace_name = 'ks' and table_name >= 'cf1' and table_name <= 'cf2';").get0();
|
|
assert_that(rs).is_rows().with_size(512);
|
|
|
|
rs = e.execute_cql("select * from system.size_estimates where keyspace_name = 'ks' and table_name > 'cf1' and table_name < 'cf2';").get0();
|
|
assert_that(rs).is_rows().with_size(0);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start = '%s';", start_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start >= '%s';", start_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(253);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start > '%s';", start_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(252);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start <= '%s';", start_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(4);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start < '%s';", start_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(3);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start >= '%s' and range_start <= '%s';", start_token1, start_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start >= '%s' and range_start <= '%s';", start_token1, start_token2)).get0();
|
|
assert_that(rs).is_rows().with_size(3);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start > '%s' and range_start < '%s';", start_token1, start_token2)).get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start in ('%s', '%s');", start_token1, start_token2)).get0();
|
|
assert_that(rs).is_rows().with_size(2);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start > '%s' and range_start <= '%s';", start_token1, start_token2)).get0();
|
|
assert_that(rs).is_rows().with_size(2);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start >= '%s' and range_start < '%s';", start_token1, start_token2)).get0();
|
|
assert_that(rs).is_rows().with_size(2);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start = '%s' and range_end = '%s';", start_token1, end_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start = '%s' and range_end >= '%s';", start_token1, end_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start = '%s' and range_end > '%s';", start_token1, end_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(0);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start = '%s' and range_end <= '%s';", start_token1, end_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start = '%s' and range_end < '%s';", start_token1, end_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(0);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start = '%s' and range_end >= '%s' and range_end <= '%s';", start_token1, end_token1, end_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and table_name = 'cf1' and range_start = '%s' and range_end > '%s' and range_end < '%s';", start_token1, end_token1, end_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(0);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and (table_name, range_start, range_end) = ('cf1', '%s', '%s');", start_token1, end_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and (table_name, range_start, range_end) >= ('cf1', '%s', '%s') and (table_name) <= ('cf2');", start_token1, end_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(509);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and (table_name, range_start, range_end) >= ('cf1', '%s', '%s') "
|
|
"and (table_name, range_start) <= ('cf2', '%s');", start_token1, end_token1, start_token2)).get0();
|
|
assert_that(rs).is_rows().with_size(259);
|
|
|
|
rs = e.execute_cql(sprint("select * from system.size_estimates where keyspace_name = 'ks' "
|
|
"and (table_name, range_start) < ('cf2', '%s');", start_token1)).get0();
|
|
assert_that(rs).is_rows().with_size(259);
|
|
});
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_query_view_built_progress_virtual_table) {
|
|
return do_with_cql_env_thread([] (cql_test_env& e) {
|
|
auto rand = [] { return dht::token::get_random_token(); };
|
|
auto next_token = rand();
|
|
auto next_token_str = next_token.to_sstring();
|
|
db::system_keyspace::register_view_for_building("ks", "v1", rand()).get();
|
|
db::system_keyspace::register_view_for_building("ks", "v2", rand()).get();
|
|
db::system_keyspace::register_view_for_building("ks", "v3", rand()).get();
|
|
db::system_keyspace::update_view_build_progress("ks", "v3", next_token).get();
|
|
db::system_keyspace::register_view_for_building("ks", "v4", rand()).get();
|
|
db::system_keyspace::update_view_build_progress("ks", "v4", next_token).get();
|
|
db::system_keyspace::register_view_for_building("ks", "v5", rand()).get();
|
|
db::system_keyspace::register_view_for_building("ks", "v6", rand()).get();
|
|
db::system_keyspace::remove_view_build_progress_across_all_shards("ks", "v5").get();
|
|
db::system_keyspace::remove_view_build_progress_across_all_shards("ks", "v6").get();
|
|
auto rs = e.execute_cql("select * from system.views_builds_in_progress where keyspace_name = 'ks'").get0();
|
|
assert_that(rs).is_rows().with_rows_ignore_order({
|
|
{ {utf8_type->decompose(sstring("ks"))}, {utf8_type->decompose(sstring("v1"))}, {int32_type->decompose(0)}, { } },
|
|
{ {utf8_type->decompose(sstring("ks"))}, {utf8_type->decompose(sstring("v2"))}, {int32_type->decompose(0)}, { } },
|
|
{ {utf8_type->decompose(sstring("ks"))}, {utf8_type->decompose(sstring("v3"))}, {int32_type->decompose(0)}, {utf8_type->decompose(next_token_str)} },
|
|
{ {utf8_type->decompose(sstring("ks"))}, {utf8_type->decompose(sstring("v4"))}, {int32_type->decompose(0)}, {utf8_type->decompose(next_token_str)} }
|
|
});
|
|
rs = e.execute_cql("select * from system.views_builds_in_progress").get0();
|
|
assert_that(rs).is_rows().with_size(4);
|
|
rs = e.execute_cql("select * from system.views_builds_in_progress limit 1").get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
rs = e.execute_cql("select * from system.views_builds_in_progress where keyspace_name = 'ks' and view_name = 'v2'").get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
rs = e.execute_cql("select * from system.views_builds_in_progress where keyspace_name = 'ks' and view_name > 'v2'").get0();
|
|
assert_that(rs).is_rows().with_size(2);
|
|
rs = e.execute_cql("select * from system.views_builds_in_progress where keyspace_name = 'ks' and view_name >= 'v2'").get0();
|
|
assert_that(rs).is_rows().with_size(3);
|
|
rs = e.execute_cql("select * from system.views_builds_in_progress where keyspace_name = 'ks' and view_name < 'v2'").get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
rs = e.execute_cql("select * from system.views_builds_in_progress where keyspace_name = 'ks' and view_name <= 'v2'").get0();
|
|
assert_that(rs).is_rows().with_size(2);
|
|
rs = e.execute_cql("select * from system.views_builds_in_progress where keyspace_name = 'ks' and view_name in ('v1', 'v2', 'v3')").get0();
|
|
assert_that(rs).is_rows().with_size(3);
|
|
rs = e.execute_cql("select * from system.views_builds_in_progress where keyspace_name = 'ks' and view_name >= 'v2' and view_name <= 'v2'").get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
rs = e.execute_cql("select * from system.views_builds_in_progress where keyspace_name = 'ks' and view_name >= 'v2' and view_name <= 'v3'").get0();
|
|
assert_that(rs).is_rows().with_size(2);
|
|
rs = e.execute_cql("select * from system.views_builds_in_progress where keyspace_name = 'ks' and view_name > 'v1' and view_name < 'v2'").get0();
|
|
assert_that(rs).is_rows().with_size(0);
|
|
});
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_query_built_indexes_virtual_table) {
|
|
return do_with_cql_env_thread([] (cql_test_env& e) {
|
|
auto idx = secondary_index::index_table_name("idx");
|
|
e.execute_cql("create table cf(p int PRIMARY KEY, v int);").get();
|
|
auto f1 = e.local_view_builder().wait_until_built("ks", "vcf");
|
|
auto f2 = e.local_view_builder().wait_until_built("ks", idx);
|
|
e.execute_cql("create materialized view vcf as select * from cf "
|
|
"where v is not null and p is not null "
|
|
"primary key (v, p)").get();
|
|
e.execute_cql("create index idx on cf (v)").get();
|
|
f1.get();
|
|
f2.get();
|
|
auto rs = e.execute_cql("select * from system.built_views").get0();
|
|
assert_that(rs).is_rows().with_rows_ignore_order({
|
|
{ {utf8_type->decompose(sstring("ks"))}, {utf8_type->decompose(idx)} },
|
|
{ {utf8_type->decompose(sstring("ks"))}, {"vcf"} },
|
|
});
|
|
rs = e.execute_cql("select * from system.\"IndexInfo\"").get0();
|
|
assert_that(rs).is_rows().with_rows_ignore_order({
|
|
{ {utf8_type->decompose(sstring("ks"))}, {utf8_type->decompose(sstring("idx"))} },
|
|
});
|
|
rs = e.execute_cql("select * from system.\"IndexInfo\" where table_name = 'ks' and index_name = 'idx'").get0();
|
|
assert_that(rs).is_rows().with_size(1);
|
|
rs = e.execute_cql("select * from system.\"IndexInfo\" where table_name = 'ks' and index_name = 'vcf'").get0();
|
|
assert_that(rs).is_rows().with_size(0);
|
|
});
|
|
}
|