mirror of
https://github.com/scylladb/scylladb.git
synced 2026-06-01 04:26:48 +00:00
Before this patch the iterations over migration_notifier::_listeners could race with listeners being added and removed. The addition side is not modified, since it is common to add a listener during construction and it would require a fairly big refactoring. Instead, the iteration is modified to use indexes instead of iterators so that it is still valid if another listener is added concurrently. For removal we use a rw lock, since removing an element invalidates indexes too. There are only a few places that needed refactoring to handle unregister_listener returning a future<>, so this is probably OK. Fixes #5541. Signed-off-by: Rafael Ávila de Espíndola <espindola@scylladb.com> Message-Id: <20200120192819.136305-1-espindola@scylladb.com>
143 lines
4.2 KiB
C++
143 lines
4.2 KiB
C++
/*
|
|
* Copyright (C) 2019 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <functional>
|
|
#include <optional>
|
|
#include <map>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include <seastar/core/future.hh>
|
|
#include <seastar/core/lowres_clock.hh>
|
|
#include <seastar/core/shared_ptr.hh>
|
|
#include <seastar/core/sstring.hh>
|
|
|
|
#include "exceptions/exceptions.hh"
|
|
#include "timestamp.hh"
|
|
#include "cdc_options.hh"
|
|
|
|
class schema;
|
|
using schema_ptr = seastar::lw_shared_ptr<const schema>;
|
|
|
|
namespace locator {
|
|
|
|
class snitch_ptr;
|
|
class token_metadata;
|
|
|
|
} // namespace locator
|
|
|
|
namespace service {
|
|
|
|
class migration_notifier;
|
|
class storage_proxy;
|
|
class query_state;
|
|
|
|
} // namespace service
|
|
|
|
namespace dht {
|
|
|
|
class i_partitioner;
|
|
|
|
} // namespace dht
|
|
|
|
class mutation;
|
|
class partition_key;
|
|
|
|
namespace cdc {
|
|
|
|
class db_context;
|
|
|
|
// Callback to be invoked on mutation finish to fix
|
|
// the whole bit about post-image.
|
|
// TODO: decide on what the parameters are to be for this.
|
|
using result_callback = std::function<future<>()>;
|
|
|
|
/// \brief CDC service, responsible for schema listeners
|
|
///
|
|
/// CDC service will listen for schema changes and iff CDC is enabled/changed
|
|
/// create/modify/delete corresponding log tables etc as part of the schema change.
|
|
///
|
|
class cdc_service {
|
|
class impl;
|
|
std::unique_ptr<impl> _impl;
|
|
public:
|
|
future<> stop();
|
|
cdc_service(service::storage_proxy&);
|
|
cdc_service(db_context);
|
|
~cdc_service();
|
|
|
|
// If any of the mutations are cdc enabled, optionally selects preimage, and adds the
|
|
// appropriate augments to set the log entries.
|
|
// Iff post-image is enabled for any of these, a non-empty callback is also
|
|
// returned to be invoked post the mutation query.
|
|
future<std::tuple<std::vector<mutation>, result_callback>> augment_mutation_call(
|
|
lowres_clock::time_point timeout,
|
|
std::vector<mutation>&& mutations
|
|
);
|
|
bool needs_cdc_augmentation(const std::vector<mutation>&) const;
|
|
};
|
|
|
|
struct db_context final {
|
|
service::storage_proxy& _proxy;
|
|
service::migration_notifier& _migration_notifier;
|
|
locator::token_metadata& _token_metadata;
|
|
locator::snitch_ptr& _snitch;
|
|
dht::i_partitioner& _partitioner;
|
|
|
|
class builder final {
|
|
service::storage_proxy& _proxy;
|
|
std::optional<std::reference_wrapper<service::migration_notifier>> _migration_notifier;
|
|
std::optional<std::reference_wrapper<locator::token_metadata>> _token_metadata;
|
|
std::optional<std::reference_wrapper<locator::snitch_ptr>> _snitch;
|
|
std::optional<std::reference_wrapper<dht::i_partitioner>> _partitioner;
|
|
public:
|
|
builder(service::storage_proxy& proxy);
|
|
|
|
builder& with_migration_notifier(service::migration_notifier& migration_notifier);
|
|
builder& with_token_metadata(locator::token_metadata& token_metadata);
|
|
builder& with_snitch(locator::snitch_ptr& snitch);
|
|
builder& with_partitioner(dht::i_partitioner& partitioner);
|
|
|
|
db_context build();
|
|
};
|
|
};
|
|
|
|
// cdc log table operation
|
|
enum class operation : int8_t {
|
|
// note: these values will eventually be read by a third party, probably not privvy to this
|
|
// enum decl, so don't change the constant values (or the datatype).
|
|
pre_image = 0, update = 1, row_delete = 2, range_delete_start = 3, range_delete_end = 4, partition_delete = 5
|
|
};
|
|
|
|
// cdc log data column operation
|
|
enum class column_op : int8_t {
|
|
// same as "operation". Do not edit values or type/type unless you _really_ want to.
|
|
set = 0, del = 1, add = 2,
|
|
};
|
|
|
|
seastar::sstring log_name(const seastar::sstring& table_name);
|
|
|
|
seastar::sstring desc_name(const seastar::sstring& table_name);
|
|
|
|
} // namespace cdc
|