mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
4c19b484955bb90a9a78ec5cd968bfab80edb921
scylladb/cql3/statements
History
Nadav Har'El abb6817261 cql: validate bloom_filter_fp_chance up-front 
Scylla's Bloom filter implementation has a minimal false-positive rate
that it can support (6.71e-5). When setting bloom_filter_fp_chance any
lower than that, the compute_bloom_spec() function, which writes the bloom
filter, throws an exception. However, this is too late - it only happens
while flushing the memtable to disk, and a failure at that point causes
Scylla to crash.

Instead, we should refuse the table creation with the unsupported
bloom_filter_fp_chance. This is also what Cassandra did six years ago -
see CASSANDRA-11920.

This patch also includes a regression test, which crashes Scylla before
this patch but passes after the patch (and also passes on Cassandra).

Fixes #11524.

Signed-off-by: Nadav Har'El <nyh@scylladb.com>

Closes #11576

(cherry picked from commit 4c93a694b7)
2022-10-04 16:21:48 +03:00
..
raw
cql3: grammar: make where clause return an expression
2022-07-22 20:14:48 +03:00
alter_keyspace_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
alter_keyspace_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
alter_role_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
alter_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
alter_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
alter_table_statement.cc
cql3: statements: add a synchronous_updates property
2022-07-25 09:53:33 +02:00
alter_table_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
alter_type_statement.cc
treewide: stop use of deprecated coroutine::make_exception
2022-07-07 15:02:16 +03:00
alter_type_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
alter_view_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
alter_view_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
attach_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
attach_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
authentication_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
authentication_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
authorization_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
authorization_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
batch_statement.cc
storage_proxy: add allow rate limit flag to mutate/mutate_result
2022-06-22 20:16:49 +02:00
batch_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
bound.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cas_request.cc
lwt: Cassandrda compatibility when incarnating a row for UPDATE
2022-06-16 19:23:46 +03:00
cas_request.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cf_prop_defs.cc
cql: validate bloom_filter_fp_chance up-front
2022-10-04 16:21:48 +03:00
cf_prop_defs.hh
cql3: statements: add a synchronous_updates property
2022-07-25 09:53:33 +02:00
cf_properties.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cf_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
create_aggregate_statement.cc
db,cql3: Move part of cql3's function into db
2022-07-18 15:25:41 +02:00
create_aggregate_statement.hh
db,cql3: Move part of cql3's function into db
2022-07-18 15:25:41 +02:00
create_function_statement.cc
wasm: reuse UDF instances
2022-07-20 18:19:22 +02:00
create_function_statement.hh
db,cql3: Move part of cql3's function into db
2022-07-18 15:25:41 +02:00
create_index_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
create_index_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
create_keyspace_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
create_keyspace_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
create_role_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
create_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
create_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
create_table_statement.cc
cql3: statements: add a synchronous_updates property
2022-07-25 09:53:33 +02:00
create_table_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
create_type_statement.cc
treewide: stop use of deprecated coroutine::make_exception
2022-07-07 15:02:16 +03:00
create_type_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
create_view_statement.cc
cql3: grammar: make where clause return an expression
2022-07-22 20:14:48 +03:00
create_view_statement.hh
cql3: grammar: make where clause return an expression
2022-07-22 20:14:48 +03:00
delete_statement.cc
cql3: grammar: make where clause return an expression
2022-07-22 20:14:48 +03:00
delete_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
detach_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
detach_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
drop_aggregate_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_aggregate_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_function_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_function_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_index_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_index_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_keyspace_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_keyspace_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_role_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
drop_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
drop_table_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_table_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_type_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_type_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_view_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_view_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
function_statement.cc
gms: feature_service: remove variable/helper function duplication
2022-05-04 18:59:56 +03:00
function_statement.hh
db,cql3: Move part of cql3's function into db
2022-07-18 15:25:41 +02:00
grant_role_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
grant_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
grant_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_prop_defs.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_prop_defs.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_target.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_target.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
ks_prop_defs.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
ks_prop_defs.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_permissions_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_permissions_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_roles_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_service_level_attachments_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_service_level_attachments_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_users_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_users_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
modification_statement.cc
cql3: grammar: make where clause return an expression
2022-07-22 20:14:48 +03:00
modification_statement.hh
cql3: grammar: make where clause return an expression
2022-07-22 20:14:48 +03:00
permission_altering_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
permission_altering_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
prepared_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
property_definitions.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
property_definitions.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
prune_materialized_view_statement.cc
cql3: add a statement for deleting ghost rows
2022-05-19 10:11:50 +02:00
prune_materialized_view_statement.hh
cql3: add a statement for deleting ghost rows
2022-05-19 10:11:50 +02:00
request_validations.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
revoke_role_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
revoke_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
revoke_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
role-management-statements.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
schema_altering_statement.cc
treewide: remove unnecessary migration_manager::is_raft_enabled() calls
2022-06-23 16:14:41 +02:00
schema_altering_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
select_statement.cc
cql3: grammar: make where clause return an expression
2022-07-22 20:14:48 +03:00
select_statement.hh
cql3: Use expression for index restrictions
2022-07-01 16:29:11 +02:00
service_level_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
service_level_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
sl_prop_defs.cc
cql3: fix misleading error message for service level timeouts
2022-03-31 07:04:00 +03:00
sl_prop_defs.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
statement_type.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
truncate_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
truncate_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
update_statement.cc
cql3: grammar: make where clause return an expression
2022-07-22 20:14:48 +03:00
update_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
use_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
use_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00