scylladb

mirror of https://github.com/scylladb/scylladb.git synced 2026-04-19 16:15:07 +00:00

Files

Tomasz Grabiec 341b509f68 cql_test_env: Make initialization exception-safe

Currently start() is not prepared to handle exceptions thrown from
service initialization. It's easy to trigger such exceprion by
starting two tests at the same time, which will result in socket bind
error.

Exception thrown from start() typically results in assertion failures
like this one:

  seastar::sharded<Service>::~sharded() [with Service = database]: Assertion `_instances.empty()' failed.

This patch fixes the problem by combining start() and stop() in a
single do_with() and using RAII for stopping services.

Now exceptions thrown from service initialization should stop services
in proper order and let the original exception to pass
through. Example result:

  fatal error in "test_new_schema_with_no_structural_change_is_propagated": std::runtime_error: bind: Address already in use
Message-Id: <1458768018-27662-1-git-send-email-tgrabiec@scylladb.com>

2016-03-24 11:20:01 +02:00

perf_cql_parser.cc

exception: Optionally shutdown communication on I/O errors.

2016-03-17 15:02:52 +02:00

perf_hash.cc

exception: Optionally shutdown communication on I/O errors.

2016-03-17 15:02:52 +02:00

perf_mutation.cc

exception: Optionally shutdown communication on I/O errors.

2016-03-17 15:02:52 +02:00

perf_simple_query.cc

cql_test_env: Make initialization exception-safe