mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
4e87f95b4225c98cb83257a6fc8215feb7b04731
scylladb/test/boost
History
Benny Halevy 7862cad669 sstable_set: partitioned_sstable_set: clone: do clone all sstables 
The existing implementation wrongfully shares _all sstables
rather than cloning it. This caused a use-after-free
in `repair_meta::do_estimate_partitions_on_local_shard`
when traversing a shared sstable_set, during which
`table::make_reader_excluding_sstables` erased an entry.
The erase should have happened on a cloned copy
of the sstable_list, not on a shared copy.

The regression was introduced in
c3b8757fa1.

Added a unit test that reproduces the share-on-copy issue
for partitioned_stable_set (sstables::sstable_set).

Fixes #8274

Test: unit(release, debug)
DTest: materialized_views_test.py:TestMaterializedViews.simple_repair_test(debug)
Signed-off-by: Benny Halevy <bhalevy@scylladb.com>
Reviewed-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
Message-Id: <20210317145552.701559-1-bhalevy@scylladb.com>
2021-03-18 11:15:59 +02:00
..
aggregate_fcts_test.cc
cql3: Use correct comparator in timeuuid min/max
2021-01-13 11:07:29 +02:00
allocation_strategy_test.cc
…
alternator_base64_test.cc
…
anchorless_list_test.cc
…
auth_passwords_test.cc
codebase wide: replace count with contains
2020-08-15 20:26:02 +03:00
auth_resource_test.cc
…
auth_test.cc
auth: Permit ALTER options on system_auth tables
2020-11-16 22:32:32 -05:00
batchlog_manager_test.cc
storage_proxy: un-hardcode force sync flag for mutate_locally(mutation) overload
2020-07-16 16:38:48 +03:00
big_decimal_test.cc
big_decimal: Add a test for a corner case
2020-06-25 15:37:23 -07:00
bptree_test.cc
bptree: Special intra-node key search when possible
2020-08-06 15:41:31 +03:00
broken_sstable_test.cc
tree-wide: use sstables::make_reader() instead of the read_.*row.*_flat() methods
2021-01-27 17:38:17 +02:00
btree_test.cc
utils: Intrusive B-tree (with tests)
2021-02-02 09:30:29 +03:00
bytes_ostream_test.cc
bytes_ostream: max_chunk_size: account for chunk header
2021-03-10 19:54:12 +02:00
cache_flat_mutation_reader_test.cc
mutation_partition: Switch cache of rows onto B-tree
2021-02-02 09:30:30 +03:00
cached_file_test.cc
…
caching_options_test.cc
…
canonical_mutation_test.cc
…
cartesian_product_test.cc
…
castas_fcts_test.cc
test: avoid using literal suffix 'd'
2020-09-21 16:32:53 +03:00
cdc_generation_test.cc
cdc: Limit size of topology description
2021-02-17 13:24:40 +01:00
cdc_test.cc
sys_dist_ks: split CDC streams table partitions into clustered rows
2021-02-18 11:44:59 +01:00
cell_locker_test.cc
…
checksum_utils_test.cc
…
chunked_vector_test.cc
utils/chunked_vector: add reserve_partial()
2020-11-02 18:02:01 +02:00
clustering_ranges_walker_test.cc
clustering_range_walker: fix false discontiguity detected after a static row
2021-02-01 19:32:07 +02:00
column_mapping_test.cc
lwt: add column_mapping history persistence tests
2020-10-15 19:25:24 +03:00
commitlog_test.cc
commitlog: Make pre-allocation drop O_DSYNC while pre-filling
2021-03-15 09:35:45 +00:00
compound_test.cc
keys, compound: switch from bytes_view to managed_bytes_view
2021-01-08 14:16:08 +01:00
compress_test.cc
…
config_test.cc
alternator: guard streams with an experimental flag
2020-11-12 12:36:16 +01:00
continuous_data_consumer_test.cc
test: everywhere: use seastar::testing::local_random_engine
2021-01-13 11:07:29 +02:00
counter_test.cc
imr: switch back to open-coded description of structures
2021-02-16 23:43:07 +01:00
cql_auth_query_test.cc
…
cql_auth_syntax_test.cc
…
cql_functions_test.cc
cql3: Use correct comparator in timeuuid min/max
2021-01-13 11:07:29 +02:00
cql_query_group_test.cc
cql3: Delete some newlines
2020-10-19 15:40:55 -04:00
cql_query_large_test.cc
treewide: remove timeout config from query options
2021-02-25 17:20:27 +01:00
cql_query_like_test.cc
cql3/restrictions: Use free functions instead of methods
2020-07-07 23:08:09 +02:00
cql_query_test.cc
cql_query_test: add unit test for the more efficient range scan result format
2021-03-02 08:01:53 +02:00
crc_test.cc
…
data_listeners_test.cc
code: Force formatting of pointer in .debug and .trace
2020-08-26 20:44:11 +03:00
database_test.cc
result_memory_accounter: abort unpaged queries hitting the global limit
2021-02-26 23:43:16 +02:00
double_decker_test.cc
test: switch lsa-related tests (imr_test and double_decker_test) to seastar framework
2020-10-30 08:06:04 +02:00
duration_test.cc
…
dynamic_bitset_test.cc
…
enum_option_test.cc
codebase wide: replace count with contains
2020-08-15 20:26:02 +03:00
enum_set_test.cc
…
error_injection_test.cc
…
estimated_histogram_test.cc
…
extensions_test.cc
Mark CDC as GA
2020-11-12 12:36:13 +01:00
filtering_test.cc
treewide: remove timeout config from query options
2021-02-25 17:20:27 +01:00
flat_mutation_reader_test.cc
flat_mutation_reader: return future from next_partition
2021-01-13 17:35:07 +02:00
flush_queue_test.cc
test: everywhere: use seastar::testing::local_random_engine
2021-01-13 11:07:29 +02:00
fragmented_temporary_buffer_test.cc
…
frozen_mutation_test.cc
mutation_fragment: add schema and permit
2020-09-28 11:27:23 +03:00
gossip_test.cc
cdc: introduce cdc::generation_service
2021-02-22 12:45:43 +01:00
gossiping_property_file_snitch_test.cc
storage-service: Subscribe to snitch to update topology
2021-01-13 16:41:34 +03:00
hash_test.cc
…
hashers_test.cc
test: add hashers_test
2021-01-15 18:28:24 +01:00
idl_test.cc
idl: add unit-test for const specifiers feature
2020-12-15 16:03:18 +03:00
index_with_paging_test.cc
treewide: remove timeout config from query options
2021-02-25 17:20:27 +01:00
input_stream_test.cc
test: everywhere: use seastar::testing::local_random_engine
2021-01-13 11:07:29 +02:00
intrusive_array_test.cc
intrusive-array: Array with trusted bounds
2020-07-14 16:29:49 +03:00
json_cql_query_test.cc
…
json_test.cc
test: move json tests from manual/ to boost/
2020-07-06 11:24:12 +03:00
keys_test.cc
keys, compound: switch from bytes_view to managed_bytes_view
2021-01-08 14:16:08 +01:00
large_paging_state_test.cc
treewide: remove timeout config from query options
2021-02-25 17:20:27 +01:00
like_matcher_test.cc
…
limiting_data_source_test.cc
…
linearizing_input_stream_test.cc
…
loading_cache_test.cc
test: everywhere: use seastar::testing::local_random_engine
2021-01-13 11:07:29 +02:00
log_heap_test.cc
…
logalloc_test.cc
test: logalloc_test: harden background reclain test against cpu overcommit
2021-03-15 13:54:49 +02:00
managed_bytes_test.cc
test: add managed_bytes_test
2021-01-15 18:21:13 +01:00
managed_vector_test.cc
…
map_difference_test.cc
…
memtable_test.cc
mutation_fragment: s/as_mutable_clustering_row/mutate_as_clustering_row/
2020-09-28 10:53:56 +03:00
multishard_combining_reader_as_mutation_source_test.cc
multishard_combining_reader: add permit parameter
2020-10-12 15:56:56 +03:00
multishard_mutation_query_test.cc
imr: switch back to open-coded description of structures
2021-02-16 23:43:07 +01:00
murmur_hash_test.cc
…
mutation_fragment_test.cc
keys, compound: switch from bytes_view to managed_bytes_view
2021-01-08 14:16:08 +01:00
mutation_query_test.cc
flat_mutation_reader: impl: add reader_permit parameter
2020-09-28 10:53:48 +03:00
mutation_reader_test.cc
multishard_combining_reader: only read from needed shards
2021-02-26 23:29:20 +02:00
mutation_test.cc
mutation_test: test_mutation_diff_with_random_generator: compact input mutations
2021-03-10 16:28:14 +01:00
mutation_writer_test.cc
mutation_writer: bucket_writer: add close
2021-01-19 19:03:58 +02:00
mvcc_test.cc
partition_version: Change range_tombstones() to return chunked_vector
2020-10-26 11:54:42 +02:00
network_topology_strategy_test.cc
test: everywhere: use seastar::testing::local_random_engine
2021-01-13 11:07:29 +02:00
nonwrapping_range_test.cc
test: check sizes before dereferencing the vector
2020-07-23 16:49:35 +03:00
observable_test.cc
…
partitioner_test.cc
…
querier_cache_test.cc
reader_concurrency_semaphore: separate set_notify_handler from register_inactive_reader
2021-02-08 22:31:01 +02:00
query_processor_test.cc
treewide: remove timeout config from query options
2021-02-25 17:20:27 +01:00
radix_tree_test.cc
test: Add tests for radix tree
2021-02-15 20:27:00 +03:00
raft_sys_table_storage_test.cc
raft: joint consensus, use unordered_set for server_address list
2021-01-29 22:07:07 +03:00
range_assert.hh
…
range_test.cc
…
range_tombstone_list_assertions.hh
…
range_tombstone_list_test.cc
test: Enhance test for range_tombstone_list de-overlapping
2020-12-28 18:26:48 +02:00
restrictions_test.cc
treewide: remove timeout config from query options
2021-02-25 17:20:27 +01:00
reusable_buffer_test.cc
…
role_manager_test.cc
…
row_cache_test.cc
test: Fix exit condition of row_cache_test::test_eviction_from_invalidated
2021-03-09 17:57:52 +01:00
schema_change_test.cc
raft: use null_sharder for raft tables
2021-02-01 18:52:04 +02:00
schema_changes_test.cc
tests: don't pass temporary ranges to readers
2021-01-27 17:38:17 +02:00
schema_registry_test.cc
…
secondary_index_test.cc
treewide: remove timeout config from query options
2021-02-25 17:20:27 +01:00
serialization_test.cc
…
serialized_action_test.cc
test: serialized_action_test: add test_serialized_action_exception
2020-10-14 16:45:21 +03:00
small_vector_test.cc
…
snitch_reset_test.cc
storage-service: Subscribe to snitch to update topology
2021-01-13 16:41:34 +03:00
sstable_3_x_test.cc
imr: switch back to open-coded description of structures
2021-02-16 23:43:07 +01:00
sstable_conforms_to_mutation_source_test.cc
test: sstable_conforms_to_mutation_source_test: remove references to test_sstables_manager
2020-09-23 20:55:12 +03:00
sstable_datafile_test.cc
sstable_set: preparatory work to change sstable_set::all() api
2021-03-10 12:02:12 -03:00
sstable_directory_test.cc
sstables: sstable_writer_config: add origin member
2021-02-01 16:45:52 +02:00
sstable_move_test.cc
sstable: create_links: support for move
2020-11-09 19:57:40 +02:00
sstable_mutation_test.cc
tree-wide: use sstables::make_reader() instead of the read_.*row.*_flat() methods
2021-01-27 17:38:17 +02:00
sstable_resharding_test.cc
test: sstable_resharding_test: prepare for asynchronously closed sstables_manager
2020-09-23 20:55:13 +03:00
sstable_set_test.cc
sstable_set: partitioned_sstable_set: clone: do clone all sstables
2021-03-18 11:15:59 +02:00
sstable_test.cc
sstables: get rid of row.hh
2021-03-11 12:17:13 +02:00
sstable_test.hh
Revert "Merge 'sstables: add versioning to the sstable_set ' from Wojciech Mitros"
2021-03-02 13:21:22 +02:00
stall_free_test.cc
utils: Add merge_to_gently
2020-08-11 10:37:34 +08:00
statement_restrictions_test.cc
cql3: Make get_clustering_bounds() use expressions
2021-03-10 21:25:43 -05:00
storage_proxy_test.cc
token_metdata: futurize update_normal_tokens
2020-12-22 10:35:15 +02:00
suite.yaml
test: enable raft tests
2020-11-03 21:30:11 +03:00
test_table.cc
keys, compound: switch from bytes_view to managed_bytes_view
2021-01-08 14:16:08 +01:00
top_k_test.cc
…
total_order_check.hh
…
transport_test.cc
…
types_test.cc
Validate ascii values when creating from CQL
2020-11-02 16:47:32 +02:00
user_function_test.cc
user_function: throw on_internal_error if executed outside a seastar thread
2021-02-02 13:03:39 +02:00
user_types_test.cc
test: Restore a case in user_types_test
2020-08-16 13:49:55 +03:00
utf8_test.cc
test: utf8: add fragmented buffer validation tests
2020-10-21 11:14:44 +03:00
UUID_test.cc
test: add tests for legacy uuid compare & msb monotonicity
2021-01-21 13:03:59 +03:00
view_build_test.cc
sstables: sstable_writer_config: add origin member
2021-02-01 16:45:52 +02:00
view_complex_test.cc
everywhere: Insert space after switch
2020-08-18 14:31:04 +03:00
view_schema_ckey_test.cc
…
view_schema_pkey_test.cc
…
view_schema_test.cc
tests: mv: Test dropping columns from base table
2020-08-20 14:53:07 +02:00
vint_serialization_test.cc
…
virtual_reader_test.cc
…