mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-27 03:45:11 +00:00
4d7f55a29f
DateTieredCompactionStrategy (DTCS) has been un-recommended for a long time (users should use TimeWindowCompactionStrategy, TWCS, instead). This patch adds a new configuration option - restrict_dtcs - which can be used to restrict the ability to use DTCS in CREATE TABLE or ALTER TABLE statements. This is part of a "safe mode" effort to allow an installation to restrict operations which are un-recommended or dangerous. The new restrict_dtcs option has three values: "true", "false", and "warn": For the time being, "false" is still the default, and means DTCS is not restricted and can still be used freely. We can easily change this default in a followup patch. Setting a value of "true" means that DTCS *is* restricted - trying to create a a table or alter a table with it will fail with an error. Setting a value of "warn" will allow the create or alter operation, but will warn the user - both with a warning message which will immediately appear in cqlsh (for example), and with a log message. Fixes #8914. Signed-off-by: Nadav Har'El <nyh@scylladb.com> Message-Id: <20210624122411.435361-1-nyh@scylladb.com>
98 lines
4.0 KiB
C++
98 lines
4.0 KiB
C++
/*
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
/*
|
|
* Copyright 2015-present ScyllaDB
|
|
*
|
|
* Modified by ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "cql3/statements/schema_altering_statement.hh"
|
|
#include "cql3/statements/cf_prop_defs.hh"
|
|
#include "cql3/cql3_type.hh"
|
|
#include "cql3/column_identifier.hh"
|
|
#include "database_fwd.hh"
|
|
|
|
namespace cql3 {
|
|
|
|
class query_processor;
|
|
|
|
namespace statements {
|
|
|
|
class alter_table_statement : public schema_altering_statement {
|
|
public:
|
|
enum class type {
|
|
add,
|
|
alter,
|
|
drop,
|
|
opts,
|
|
rename,
|
|
};
|
|
using renames_type = std::vector<std::pair<shared_ptr<column_identifier::raw>,
|
|
shared_ptr<column_identifier::raw>>>;
|
|
struct column_change {
|
|
shared_ptr<column_identifier::raw> name;
|
|
shared_ptr<cql3_type::raw> validator = nullptr;
|
|
bool is_static = false;
|
|
};
|
|
private:
|
|
const type _type;
|
|
const std::vector<column_change> _column_changes;
|
|
const std::optional<cf_prop_defs> _properties;
|
|
const renames_type _renames;
|
|
public:
|
|
alter_table_statement(cf_name name,
|
|
type t,
|
|
std::vector<column_change> column_changes,
|
|
std::optional<cf_prop_defs> properties,
|
|
renames_type renames);
|
|
|
|
virtual future<> check_access(service::storage_proxy& proxy, const service::client_state& state) const override;
|
|
virtual void validate(service::storage_proxy& proxy, const service::client_state& state) const override;
|
|
virtual future<shared_ptr<cql_transport::event::schema_change>> announce_migration(query_processor& qp) const override;
|
|
virtual std::unique_ptr<prepared_statement> prepare(database& db, cql_stats& stats) override;
|
|
virtual future<::shared_ptr<messages::result_message>> execute(query_processor& qp, service::query_state& state, const query_options& options) const override;
|
|
private:
|
|
void add_column(const schema& schema, const table& cf, schema_builder& cfm, std::vector<view_ptr>& view_updates, const column_identifier& column_name, const cql3_type validator, const column_definition* def, bool is_static) const;
|
|
void alter_column(const schema& schema, const table& cf, schema_builder& cfm, std::vector<view_ptr>& view_updates, const column_identifier& column_name, const cql3_type validator, const column_definition* def, bool is_static) const;
|
|
void drop_column(const schema& schema, const table& cf, schema_builder& cfm, std::vector<view_ptr>& view_updates, const column_identifier& column_name, const cql3_type validator, const column_definition* def, bool is_static) const;
|
|
};
|
|
|
|
}
|
|
|
|
}
|