mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
4eecb57a0b0e615213a3de1a77ecbfb4e802e799
scylladb/utils
History
Avi Kivity 03531c2443 fragmented_temporary_buffer: fix read_exactly() during premature end-of-stream 
read_exactly(), when given a stream that does not contain the amount of data
requested, will loop endlessly, allocating more and more memory as it does, until
it fails with an exception (at which point it will release the memory).

Fix by returning an empty result, like input_stream::read_exactly() (which it
replaces). Add a test case that fails without a fix.

Affected callers are the native transport, commitlog replay, and internal
deserialization.

Fixes #4233.

Branches: master, branch-3.0
Tests: unit(dev)
Message-Id: <20190216150825.14841-1-avi@scylladb.com>
2019-02-16 17:06:19 +00:00
..
arch/powerpc/crc32-vpmsum
utils: crc32: mark power crc32 assembly as not requiring an executable stack
2018-10-02 18:48:23 +01:00
gz
utils/gz: optimize crc_combine for arm64
2018-12-10 10:31:08 +02:00
allocation_strategy.hh
lsa: provide migrator with the object size
2018-05-09 16:52:26 +01:00
anchorless_list.hh
mvcc: Introduce partition_version_list
2018-05-30 12:18:56 +02:00
ascii.cc
utils: add fast ascii string validation
2018-12-24 09:58:08 +02:00
ascii.hh
utils: add fast ascii string validation
2018-12-24 09:58:08 +02:00
big_decimal.cc
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
big_decimal.hh
utils/big_decimal: Added necessary operators and methods for aggregate functions.
2017-11-12 15:51:29 +01:00
bloom_calculations.cc
…
bloom_calculations.hh
utils: convert sprint() to format()
2018-11-01 13:16:17 +00:00
bloom_filter.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
bloom_filter.hh
utils: Use dedicated enum for Bloom filter format instead of a boolean.
2018-05-10 09:47:41 +03:00
bounded_stats_deque.hh
…
buffer_input_stream.cc
buffer_input_stream: make it possible to specify chunk size
2018-04-16 21:11:13 +02:00
buffer_input_stream.hh
buffer_input_stream: make it possible to specify chunk size
2018-04-16 21:11:13 +02:00
chunked_vector.hh
utils: chunked_vector: Do not require T to be default-constructible for clear()
2018-07-11 16:55:20 +02:00
class_registrator.hh
class_registry: introduce a non-static variant of class_registry
2018-11-26 13:30:21 +00:00
clmul.hh
utils: Extract clmul() from crc.hh
2018-12-03 14:36:08 +01:00
config_file_impl.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
config_file.cc
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
config_file.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
coroutine.hh
Introduce a coroutine wrapper
2018-05-30 14:41:40 +02:00
crc.hh
utils: Extract clmul() from crc.hh
2018-12-03 14:36:08 +01:00
data_input.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
date.h
date: use correct casts for years
2017-04-17 23:03:15 +03:00
div_ceil.hh
utils: introduce div_ceil()
2017-05-17 12:30:03 +03:00
dynamic_bitset.cc
dynamic_bitset: optimize for large sets
2018-04-07 14:52:58 +03:00
dynamic_bitset.hh
dynamic_bitset: optimize for large sets
2018-04-07 14:52:58 +03:00
estimated_histogram.hh
Update seastar submodule
2018-11-21 00:01:44 +02:00
exceptions.cc
…
exceptions.hh
…
exponential_backoff_retry.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
extremum_tracking.hh
utils/extremum_tracking: drop default constructor
2019-02-07 18:31:25 +02:00
fb_utilities.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
file_lock.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
file_lock.hh
Update seastar submodule
2018-11-21 00:01:44 +02:00
flush_queue.hh
utils: convert sprint() to format()
2018-11-01 13:16:17 +00:00
fragment_range.hh
util fragment_range: add general linearisation functions
2018-07-18 12:28:06 +01:00
fragmented_temporary_buffer.hh
fragmented_temporary_buffer: fix read_exactly() during premature end-of-stream
2019-02-16 17:06:19 +00:00
hash.hh
Update seastar submodule
2018-11-21 00:01:44 +02:00
histogram.hh
Update seastar submodule
2018-11-21 00:01:44 +02:00
i_filter.cc
utils: convert sprint() to format()
2018-11-01 13:16:17 +00:00
i_filter.hh
utils: Use dedicated enum for Bloom filter format instead of a boolean.
2018-05-10 09:47:41 +03:00
in.hh
utils::in: Add helper type for perfect forwarding initializer lists
2017-12-05 14:28:34 +00:00
input_stream.hh
…
int_range.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
joinpoint.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
large_bitset.cc
large_bitset: use a chunked_vector internally and simplify API
2018-04-10 10:25:06 +03:00
large_bitset.hh
large_bitset: be more accurate with memory usage
2018-05-15 11:22:21 -04:00
latency.hh
…
limiting_data_source.cc
Introduce make_limiting_data_source
2018-04-16 20:56:30 +02:00
limiting_data_source.hh
Introduce make_limiting_data_source
2018-04-16 20:56:30 +02:00
loading_cache.hh
loading_cache: make iterator work on top of lru_list iterators instead of loading_shared_values'
2018-08-30 20:56:44 -04:00
loading_shared_values.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
log_heap.hh
log_histogram: rename to log_heap
2017-09-18 12:44:05 +02:00
logalloc.cc
lsa: Avoid unnecessary compact_and_evict_locked()
2019-01-21 20:19:20 +02:00
logalloc.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
managed_bytes.cc
linearization_context: remove non-trivial operations from fast path
2018-01-30 18:33:25 +01:00
managed_bytes.hh
managed_bytes: Fix compilation on gcc 8.2
2019-01-18 13:48:05 +00:00
managed_ref.hh
…
managed_vector.hh
managed_vector: Make external_memory_usage() ignore reserved space
2018-09-03 17:09:54 +03:00
memory_data_sink.hh
utils: Introduce memory_data_sink
2018-11-21 14:04:27 +01:00
meta.hh
utils: add metaprogramming helper functions
2018-05-31 10:09:01 +01:00
murmur_hash.cc
…
murmur_hash.hh
…
mutable_view.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
observable.hh
observable: allow an observable to disconnect() twice without penalty
2018-07-11 10:15:01 +01:00
overloaded_functor.hh
utils: Add overloaded_functor helper.
2018-07-20 13:50:17 -07:00
phased_barrier.hh
utils: phased_barrier: Make advance_and_await() have strong exception guarantees
2018-11-20 16:15:12 +00:00
preempt.hh
mutation_partition: Make merging preemtable
2018-06-27 12:48:30 +02:00
rate_limiter.cc
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
rate_limiter.hh
Update seastar submodule
2018-11-21 00:01:44 +02:00
reusable_buffer.hh
utils/reusable_buffer: do not warn about large allocations
2018-09-30 11:12:23 +03:00
runtime.cc
…
runtime.hh
…
sequenced_set.hh
sequenced_set: Add "insert" method, following std::set semantics
2018-12-12 09:32:05 +00:00
serialization.hh
Update seastar submodule
2018-11-21 00:01:44 +02:00
serialized_action.hh
utils/serialized_action: Introduce trigger_later()
2017-10-18 08:49:52 +02:00
small_vector.hh
utils/small_vector: fix leak in copy assignment slow path
2019-01-18 17:49:46 +02:00
streaming_histogram.hh
streaming_histogram: fix coding style
2017-06-29 02:08:12 -03:00
top_k.hh
Merge "nodetool toppartitions" from Rafi & Avi
2018-12-28 16:31:24 +01:00
utf8.cc
utils: optimize UTF-8 validation
2018-12-05 21:51:01 +02:00
utf8.hh
utils: optimize UTF-8 validation
2018-12-05 21:51:01 +02:00
UUID_gen.cc
…
UUID_gen.hh
…
uuid.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
UUID.hh
Update seastar submodule
2018-11-21 00:01:44 +02:00
with_relational_operators.hh
tombstone: Extract out relational operators
2017-04-25 11:43:04 +02:00