mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-26 19:35:12 +00:00
969cbb75ce
as we have an API for backup a keyspace, let's expose this feature
with nodetool. so we can exercise it without the help of scylla-manager
or 3rd-party tools with a user-friendly interface.
in this change:
* add a new subcommand named "backup" to nodetool
* add test to verify its interaction with the API server
* add two more route to the REST API mock server, as
the test is using /task_manager/wait_task/{task_id} API.
for the sake of completeness, the route for
/task_manager/{part1} is added as well.
* update the document accordingly.
* the bash completion script is updated accordingly.
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
90 lines
2.6 KiB
Python
90 lines
2.6 KiB
Python
#
|
|
# Copyright 2023-present ScyllaDB
|
|
#
|
|
# SPDX-License-Identifier: AGPL-3.0-or-later
|
|
#
|
|
|
|
import pytest
|
|
|
|
from test.nodetool.rest_api_mock import expected_request
|
|
|
|
|
|
def test_disablebackup(nodetool):
|
|
nodetool("disablebackup", expected_requests=[
|
|
expected_request("POST", "/storage_service/incremental_backups", params={"value": "false"})])
|
|
|
|
|
|
def test_enablebackup(nodetool):
|
|
nodetool("enablebackup", expected_requests=[
|
|
expected_request("POST", "/storage_service/incremental_backups", params={"value": "true"})])
|
|
|
|
|
|
def test_statusbackup(nodetool):
|
|
res = nodetool("statusbackup", expected_requests=[
|
|
expected_request("GET", "/storage_service/incremental_backups", response=False)])
|
|
assert res.stdout == "not running\n"
|
|
|
|
res = nodetool("statusbackup", expected_requests=[
|
|
expected_request("GET", "/storage_service/incremental_backups", response=True)])
|
|
assert res.stdout == "running\n"
|
|
|
|
|
|
@pytest.mark.parametrize("nowait", [False, True])
|
|
def test_backup(nodetool, scylla_only, nowait):
|
|
endpoint = "s3.us-east-2.amazonaws.com"
|
|
bucket = "bucket-foo"
|
|
keyspace = "ks"
|
|
snapshot = "ss"
|
|
params = {"endpoint": endpoint,
|
|
"bucket": bucket,
|
|
"keyspace": keyspace,
|
|
"snapshot": snapshot}
|
|
task_id = "2c4a3e5f"
|
|
start_time = "2024-08-08T14:29:25Z"
|
|
end_time = "2024-08-08T14:30:42Z"
|
|
state = "done"
|
|
task_status = {
|
|
"id": task_id,
|
|
"type": "backup",
|
|
"kind": "node",
|
|
"scope": "node",
|
|
"state": state,
|
|
"is_abortable": False,
|
|
"start_time": start_time,
|
|
"end_time": end_time,
|
|
"error": "",
|
|
"sequence_number": 0,
|
|
"shard": 0,
|
|
"progress_total": 1.0,
|
|
"progress_completed": 1.0,
|
|
"children_ids": []
|
|
}
|
|
expected_requests = [
|
|
expected_request(
|
|
"POST",
|
|
"/storage_service/backup",
|
|
params,
|
|
response=task_id)
|
|
]
|
|
args = ["backup",
|
|
"--endpoint", endpoint,
|
|
"--bucket", bucket,
|
|
"--keyspace", keyspace,
|
|
"--snapshot", snapshot]
|
|
if nowait:
|
|
args.append("--nowait")
|
|
expected_output = ""
|
|
else:
|
|
# wait for the completion of backup task
|
|
expected_requests.append(
|
|
expected_request(
|
|
"GET",
|
|
f"/task_manager/wait_task/{task_id}",
|
|
response=task_status))
|
|
expected_output = f"""{state}
|
|
start: {start_time}
|
|
end: {end_time}
|
|
"""
|
|
res = nodetool(*args, expected_requests=expected_requests)
|
|
assert res.stdout == expected_output
|