The partition builder doesn't expect the looked-up row to exist. In fact it already existing is a sign of a bug. Currently bugs resulting in duplicate rows will manifest by tripping an assert in `row::append_cell()`. This however results in poor diagnostics, so we want to catch these errors sooner to be able to provide higher level diagnostics. To this end, switch to the freshly introduced `append_clustering_row()` so that duplicate rows are found early and in a context where their identity is known.
86 lines
3.1 KiB
C++
86 lines
3.1 KiB
C++
/*
|
|
* Copyright (C) 2015 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "mutation_partition.hh"
|
|
#include "mutation_partition_view.hh"
|
|
|
|
// Partition visitor which builds mutation_partition corresponding to the data its fed with.
|
|
class partition_builder final : public mutation_partition_visitor {
|
|
private:
|
|
const schema& _schema;
|
|
mutation_partition& _partition;
|
|
deletable_row* _current_row;
|
|
public:
|
|
// @p will hold the result of building.
|
|
// @p must be empty.
|
|
partition_builder(const schema& s, mutation_partition& p)
|
|
: _schema(s)
|
|
, _partition(p)
|
|
{ }
|
|
|
|
virtual void accept_partition_tombstone(tombstone t) override {
|
|
_partition.apply(t);
|
|
}
|
|
|
|
virtual void accept_static_cell(column_id id, atomic_cell_view cell) override {
|
|
auto& cdef = _schema.static_column_at(id);
|
|
accept_static_cell(id, atomic_cell(*cdef.type, cell));
|
|
}
|
|
|
|
void accept_static_cell(column_id id, atomic_cell&& cell) {
|
|
row& r = _partition.static_row().maybe_create();
|
|
r.append_cell(id, atomic_cell_or_collection(std::move(cell)));
|
|
}
|
|
|
|
virtual void accept_static_cell(column_id id, collection_mutation_view collection) override {
|
|
row& r = _partition.static_row().maybe_create();
|
|
r.append_cell(id, collection_mutation(*_schema.static_column_at(id).type, std::move(collection)));
|
|
}
|
|
|
|
virtual void accept_row_tombstone(const range_tombstone& rt) override {
|
|
_partition.apply_row_tombstone(_schema, rt);
|
|
}
|
|
|
|
virtual void accept_row(position_in_partition_view key, const row_tombstone& deleted_at, const row_marker& rm, is_dummy dummy, is_continuous continuous) override {
|
|
deletable_row& r = _partition.append_clustered_row(_schema, key, dummy, continuous);
|
|
r.apply(rm);
|
|
r.apply(deleted_at);
|
|
_current_row = &r;
|
|
}
|
|
|
|
virtual void accept_row_cell(column_id id, atomic_cell_view cell) override {
|
|
auto& cdef = _schema.regular_column_at(id);
|
|
accept_row_cell(id, atomic_cell(*cdef.type, cell));
|
|
}
|
|
|
|
void accept_row_cell(column_id id, atomic_cell&& cell) {
|
|
row& r = _current_row->cells();
|
|
r.append_cell(id, std::move(cell));
|
|
}
|
|
|
|
virtual void accept_row_cell(column_id id, collection_mutation_view collection) override {
|
|
row& r = _current_row->cells();
|
|
r.append_cell(id, collection_mutation(*_schema.regular_column_at(id).type, std::move(collection)));
|
|
}
|
|
};
|