These alterations cannot break the database irreparably, so allow them. Expand command_desc as required. Add a type (rather than command_desc) parameter to has_column_family_access() to minimize code changes. Fixes #7057 Signed-off-by: Dejan Mircevski <dejan@scylladb.com>
219 lines
8.3 KiB
C++
219 lines
8.3 KiB
C++
/*
|
|
* Copyright (C) 2016 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
|
|
#include <boost/range/irange.hpp>
|
|
#include <boost/range/adaptors.hpp>
|
|
#include <boost/range/algorithm.hpp>
|
|
#include <boost/test/unit_test.hpp>
|
|
#include <stdint.h>
|
|
|
|
#include <seastar/core/future-util.hh>
|
|
#include <seastar/core/shared_ptr.hh>
|
|
#include <seastar/core/thread.hh>
|
|
|
|
#include <seastar/testing/test_case.hh>
|
|
#include "test/lib/cql_test_env.hh"
|
|
#include "test/lib/cql_assertions.hh"
|
|
#include "test/lib/exception_utils.hh"
|
|
|
|
#include "auth/allow_all_authenticator.hh"
|
|
#include "auth/authenticator.hh"
|
|
#include "auth/password_authenticator.hh"
|
|
#include "auth/service.hh"
|
|
#include "auth/authenticated_user.hh"
|
|
#include "auth/resource.hh"
|
|
|
|
#include "db/config.hh"
|
|
#include "cql3/query_processor.hh"
|
|
|
|
SEASTAR_TEST_CASE(test_default_authenticator) {
|
|
return do_with_cql_env([](cql_test_env& env) {
|
|
auto& a = env.local_auth_service().underlying_authenticator();
|
|
BOOST_REQUIRE(!a.require_authentication());
|
|
BOOST_REQUIRE_EQUAL(a.qualified_java_name(), auth::allow_all_authenticator_name);
|
|
return make_ready_future();
|
|
});
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_password_authenticator_attributes) {
|
|
auto cfg = make_shared<db::config>();
|
|
cfg->authenticator(sstring(auth::password_authenticator_name));
|
|
|
|
return do_with_cql_env([](cql_test_env& env) {
|
|
auto& a = env.local_auth_service().underlying_authenticator();
|
|
BOOST_REQUIRE(a.require_authentication());
|
|
BOOST_REQUIRE_EQUAL(a.qualified_java_name(), auth::password_authenticator_name);
|
|
return make_ready_future();
|
|
}, cfg);
|
|
}
|
|
|
|
static future<auth::authenticated_user>
|
|
authenticate(cql_test_env& env, std::string_view username, std::string_view password) {
|
|
auto& c = env.local_client_state();
|
|
auto& a = env.local_auth_service().underlying_authenticator();
|
|
|
|
return do_with(
|
|
auth::authenticator::credentials_map{
|
|
{auth::authenticator::USERNAME_KEY, sstring(username)},
|
|
{auth::authenticator::PASSWORD_KEY, sstring(password)}},
|
|
[&a, &c, username](const auto& credentials) {
|
|
return a.authenticate(credentials).then([&c, username](auth::authenticated_user u) {
|
|
c.set_login(std::move(u));
|
|
return c.check_user_can_login().then([&c] { return *c.user(); });
|
|
});
|
|
});
|
|
}
|
|
|
|
template <typename Exception, typename... Args>
|
|
future<> require_throws(seastar::future<Args...> fut) {
|
|
return fut.then_wrapped([](auto completed_fut) {
|
|
try {
|
|
completed_fut.get();
|
|
BOOST_FAIL("Required an exception to be thrown");
|
|
} catch (const Exception&) {
|
|
// Ok.
|
|
}
|
|
});
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_password_authenticator_operations) {
|
|
auto cfg = make_shared<db::config>();
|
|
cfg->authenticator(sstring(auth::password_authenticator_name));
|
|
|
|
/**
|
|
* Not using seastar::async due to apparent ASan bug.
|
|
* Enjoy the slightly less readable code.
|
|
*/
|
|
return do_with_cql_env([](cql_test_env& env) {
|
|
static const sstring username("fisk");
|
|
static const sstring password("notter");
|
|
|
|
// check non-existing user
|
|
return require_throws<exceptions::authentication_exception>(
|
|
authenticate(env, username, password)).then([&env] {
|
|
return do_with(auth::role_config{}, auth::authentication_options{}, [&env](auto& config, auto& options) {
|
|
config.can_login = true;
|
|
options.password = password;
|
|
|
|
return auth::create_role(env.local_auth_service(), username, config, options).then([&env] {
|
|
return authenticate(env, username, password).then([](auth::authenticated_user user) {
|
|
BOOST_REQUIRE(!auth::is_anonymous(user));
|
|
BOOST_REQUIRE_EQUAL(*user.name, username);
|
|
});
|
|
});
|
|
});
|
|
}).then([&env] {
|
|
return require_throws<exceptions::authentication_exception>(authenticate(env, username, "hejkotte"));
|
|
}).then([&env] {
|
|
//
|
|
// A role must be explicitly marked as being allowed to log in.
|
|
//
|
|
|
|
return do_with(
|
|
auth::role_config_update{},
|
|
auth::authentication_options{},
|
|
[&env](auto& config_update, const auto& options) {
|
|
config_update.can_login = false;
|
|
|
|
return auth::alter_role(env.local_auth_service(), username, config_update, options).then([&env] {
|
|
return require_throws<exceptions::authentication_exception>(authenticate(env, username, password));
|
|
});
|
|
});
|
|
}).then([&env] {
|
|
// sasl
|
|
auto& a = env.local_auth_service().underlying_authenticator();
|
|
auto sasl = a.new_sasl_challenge();
|
|
|
|
BOOST_REQUIRE(!sasl->is_complete());
|
|
|
|
bytes b;
|
|
int8_t i = 0;
|
|
b.append(&i, 1);
|
|
b.insert(b.end(), username.begin(), username.end());
|
|
b.append(&i, 1);
|
|
b.insert(b.end(), password.begin(), password.end());
|
|
|
|
sasl->evaluate_response(b);
|
|
BOOST_REQUIRE(sasl->is_complete());
|
|
|
|
return sasl->get_authenticated_user().then([](auth::authenticated_user user) {
|
|
BOOST_REQUIRE(!auth::is_anonymous(user));
|
|
BOOST_REQUIRE_EQUAL(*user.name, username);
|
|
});
|
|
}).then([&env] {
|
|
// check deleted user
|
|
return auth::drop_role(env.local_auth_service(), username).then([&env] {
|
|
return require_throws<exceptions::authentication_exception>(authenticate(env, username, password));
|
|
});
|
|
});
|
|
}, cfg);
|
|
}
|
|
|
|
namespace {
|
|
|
|
/// Asserts that table is protected from alterations that can brick a node.
|
|
void require_table_protected(cql_test_env& env, const char* table) {
|
|
using exception_predicate::message_contains;
|
|
using unauth = exceptions::unauthorized_exception;
|
|
const auto q = [&] (const char* stmt) { return env.execute_cql(fmt::format(stmt, table)).get(); };
|
|
BOOST_TEST_INFO(table);
|
|
BOOST_REQUIRE_EXCEPTION(q("ALTER TABLE {} ALTER role TYPE blob"), unauth, message_contains("is protected"));
|
|
BOOST_REQUIRE_EXCEPTION(q("ALTER TABLE {} RENAME role TO user"), unauth, message_contains("is protected"));
|
|
BOOST_REQUIRE_EXCEPTION(q("ALTER TABLE {} DROP role"), unauth, message_contains("is protected"));
|
|
BOOST_REQUIRE_EXCEPTION(q("DROP TABLE {}"), unauth, message_contains("is protected"));
|
|
}
|
|
|
|
cql_test_config auth_on() {
|
|
cql_test_config cfg;
|
|
cfg.db_config->authorizer("CassandraAuthorizer");
|
|
cfg.db_config->authenticator("PasswordAuthenticator");
|
|
return cfg;
|
|
}
|
|
|
|
} // anonymous namespace
|
|
|
|
SEASTAR_TEST_CASE(roles_table_is_protected) {
|
|
return do_with_cql_env_thread([] (cql_test_env& env) {
|
|
require_table_protected(env, "system_auth.roles");
|
|
}, auth_on());
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(role_members_table_is_protected) {
|
|
return do_with_cql_env_thread([] (cql_test_env& env) {
|
|
require_table_protected(env, "system_auth.role_members");
|
|
}, auth_on());
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(role_permissions_table_is_protected) {
|
|
return do_with_cql_env_thread([] (cql_test_env& env) {
|
|
require_table_protected(env, "system_auth.role_permissions");
|
|
}, auth_on());
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(alter_opts_on_system_auth_tables) {
|
|
return do_with_cql_env_thread([] (cql_test_env& env) {
|
|
cquery_nofail(env, "ALTER TABLE system_auth.roles WITH speculative_retry = 'NONE'");
|
|
cquery_nofail(env, "ALTER TABLE system_auth.role_members WITH gc_grace_seconds = 123");
|
|
cquery_nofail(env, "ALTER TABLE system_auth.role_permissions WITH min_index_interval = 456");
|
|
}, auth_on());
|
|
}
|