2b0c317dec
fmt, the formatting library we use, detects types with conversion to std::string_view (and formats them as strings) and types that support operator<<(std::ostream, const T&) (and performs custom formatting on them). However, if <fmt/ostream.h>, the latter is not done. The problem happens with seastar::sstring, which implements both, and debug mode, which disables inlining. Some translation units do include <fmt/ostream.h>, and so generate code to do custom formatting. exception_utils.cc doesn't, and so generates code to format via string_view conversion. At link time, the compiler picks one of the generated functions and includes it in the final binary; it happened to pick one generated outside exception_utils.cc, using custom formatting. However, there is also code in fmt to encode which path fmt chose - string_view or custom. This code is constexpr and so is evaluated in exception_utils.cc. The result is that the function to perform formatting of seastar::sstring uses custom formatting, while the descriptor containing the method used says it is formatting via string_view. This is enough to cause a crash. The problem is limited to debug mode, since in other modes all this code is inlined, and so is consistent within the translation unit. We need a more general fix (hopefully in fmt), but for now a simple fix is to add the missing include. Ref https://github.com/fmtlib/fmt/issues/1662
57 lines
2.2 KiB
C++
57 lines
2.2 KiB
C++
/*
|
|
* Copyright (C) 2019 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "test/lib/exception_utils.hh"
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
#include <fmt/format.h>
|
|
#include <fmt/ostream.h>
|
|
|
|
std::function<bool(const std::exception&)> exception_predicate::make(
|
|
std::function<bool(const std::exception&)> check,
|
|
std::function<sstring(const std::exception&)> err) {
|
|
return [check = std::move(check), err = std::move(err)] (const std::exception& e) {
|
|
const bool status = check(e);
|
|
BOOST_CHECK_MESSAGE(status, err(e));
|
|
return status;
|
|
};
|
|
}
|
|
|
|
std::function<bool(const std::exception&)> exception_predicate::message_contains(
|
|
const sstring& fragment,
|
|
const std::experimental::source_location& loc) {
|
|
return make([=] (const std::exception& e) { return sstring(e.what()).find(fragment) != sstring::npos; },
|
|
[=] (const std::exception& e) {
|
|
return fmt::format("Message '{}' doesn't contain '{}'\n{}:{}: invoked here",
|
|
e.what(), fragment, loc.file_name(), loc.line());
|
|
});
|
|
}
|
|
|
|
std::function<bool(const std::exception&)> exception_predicate::message_equals(
|
|
const sstring& text,
|
|
const std::experimental::source_location& loc) {
|
|
return make([=] (const std::exception& e) { return text == e.what(); },
|
|
[=] (const std::exception& e) {
|
|
return fmt::format("Message '{}' doesn't equal '{}'\n{}:{}: invoked here",
|
|
e.what(), text, loc.file_name(), loc.line());
|
|
});
|
|
}
|