mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-23 10:00:35 +00:00
542b2ed0de
The class was introduced to facilitate path and query parameters parsing from requests, but in fact it's mostly dead code. First, the class introduces the concept of "mandatory" parameters which are seastar path params. If missing, the parameter validation throws, but in all cases where this option is used in scylla it's impossible to get empty path param -- if the parameter is missing seastar returns 404 (not found) before calling handler. Second, the req_params::get<T>() doesn't work for anything but string argument (or types such that optional<T> can be implicitly casted to optional<sstring>). And it's in fact only used to get sstrings, so it compiles and works so far. The remaining ability to parse bool from string is partially duplicated by the validate_bool() method. Using plain method to parse string to bool is less code than req_params introduce. One (arguably) useful thing req_params do it validate the incoming request _not_ to contain unknown query parameters. However, quite a few endpoints use this, most of them just cherry-pick parameters they want and ignore the others. There's already a comprehensive description of accepted parameters for each endpoint in api-doc/ and req_params duplicate it. Good validation code should rely on api-doc/, not on its partial copy. Having said that, this PR introduces validate_bool_x() helper to do req_params-like parsing of strings to bools, patches existing handlers to use existing parameters parsing facilities (such as validate_keyspace() and parse_table_infos()) and drops the req_params. Closes scylladb/scylladb#24159 * github.com:scylladb/scylladb: api: Drop class req_params api: Stop using req_params in parse_scrub_options api: Stop using req_params in tasks::force_keyspace_compaction_async api: Stop using req_params in ss::force_keyspace_compaction api: Stop using req_params in ss::force_compaction api: Stop using req_params in cf::force_major_compaction api: Add validate_bool_x() helper