Botond Dénes 0438febdc9 Merge 'alternator: fix REST API access to an Alternator LSI' from Nadav Har'El ...

The name of the Scylla table backing an Alternator LSI looks like `basename:!lsiname`. Some REST API clients (including Scylla Manager) when they send a "!" character in the REST API request path may decide to "URL encode" it - convert it to `%21`.

Because of a Seastar bug (https://github.com/scylladb/seastar/issues/725) Scylla's REST API server forgets to do the URL decoding on the path part of the request, which leads to the REST API request failing to address the LSI table.

The first patch in this PR fixes the bug by using a new Seastar API introduced in https://github.com/scylladb/seastar/pull/2125 that does the URL decoding as appropriate. The second patch in the PR is a new test for this bug, which fails without the fix, and passes afterwards.

Fixes #5883.

Closes scylladb/scylladb#18286

* github.com:scylladb/scylladb:
  test/alternator: test addressing LSI using REST API
  REST API: stop using deprecated, buggy, path parameter

2024-05-09 08:26:43 +03:00

..

api-doc

api: Add method to delete replica from tablet

2024-04-15 16:31:07 +03:00

api_init.hh

api: Rename (un)set_server_load_sstable -> (un)set_server_column_family

2024-03-26 12:16:08 +02:00

api.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

api.hh

Merge 'api/api.hh: improve usage of standard containers' from Patryk Wróbel

2024-01-25 13:22:48 +02:00

authorization_cache.cc

api: do not include unused headers

2024-01-25 11:28:02 +03:00

authorization_cache.hh

api: reference httpd::* symbols like 'httpd::*'

2023-03-21 15:49:10 +02:00

cache_service.cc

api: Fix stats reported for row cache

2024-03-12 13:44:59 +02:00

cache_service.hh

api: reference httpd::* symbols like 'httpd::*'

2023-03-21 15:49:10 +02:00

CMakeLists.txt

build: bring abseil submodule back

2024-05-05 23:31:09 +03:00

collectd.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

collectd.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

column_family.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

column_family.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

commitlog.cc

api: Qualify callback commitlog* argument with const

2024-04-16 07:02:31 +03:00

commitlog.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

compaction_manager.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

compaction_manager.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

config.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

config.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

endpoint_snitch.cc

api: do not include unused headers

2024-01-25 11:28:02 +03:00

endpoint_snitch.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

error_injection.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

error_injection.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

failure_detector.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

failure_detector.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

gossiper.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

gossiper.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

hinted_handoff.cc

api: do not include unused headers

2024-01-25 11:28:02 +03:00

hinted_handoff.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

lsa.cc

api/lsa: Don't use database to perform invoke-on-all

2024-04-16 07:12:40 +03:00

lsa.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

messaging_service.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

messaging_service.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

raft.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

raft.hh

api: add HTTP endpoint to trigger Raft snapshots

2024-01-23 16:48:28 +01:00

scrub_status.hh

api: extract scrub_status into its own header

2023-12-12 09:33:39 -05:00

storage_proxy.cc

api: do not include unused headers

2024-01-25 11:28:02 +03:00

storage_proxy.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

storage_service.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

storage_service.hh

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

stream_manager.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

stream_manager.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

system.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

system.hh

api: reference httpd::* symbols like 'httpd::*'

2023-03-21 15:49:10 +02:00

task_manager_test.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

task_manager_test.hh

api: Unset task_manager test API handlers

2023-10-18 18:56:24 +03:00

task_manager.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

task_manager.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00

tasks.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

tasks.hh

api: tasks: api for starting async compaction

2023-12-11 11:39:33 +01:00

token_metadata.cc

REST API: stop using deprecated, buggy, path parameter

2024-05-02 12:33:46 +03:00

token_metadata.hh

api: do not include unused headers

2024-01-25 11:28:02 +03:00