mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-20 16:40:35 +00:00
0ca7253315
SNI works only with DNS hostnames. Adding an IP address causes warnings
on the server side.
This change adds SNI only if it is not an IP address.
This change has no unit tests, as this behavior is not critical,
since it causes a warning on the server side.
The critical part, that the server name is verified, is already covered.
This PR also adds warning logs to improve future troubleshooting of connections to the vector-store nodes.
Fixes: VECTOR-528
Backports to 2025.04 and 2026.01 are required, as these branches are also affected.
Closes scylladb/scylladb#28637
* github.com:scylladb/scylladb:
vector_search: fix TLS server name with IP
vector_search: add warn log for failed ann requests
(cherry picked from commit 23ed0d4df8)
Closes scylladb/scylladb#28964
78 lines
2.4 KiB
C++
78 lines
2.4 KiB
C++
/*
|
|
* Copyright (C) 2025-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "error.hh"
|
|
#include "utils/log.hh"
|
|
#include "utils/updateable_value.hh"
|
|
#include <chrono>
|
|
#include <exception>
|
|
#include <seastar/core/future.hh>
|
|
#include <seastar/core/sstring.hh>
|
|
#include <seastar/core/abort_source.hh>
|
|
#include <seastar/http/client.hh>
|
|
#include <seastar/http/common.hh>
|
|
#include <seastar/net/tls.hh>
|
|
#include <optional>
|
|
#include <expected>
|
|
#include <variant>
|
|
|
|
namespace vector_search {
|
|
|
|
class client {
|
|
public:
|
|
struct response {
|
|
seastar::http::reply::status_type status;
|
|
std::vector<seastar::temporary_buffer<char>> content;
|
|
};
|
|
|
|
struct endpoint_type {
|
|
seastar::sstring host;
|
|
std::uint16_t port;
|
|
seastar::net::inet_address ip;
|
|
};
|
|
|
|
using request_error = std::variant<aborted_error, service_unavailable_error>;
|
|
using request_result = std::expected<response, request_error>;
|
|
|
|
explicit client(logging::logger& logger, endpoint_type endpoint_, utils::updateable_value<uint32_t> request_timeout_in_ms,
|
|
::shared_ptr<seastar::tls::certificate_credentials> credentials);
|
|
|
|
seastar::future<request_result> request(
|
|
seastar::httpd::operation_type method, seastar::sstring path, std::optional<seastar::sstring> content, seastar::abort_source& as);
|
|
|
|
seastar::future<> close();
|
|
|
|
const endpoint_type& endpoint() const {
|
|
return _endpoint;
|
|
}
|
|
|
|
bool is_up() const {
|
|
return !is_checking_status_in_progress();
|
|
}
|
|
|
|
private:
|
|
seastar::future<response> request_impl(seastar::httpd::operation_type method, seastar::sstring path, std::optional<seastar::sstring> content,
|
|
std::optional<seastar::http::reply::status_type>&& expected, seastar::abort_source& as);
|
|
seastar::future<bool> check_status();
|
|
void handle_server_unavailable(std::exception_ptr err);
|
|
seastar::future<> run_checking_status();
|
|
bool is_checking_status_in_progress() const;
|
|
std::chrono::milliseconds backoff_retry_max() const;
|
|
|
|
endpoint_type _endpoint;
|
|
seastar::http::experimental::client _http_client;
|
|
seastar::future<> _checking_status_future = seastar::make_ready_future();
|
|
seastar::abort_source _as;
|
|
logging::logger& _logger;
|
|
utils::updateable_value<uint32_t> _request_timeout;
|
|
};
|
|
|
|
} // namespace vector_search
|