mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-28 20:27:03 +00:00
3942546d41
rpc currently allows serializers and deserializers to defer, because the input and output stream may not be ready. They may not, however, defer on behalf of the object being serialized or deserialized (i.e. you cannot serialize to disk or deserialize from disk) because that causes the tcp connection to block until serialization/deserialization is complete. So in practice messages must be small enough to fit in memory, and there is nothing gained by the complexity. To simplify things, switch to non-deferring serialization. Add a frame header to messages that specifies the buffer size, which allows rpc to use a read_exacly() to consume the message, and thereafter deserialize it immediately. The result is significantly simpler, which should help with compile time.