mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
64bb16af8a9bd7e37fc088a67ff3eee988f2e6eb
scylladb/test/boost
History
Avi Kivity 00ff3c1366 Merge 'treewide: add support for snapshot skip-flush option' from Benny Halevy 
The option is provided by nodetool snapshot
https://docs.scylladb.com/operating-scylla/nodetool-commands/snapshot/
```
nodetool [(-h <host> | --host <host>)] [(-p <port> | --port <port>)]
         [(-pp | --print-port)] [(-pw <password> | --password <password>)]
         [(-pwf <passwordFilePath> | --password-file <passwordFilePath>)]
         [(-u <username> | --username <username>)] snapshot
         [(-cf <table> | --column-family <table> | --table <table>)]
         [(-kc <kclist> | --kc.list <kclist>)]
         [(-sf | --skip-flush)] [(-t <tag> | --tag <tag>)] [--] [<keyspaces...>]

-sf / –skip-flush    Do not flush memtables before snapshotting (snapshot will not contain unflushed data)
```

But is currently ignored by scylla-jmx (scylladb/scylla-jmx#167)
and not supported at the api level.

This patch adds support for the option in advance
from the api service level down via snapshot_ctl
to the table class and snapshot implementation.

In addition, a corresponding unit test was added to verify
that taking a snapshot with `skip_flush` does not flush the memtable
(at the table::snapshot level).

Refs #8725

Closes #8726

* github.com:scylladb/scylla:
  test: database_test: add snapshot_skip_flush_works
  api: storage_service/snapshots: support skip-flush option
  snapshot: support skip_flush option
  table: snapshot: add skip_flush option
  api: storage_service/snapshots: add sf (skip_flush) option
2021-06-17 13:32:23 +03:00
..
aggregate_fcts_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
allocation_strategy_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
alternator_unit_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
anchorless_list_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
auth_passwords_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
auth_resource_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
auth_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
batchlog_manager_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
big_decimal_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
bptree_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
broken_sstable_test.cc
sstables: Switch the mx reader to flat_mutation_reader_v2
2021-06-16 00:23:49 +02:00
btree_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
bytes_ostream_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cache_flat_mutation_reader_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cached_file_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
caching_options_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
canonical_mutation_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cartesian_product_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
castas_fcts_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cdc_generation_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cdc_test.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
cell_locker_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
checksum_utils_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
chunked_vector_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
clustering_ranges_walker_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
column_mapping_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
commitlog_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
compound_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
compress_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
config_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
continuous_data_consumer_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
counter_test.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
cql_auth_query_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cql_auth_syntax_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cql_functions_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cql_query_group_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cql_query_large_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cql_query_like_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cql_query_test.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
crc_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
data_listeners_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
database_test.cc
Merge 'treewide: add support for snapshot skip-flush option' from Benny Halevy
2021-06-17 13:32:23 +03:00
double_decker_test.cc
tests: Return strong-ordering from tri-comparators
2021-06-07 21:41:08 +03:00
duration_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
dynamic_bitset_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
enum_option_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
enum_set_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
error_injection_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
estimated_histogram_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
extensions_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
filtering_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
flat_mutation_reader_test.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
flush_queue_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
fragmented_temporary_buffer_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
frozen_mutation_test.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
gossip_test.cc
raft: (service) pass Raft service into storage_service
2021-06-08 14:52:32 +03:00
gossiping_property_file_snitch_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
hash_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
hashers_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
idl_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_with_paging_test.cc
cql3: limit the transitional result size for indexed queries
2021-06-07 16:29:18 +02:00
input_stream_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
intrusive_array_test.cc
tests: Return strong-ordering from tri-comparators
2021-06-07 21:41:08 +03:00
json_cql_query_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
json_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
keys_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
large_paging_state_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
like_matcher_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
limiting_data_source_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
linearizing_input_stream_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
loading_cache_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
log_heap_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
logalloc_test.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
managed_bytes_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
managed_vector_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
map_difference_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
memtable_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
multishard_combining_reader_as_mutation_source_test.cc
test/lib/reader_lifecycle_policy: get rid of lifecycle workarounds
2021-06-16 11:29:36 +03:00
multishard_mutation_query_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
murmur_hash_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
mutation_fragment_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
mutation_query_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
mutation_reader_test.cc
test/lib/reader_lifecycle_policy: get rid of lifecycle workarounds
2021-06-16 11:29:36 +03:00
mutation_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
mutation_writer_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
mvcc_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
network_topology_strategy_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
nonwrapping_range_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
observable_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
partitioner_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
querier_cache_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
query_processor_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
radix_tree_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
raft_address_map_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
raft_sys_table_storage_test.cc
raft: (service) servers map is gid -> server, not sid -> server
2021-06-16 19:05:50 +03:00
range_assert.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
range_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
range_tombstone_list_assertions.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
range_tombstone_list_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
reader_concurrency_semaphore_test.cc
reader_concurrency_semaphore: wait for all permits to be destroyed in stop()
2021-06-16 11:29:36 +03:00
restrictions_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
reusable_buffer_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
role_manager_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
row_cache_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
schema_change_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
schema_changes_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
schema_registry_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
secondary_index_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
serialization_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
serialized_action_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
small_vector_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
snitch_reset_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
sstable_3_x_test.cc
tests: sstables: Fix test assertions to not expect more than they should
2021-06-16 00:23:49 +02:00
sstable_conforms_to_mutation_source_test.cc
row_cache: Emit range tombstone adjacent to upper bound of population range
2021-06-16 00:23:49 +02:00
sstable_datafile_test.cc
sstables: Switch the mx reader to flat_mutation_reader_v2
2021-06-16 00:23:49 +02:00
sstable_directory_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
sstable_move_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
sstable_mutation_test.cc
tests: sstables: Fix test assertions to not expect more than they should
2021-06-16 00:23:49 +02:00
sstable_resharding_test.cc
tests: Ditch storage_service_for_tests
2021-05-27 14:39:13 +03:00
sstable_set_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
sstable_test.cc
Merge "sstable: validate first and last keys ordering" from Benny
2021-06-09 14:43:02 +02:00
sstable_test.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
stall_free_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
statement_restrictions_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
storage_proxy_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
suite.yaml
test: move reader_concurrency_semaphore related tests into separate file
2021-05-06 08:59:47 +03:00
test_table.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
top_k_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
total_order_check.hh
tests: Switch total-order-check onto strong_ordering
2021-06-08 11:40:55 +03:00
tracing.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
transport_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
types_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
user_function_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
user_types_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
utf8_test.cc
test: utf8: add fragmented buffer validation tests
2020-10-21 11:14:44 +03:00
UUID_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
view_build_test.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
view_complex_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
view_schema_ckey_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
view_schema_pkey_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
view_schema_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
vint_serialization_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
virtual_reader_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
virtual_table_mutation_source_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
virtual_table_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00