mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-22 17:40:34 +00:00
696bdb2de7
First, a reminder of a few basic concepts in Scylla: - "topology" is a mapping: for each node, its DC and Rack. - "replication strategy" is a method of calculating replica sets in a cluster. It is not a cluster-global property; each keyspace can have a different replication strategy. A cluster may have multiple keyspaces. - "cluster size" is the number of nodes in a cluster. Replication strategy is orthogonal to topology. Cluster size can be derived from topology and is also orthogonal to replication strategy. test.py was confusing the three concepts together. For some reason, Topology suites were specifying a "topology" parameter which contained replication strategy details - having nothing to do with topology. Also it's unclear why a test suite would specify anything to do with replication strategies - after all, a test may create keyspaces with different replication strategies, and a suite may contain multiple different tests. Get rid of the "topology" parameter, replace it with a simple "cluster_size". In the future we may re-introduce it when we actually implement the possibility to start clusters with custom topologies (which involves configuring the snitch etc.) Simplify the test.py code.