Files
scylladb/test/lib/test_utils.hh
Kefu Chai 30e82a81e8 test: do not define boost_test_print_type() for types with operator<<
before this change, we provide `boost_test_print_type()` for all types
which can be formatted using {fmt}. these types includes those who
fulfill the concept of range, and their element can be formatted using
{fmt}. if the compilation unit happens to include `fmt/ranges.h`.
the ranges are formatted with `boost_test_print_type()` as well. this
is what we expect. in other words, we use {fmt} to format types which
do not natively support {fmt}, but they fulfill the range concept.

but `boost::unit_test::basic_cstring` is one of them

- it can be formatted using operator<<, but it does not provide
  fmt::format specialization
- it fulfills the concept of range
- and its element type is `char const`, which can be formatted using
  {fmt}

that's why it's formatted like:

```
test/boost/sstable_directory_test.cc(317): fatal error: in "sstable_directory_test_generation_sanity": critical check ['s', 's', 't', '-', '>', 'g', 'e', 'n', 'e', 'r', 'a', 't', 'i', 'o', 'n', '(', ')', ' ', '=', '=', ' ', 's', 's', 't', '1', '-', '>', 'g', 'e', 'n', 'e', 'r', 'a', 't', 'i', 'o', 'n', '(', ')'] has failed`
```

where the string is formatted as a sequence-alike container. this
is far from readable.

so, in this change, we do not define `boost_test_print_type()` for
the types which natively support `operator<<` anymore. so they can
be printed with `operator<<` when  boost::test prints them.

Fixes scylladb/scylladb#19637
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes scylladb/scylladb#19638
2024-07-09 10:34:37 +03:00

127 lines
4.8 KiB
C++

/*
* Copyright (C) 2020-present ScyllaDB
*/
/*
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
#pragma once
#include <seastar/core/future.hh>
#include <seastar/util/source_location-compat.hh>
#include <string>
#include <boost/test/unit_test.hpp>
#include <fmt/core.h>
#include <fmt/format.h>
using namespace seastar;
// Thread safe alternatives to BOOST_REQUIRE_*, BOOST_CHECK_* and BOOST_FAIL().
// Use these if instead of the BOOST provided macros if you want to use them on
// multiple shards, to avoid problems due to the BOOST versions not being thread
// safe.
namespace tests {
[[nodiscard]] bool do_check(bool condition, seastar::compat::source_location sl, std::string_view msg);
[[nodiscard]] inline bool check(bool condition, seastar::compat::source_location sl = seastar::compat::source_location::current()) {
return do_check(condition, sl, {});
}
template <typename LHS, typename RHS>
[[nodiscard]] bool check_equal(const LHS& lhs, const RHS& rhs, seastar::compat::source_location sl = seastar::compat::source_location::current()) {
const auto condition = (lhs == rhs);
return do_check(condition, sl, fmt::format("{} {}= {}", lhs, condition ? "=" : "!", rhs));
}
void do_require(bool condition, seastar::compat::source_location sl, std::string_view msg);
inline void require(bool condition, seastar::compat::source_location sl = seastar::compat::source_location::current()) {
do_require(condition, sl, {});
}
template <typename LHS, typename RHS, typename Compare>
void do_require_relation(
const LHS& lhs,
const RHS& rhs,
const Compare& relation,
const char* relation_operator,
seastar::compat::source_location sl) {
const auto condition = relation(lhs, rhs);
do_require(condition, sl, fmt::format("assertion {} {} {} failed", lhs, relation_operator, rhs));
}
template <typename LHS, typename RHS>
void require_less(const LHS& lhs, const RHS& rhs, seastar::compat::source_location sl = seastar::compat::source_location::current()) {
do_require_relation(lhs, rhs, std::less<LHS>{}, "<", sl);
}
template <typename LHS, typename RHS>
void require_less_equal(const LHS& lhs, const RHS& rhs, seastar::compat::source_location sl = seastar::compat::source_location::current()) {
do_require_relation(lhs, rhs, std::less_equal<LHS>{}, "<=", sl);
}
template <typename LHS, typename RHS>
void require_equal(const LHS& lhs, const RHS& rhs, seastar::compat::source_location sl = seastar::compat::source_location::current()) {
do_require_relation(lhs, rhs, std::equal_to<LHS>{}, "==", sl);
}
template <typename LHS, typename RHS>
void require_not_equal(const LHS& lhs, const RHS& rhs, seastar::compat::source_location sl = seastar::compat::source_location::current()) {
do_require_relation(lhs, rhs, std::not_equal_to<LHS>{}, "!=", sl);
}
template <typename LHS, typename RHS>
void require_greater_equal(const LHS& lhs, const RHS& rhs, seastar::compat::source_location sl = seastar::compat::source_location::current()) {
do_require_relation(lhs, rhs, std::greater_equal<LHS>{}, ">=", sl);
}
template <typename LHS, typename RHS>
void require_greater(const LHS& lhs, const RHS& rhs, seastar::compat::source_location sl = seastar::compat::source_location::current()) {
do_require_relation(lhs, rhs, std::greater<LHS>{}, ">", sl);
}
void fail(std::string_view msg, seastar::compat::source_location sl = seastar::compat::source_location::current());
inline std::string getenv_safe(std::string_view name) {
auto v = ::getenv(name.data());
if (!v) {
throw std::logic_error(fmt::format("Environment variable {} not set", name));
}
return std::string(v);
}
extern boost::test_tools::assertion_result has_scylla_test_env(boost::unit_test::test_unit_id);
future<bool> compare_files(std::string fa, std::string fb);
future<> touch_file(std::string name);
extern std::mutex boost_logger_mutex;
#define THREADSAFE_BOOST_CHECK( BOOST_CHECK_EXPR ) { \
std::lock_guard<std::mutex> guard(tests::boost_logger_mutex); \
BOOST_CHECK_EXPR; \
}
// Thread-safe variants of BOOST macros for unit tests
// This is required to address lack of synchronization in boost test logger, which is susceptible to races
// in multi-threaded tests. Boost's XML printer (see boost/test/utils/xml_printer.hpp) can generate
// unreadable XML files, and therefore cause failure when parsing its content.
#define THREADSAFE_BOOST_REQUIRE( P ) THREADSAFE_BOOST_CHECK(BOOST_REQUIRE( P ))
#define THREADSAFE_BOOST_REQUIRE_EQUAL( L, R ) THREADSAFE_BOOST_CHECK(BOOST_REQUIRE_EQUAL( L, R ))
}
namespace std {
template <typename T>
requires (fmt::is_formattable<T>::value &&
!boost::has_left_shift<T, std::ostream>::value)
std::ostream& boost_test_print_type(std::ostream& os, const T& p) {
fmt::print(os, "{}", p);
return os;
}
}