6afa80a443
Calling notify_left for old ip on topology change in raft mode was a regression. In gossiper mode it didn't occur. In gossiper mode the function handle_state_normal was responsible for spotting IP addresses that weren't managing any parts of the data, and it would then initiate their removal by calling remove_endpoint. This removal process did not include calling notify_left. Actually, notify_left was only supposed to be called (via excise) by a 'real' removal procedures - removenode and decommission. The redundant notify_left caused troubles in scylla python driver. The driver could receive REMOVED_NODE and NEW_NODE notifications in the same time and their handling routines could race with each other. In this commit we fix the problem by not calling notify_left if the remove_ip lambda was called from the ip change code path. Also, we add a test which verifies that the driver log doesn't mention the REMOVED_NODE notification. Fixes scylladb/scylladb#17444 Closes scylladb/scylladb#17561
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cql-pytest - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.