mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-02 22:25:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
6da4acb41e8fdcee67aa3cf96c332e6b405cb861
scylladb/cql3
History
Piotr Sarna 6da4acb41e expression: fix get_value for mismatched column definitions 
As observed in #10026, after schema changes it somehow happened
that a column defition that does not match any of the base table
columns was passed to expression verification code.
The function that looks up the index of a column happens to return
-1 when it doesn't find anything, so using this returned index
without checking if it's nonnegative results in accessing invalid
vector data, and a segfault or silent memory corruption.
Therefore, an explicit check is added to see if the column was actually
found. This serves two purposes:
 - avoiding segfaults/memory corruption
 - making it easier to investigate the root cause of #10026

Closes #10039

(cherry picked from commit 7b364fec9849e9a342af1c240e3a7185bf5401ef)
2022-03-21 10:46:34 +01:00
..
expr
expression: fix get_value for mismatched column definitions
2022-03-21 10:46:34 +01:00
functions
cql3: expr: Implement evaluate(expr::function_call)
2021-09-24 11:05:53 +02:00
restrictions
cql3: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
selection
cql3: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
statements
cql: INSERT JSON should refuse empty-string partition key
2022-03-02 22:00:15 +02:00
abstract_marker.cc
cql3: abstract_marker, term_expr: rearrange raw abstract marker implementation
2021-08-26 14:53:58 +03:00
abstract_marker.hh
cql3: expr, abstract_marker: convert to expressions
2021-08-26 15:01:04 +03:00
assignment_testable.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
attributes.cc
cql3: Replace all uses of bind_and_get with evaluate_to_raw_view
2021-09-21 16:20:30 +02:00
attributes.hh
cql3: attributes: convert to expressions
2021-08-26 15:32:52 +03:00
authorized_prepared_statements_cache.hh
loading_shared_values/loading_cache: get rid of iterators interface and return value_ptr from find(...) instead
2021-08-22 16:49:40 +03:00
cf_name.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cf_name.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
column_condition.cc
cql3: expr: introduce as/as_if/is
2021-09-28 23:49:11 +03:00
column_condition.hh
cql3: column_condition: convert term::raw to expressions
2021-08-26 15:34:13 +03:00
column_identifier.cc
make column_identifier::raw forward declarable
2021-07-27 20:00:48 +03:00
column_identifier.hh
build: enable -Winconsistent-missing-override warning
2021-09-15 12:55:54 +03:00
column_specification.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
column_specification.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
constants.cc
cql3: Implement term::to_expression for marker classes
2021-09-24 11:05:53 +02:00
constants.hh
cql3: Add term::to_expression method
2021-09-24 11:05:53 +02:00
cql3_type.cc
cql3: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
cql3_type.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cql_config.hh
main: Replace cql_config_updater with updateable_value
2021-09-30 07:23:43 +03:00
cql_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
Cql.g
cql3: expr: introduce as/as_if/is
2021-09-28 23:49:11 +03:00
error_collector.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
error_listener.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_name.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_name.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
keyspace_element_name.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
keyspace_element_name.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
lists.cc
cql3: Implement term::to_expression for collections
2021-09-24 11:05:53 +02:00
lists.hh
cql3: Add term::to_expression method
2021-09-24 11:05:53 +02:00
maps.cc
cql3: Implement term::to_expression for collections
2021-09-24 11:05:53 +02:00
maps.hh
cql3: Add term::to_expression method
2021-09-24 11:05:53 +02:00
multi_column_relation.hh
cql3: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
operation_impl.hh
build: enable -Winconsistent-missing-override warning
2021-09-15 12:55:54 +03:00
operation.cc
cql3: Replace most uses of terminal with expr::constant
2021-09-21 16:28:15 +02:00
operation.hh
cql3: operation: convert term::raw to expression
2021-08-26 15:37:52 +03:00
prepare_context.cc
cql3: prepare_context: remove unused methods
2021-07-30 17:57:10 +03:00
prepare_context.hh
cql3: prepare_context: mark methods noexcept
2021-08-22 21:11:40 +03:00
prepared_statements_cache.hh
loading_shared_values/loading_cache: get rid of iterators interface and return value_ptr from find(...) instead
2021-08-22 16:49:40 +03:00
query_options_fwd.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
query_options.cc
main: Replace cql_config_updater with updateable_value
2021-09-30 07:23:43 +03:00
query_options.hh
cql3: cache function calls evaluation for non-deterministic functions
2021-07-30 01:22:39 +03:00
query_processor.cc
cql3: query_processor: add parse_statements()
2021-09-07 11:13:30 +03:00
query_processor.hh
cql3: query_processor: add parse_statements()
2021-09-07 11:13:30 +03:00
relation.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
relation.hh
cql3: relation: convert to_term() to experssions
2021-08-26 15:56:44 +03:00
result_generator.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
result_set.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
result_set.hh
cql3: result_set: remove std::ref from comperator&
2022-02-16 10:08:24 +02:00
role_name.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
role_name.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
role_options.hh
…
sets.cc
cql3: Implement term::to_expression for collections
2021-09-24 11:05:53 +02:00
sets.hh
cql3: Add term::to_expression method
2021-09-24 11:05:53 +02:00
single_column_relation.cc
cql3: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
single_column_relation.hh
cql3: expr: construct column_value explicitly
2021-09-28 23:49:21 +03:00
stats.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
term.hh
cql3: Add term::to_expression method
2021-09-24 11:05:53 +02:00
token_relation.cc
cql3: relation: convert to_term() to experssions
2021-08-26 15:56:44 +03:00
token_relation.hh
cql3: relation: convert to_term() to experssions
2021-08-26 15:56:44 +03:00
tuples.cc
cql3: Implement term::to_expression for tuples
2021-09-24 11:05:53 +02:00
tuples.hh
cql3: Add term::to_expression method
2021-09-24 11:05:53 +02:00
type_json.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
type_json.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
untyped_result_set.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
untyped_result_set.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
update_parameters.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
update_parameters.hh
treewide: remove redundant "x <=> 0" compares
2021-07-28 13:30:32 +03:00
user_types.cc
cql3: expr: drop nested_expression
2021-09-28 23:49:21 +03:00
user_types.hh
cql3: Add term::to_expression method
2021-09-24 11:05:53 +02:00
ut_name.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
ut_name.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
util.cc
cql: fix undefined behavior in timestamp verification
2021-07-24 11:01:08 +03:00
util.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
values.cc
cql3: values: Add unset value to raw_value_view::make_temporary
2021-09-21 16:05:09 +02:00
values.hh
cql3: expr: Implement evaluate(expr::tuple_constructor)
2021-09-24 11:05:53 +02:00