mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-02 14:15:46 +00:00
Migrate all the places that used memtable::make_reader to use
memtable::make_flat_reader and remove memtable::make_reader.
* seastar-dev.git haaawk/remove_memtable_make_reader_v2_rebased:
Remove memtable::make_reader
Stop using memtable::make_reader in row_cache_stress_test
Stop using memtable::make_reader in row_cache_test
Stop using memtable::make_reader in mutation_test
Stop using memtable::make_reader in streamed_mutation_test
Stop using memtable::make_reader in memtable_snapshot_source.hh
Stop using memtable::make_reader in memtable::apply
Add consume_partitions(flat_mutation_reader& reader, Consumer consumer)
Add default parameter values in make_combined_reader
Migrate test_virtual_dirty_accounting_on_flush to flat reader
Migrate test_adding_a_column_during_reading_doesnt_affect_read_result
Simplify flat_reader_assertions& produces(const mutation& m)
Migrate test_partition_version_consistency_after_lsa_compaction_happens
flat_mutation_reader: Allow setting buffer capacity
Add next_mutation() to flat_mutation_reader_assertions
cf::for_all_partitions::iteration_state: don't store schema_ptr
read_mutation_from_flat_mutation_reader: don't take schema_ptr
Migrate test_fast_forward_to_after_memtable_is_flushed to flat reader
(cherry picked from commit b0a56a91c2)
134 lines
4.3 KiB
C++
134 lines
4.3 KiB
C++
/*
|
|
* Copyright (C) 2017 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "mutation_reader.hh"
|
|
#include "memtable.hh"
|
|
#include "utils/phased_barrier.hh"
|
|
#include <seastar/core/circular_buffer.hh>
|
|
#include <seastar/core/thread.hh>
|
|
#include <seastar/core/condition-variable.hh>
|
|
|
|
// in-memory snapshottable mutation source.
|
|
// Must be destroyed in a seastar thread.
|
|
class memtable_snapshot_source {
|
|
schema_ptr _s;
|
|
circular_buffer<lw_shared_ptr<memtable>> _memtables;
|
|
utils::phased_barrier _apply;
|
|
bool _closed = false;
|
|
seastar::condition_variable _should_compact;
|
|
future<> _compactor;
|
|
private:
|
|
bool should_compact() const {
|
|
return !_closed && _memtables.size() >= 3;
|
|
}
|
|
lw_shared_ptr<memtable> new_memtable() {
|
|
return make_lw_shared<memtable>(_s);
|
|
}
|
|
lw_shared_ptr<memtable> pending() {
|
|
if (_memtables.empty()) {
|
|
_memtables.push_back(new_memtable());
|
|
on_new_memtable();
|
|
}
|
|
return _memtables.back();
|
|
}
|
|
void on_new_memtable() {
|
|
if (should_compact()) {
|
|
_should_compact.signal();
|
|
}
|
|
}
|
|
void compact() {
|
|
if (_memtables.empty()) {
|
|
return;
|
|
}
|
|
auto count = _memtables.size();
|
|
auto op = _apply.start();
|
|
auto new_mt = make_lw_shared<memtable>(_memtables.back()->schema());
|
|
std::vector<flat_mutation_reader> readers;
|
|
for (auto&& mt : _memtables) {
|
|
readers.push_back(mt->make_flat_reader(new_mt->schema(),
|
|
query::full_partition_range,
|
|
new_mt->schema()->full_slice(),
|
|
default_priority_class(),
|
|
nullptr,
|
|
streamed_mutation::forwarding::no,
|
|
mutation_reader::forwarding::yes));
|
|
}
|
|
auto&& rd = make_combined_reader(new_mt->schema(), std::move(readers));
|
|
consume_partitions(rd, [&] (mutation&& m) {
|
|
new_mt->apply(std::move(m));
|
|
return stop_iteration::no;
|
|
}).get();
|
|
_memtables.erase(_memtables.begin(), _memtables.begin() + count);
|
|
_memtables.push_back(new_mt);
|
|
}
|
|
public:
|
|
memtable_snapshot_source(schema_ptr s)
|
|
: _s(s)
|
|
, _compactor(seastar::async([this] {
|
|
while (!_closed) {
|
|
_should_compact.wait().get();
|
|
while (should_compact()) {
|
|
compact();
|
|
}
|
|
}
|
|
}))
|
|
{ }
|
|
memtable_snapshot_source(memtable_snapshot_source&&) = delete; // 'this' captured.
|
|
~memtable_snapshot_source() {
|
|
_closed = true;
|
|
_should_compact.broadcast();
|
|
_compactor.get();
|
|
}
|
|
// Must run in a seastar thread
|
|
void clear() {
|
|
_memtables.erase(_memtables.begin(), _memtables.end());
|
|
_apply.advance_and_await().get();
|
|
_memtables.erase(_memtables.begin(), _memtables.end());
|
|
}
|
|
void apply(const mutation& mt) {
|
|
pending()->apply(mt);
|
|
}
|
|
// Must run in a seastar thread
|
|
void apply(memtable& mt) {
|
|
auto op = _apply.start();
|
|
auto new_mt = new_memtable();
|
|
new_mt->apply(mt).get();
|
|
_memtables.push_back(new_mt);
|
|
}
|
|
// mt must not change from now on.
|
|
void apply(lw_shared_ptr<memtable> mt) {
|
|
auto op = _apply.start();
|
|
_memtables.push_back(std::move(mt));
|
|
on_new_memtable();
|
|
}
|
|
mutation_source operator()() {
|
|
std::vector<mutation_source> src;
|
|
for (auto&& mt : _memtables) {
|
|
src.push_back(mt->as_data_source());
|
|
}
|
|
_memtables.push_back(new_memtable()); // so that src won't change any more.
|
|
on_new_memtable();
|
|
return make_combined_mutation_source(std::move(src));
|
|
}
|
|
};
|