Benny Halevy ff5b42a0fa
bytes_ostream: max_chunk_size: account for chunk header ...
Currently, if the data_size is greater than
max_chunk_size - sizeof(chunk), we end up
allocating up to max_chunk_size + sizeof(chunk) bytes,
exceeding buf.max_chunk_size().
This may lead to allocation failures, as seen in
https://github.com/scylladb/scylla/issues/7950 ,
where we couldn't allocate 131088 (= 128K + 16) bytes.
This change adjusted the expose max_chunk_size()
to be max_alloc_size (128KB) - sizeof(chunk)
so that the allocated chunks would normally be allocated
in 128KB chunks in the write() path.
Added a unit test - test_large_placeholder that
stresses the chunk allocation path from the
write_place_holder(size) entry point to make
sure it handles large chunk allocations correctly.
Refs #7950
Refs #8081
Test: unit(release), bytes_ostream_test(debug)
Signed-off-by: Benny Halevy <bhalevy@scylladb.com >
Message-Id: <20210303143413.902968-1-bhalevy@scylladb.com >
2021-03-10 19:54:12 +02:00
2021-01-13 11:07:29 +02:00
2020-06-10 15:49:51 +03:00
2020-08-15 20:26:02 +03:00
2020-11-16 22:32:32 -05:00
2020-07-16 16:38:48 +03:00
2020-06-25 15:37:23 -07:00
2020-08-06 15:41:31 +03:00
2021-01-27 17:38:17 +02:00
2021-02-02 09:30:29 +03:00
2021-03-10 19:54:12 +02:00
2021-02-02 09:30:30 +03:00
2020-06-16 16:15:23 +02:00
2020-09-21 16:32:53 +03:00
2021-02-17 13:24:40 +01:00
2021-02-18 11:44:59 +01:00
2020-11-02 18:02:01 +02:00
2021-02-01 19:32:07 +02:00
2020-10-15 19:25:24 +03:00
2021-02-03 12:21:20 +02:00
2021-01-08 14:16:08 +01:00
2020-11-12 12:36:16 +01:00
2021-01-13 11:07:29 +02:00
2021-02-16 23:43:07 +01:00
2021-01-13 11:07:29 +02:00
2020-10-19 15:40:55 -04:00
2021-02-25 17:20:27 +01:00
2020-07-07 23:08:09 +02:00
2021-03-02 08:01:53 +02:00
2020-08-26 20:44:11 +03:00
2021-02-26 23:43:16 +02:00
2020-10-30 08:06:04 +02:00
2020-05-26 20:46:45 +03:00
2020-08-15 20:26:02 +03:00
2020-06-03 14:44:00 +02:00
2020-06-18 14:18:21 +03:00
2020-11-12 12:36:13 +01:00
2021-02-25 17:20:27 +01:00
2021-01-13 17:35:07 +02:00
2021-01-13 11:07:29 +02:00
2020-09-28 11:27:23 +03:00
2021-02-22 12:45:43 +01:00
2021-01-13 16:41:34 +03:00
2021-01-15 18:28:24 +01:00
2020-12-15 16:03:18 +03:00
2021-02-25 17:20:27 +01:00
2021-01-13 11:07:29 +02:00
2020-07-14 16:29:49 +03:00
2020-07-06 11:24:12 +03:00
2021-01-08 14:16:08 +01:00
2021-02-25 17:20:27 +01:00
2020-05-13 09:37:39 +03:00
2021-01-13 11:07:29 +02:00
2021-02-23 19:42:42 +02:00
2021-01-15 18:21:13 +01:00
2020-09-28 10:53:56 +03:00
2020-10-12 15:56:56 +03:00
2021-02-16 23:43:07 +01:00
2021-01-08 14:16:08 +01:00
2020-09-28 10:53:48 +03:00
2021-02-26 23:29:20 +02:00
2021-03-10 16:28:14 +01:00
2021-01-19 19:03:58 +02:00
2020-10-26 11:54:42 +02:00
2021-01-13 11:07:29 +02:00
2020-07-23 16:49:35 +03:00
2020-04-22 18:24:54 +02:00
2021-02-08 22:31:01 +02:00
2021-02-25 17:20:27 +01:00
2021-02-15 20:27:00 +03:00
2021-03-03 16:29:02 +01:00
2021-03-09 13:51:09 +01:00
2021-01-29 22:07:07 +03:00
2020-06-18 12:38:31 +03:00
2020-12-28 18:26:48 +02:00
2021-02-25 17:20:27 +01:00
2021-03-09 17:57:52 +01:00
2021-02-01 18:52:04 +02:00
2021-01-27 17:38:17 +02:00
2021-02-25 17:20:27 +01:00
2020-10-14 16:45:21 +03:00
2021-01-13 16:41:34 +03:00
2021-02-16 23:43:07 +01:00
2020-09-23 20:55:12 +03:00
2021-03-10 12:02:12 -03:00
2021-02-01 16:45:52 +02:00
2020-11-09 19:57:40 +02:00
2021-01-27 17:38:17 +02:00
2020-09-23 20:55:13 +03:00
2021-03-10 15:40:50 +02:00
2021-03-02 13:21:22 +02:00
2020-08-11 10:37:34 +08:00
2020-12-22 10:35:15 +02:00
2020-11-03 21:30:11 +03:00
2021-01-08 14:16:08 +01:00
2020-11-02 16:47:32 +02:00
2021-02-02 13:03:39 +02:00
2020-08-16 13:49:55 +03:00
2020-10-21 11:14:44 +03:00
2021-01-21 13:03:59 +03:00
2021-02-01 16:45:52 +02:00
2020-08-18 14:31:04 +03:00
2020-08-20 14:53:07 +02:00
ff5b42a0fa