scylladb

mirror of https://github.com/scylladb/scylladb.git synced 2026-04-26 19:35:12 +00:00

Files

Nadav Har'El 7146646bf4 Merge 'commitlog: make_checked_file for segments, report and ignore other errors on shutdown' from Benny Halevy

Shutdown must never fail, otherwise it may cause hangs
as seen in https://github.com/scylladb/scylla/issues/8577.

This change wraps the file created in `allocate_segment_ex` in `make_checked_file` so that scylla will abort when failing to write to the commitlog files.

In case other errors are seen during shutdown, just log them and continue with shutting down to prevent scylla from hanging.

Fixes #8577

Test: unit(dev)
Signed-off-by: Benny Halevy <bhalevy@scylladb.com>

Closes #8578

* github.com:scylladb/scylla:
  commitlog: segment_manager::shutdown: abort on errors
  commitlog: allocate_segment_ex: make_checked_file

(cherry picked from commit 48ff641f67)

2021-06-27 14:04:04 +03:00

commitlog_entry.cc

db/commitlog: Use fragmented buffers to read entries

2018-12-31 13:20:37 +00:00

commitlog_entry.hh

commitlog: Make commitlog entries optionally multi-entry

2021-02-02 10:41:08 +00:00

commitlog_extensions.hh

db::commitlog: Add commitlog/hints file io extension

2018-03-26 11:58:27 +00:00

commitlog_replayer.cc

db: commitlog_replayer: don't capture structured bindings in lambdas