mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-30 03:30:49 +00:00
ba17ae2ab6
As a general rule, tests in test/cql-pytest shouldn't just pass on Scylla - they also should not fail on Cassandra; A test that fails on Cassandra may indicate that the test is wrong, or that Scylla's behavior is wrong and the test just enshrines that wrong behavior. Each time we see a test fail on Cassandra we need to check if this is not the case. We also have special markers scylla_only and cassandra_bug to put on tests that we know _should_ fail on Cassandra because it is missing some Scylla-only feature or there is a bug in Cassandra, respectively. Such tests will be xfailed/skipped when running on Cassandra, and not report failures. Unfortunately, over time more several tests got into our suite in that did not pass on Cassandra. In this series I went over all of them, and fixed each to pass - or be skipped - on Cassandra, in a way that each patch explains. Fixes #16027 Closes scylladb/scylladb#16033 * github.com:scylladb/scylladb: test/cql-pytest: fix test_describe.py to not fail on Cassandra test/cql-pytest: fix select_single_column_relation_test.py to not fail on Cassandra test/cql-pytest: fix compact_storage_test.py to not fail on Cassandra test/cql-pytest: fix test_secondary_index.py to not fail on Cassandra test/cql-pytest: fix test_materialized_view.py to not fail on Cassandra test/cql-pytest: fix test_keyspace.py to not fail on Cassandra test/cql-pytest: test_guardrail_replication_strategy.py is Scylla-only test/cql-pytest: partial fix for test_compaction_strategy_validation.py on Cassandra test/cql-pytest: fix test_filtering.py to not fail on Cassandra