mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-02 14:15:46 +00:00
Whether a server can vote in a Raft configuration is not part of the address. `server_address` was used in many context where `can_vote` is irrelevant. Split the struct: `server_address` now contains only `id` and `server_info` as it did before `can_vote` was introduced. Instead we have a `config_member` struct that contains a `server_address` and the `can_vote` field. Also remove an "unsafe" constructor from `server_address` where `id` was provided but `server_info` was not. The constructor was used for tests where `server_info` is irrelevant, but it's important not to forget about the info in production code. The constructor was used for two purposes: - Invoking set operations such as `contains`. To solve this we use C++20 transparent hash and comparator functions, which allow invoking `contains` and similar functions by providing a different key type (in this case `raft::server_id` in set of addresses, for example). - constructing addresses without `info`s in tests. For this we provide helper functions in the test helpers module and use them.
191 lines
6.7 KiB
C++
191 lines
6.7 KiB
C++
/*
|
|
* Copyright (C) 2020-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#include <seastar/testing/test_case.hh>
|
|
#include <seastar/core/coroutine.hh>
|
|
|
|
#include "utils/UUID_gen.hh"
|
|
|
|
#include "service/raft/raft_sys_table_storage.hh"
|
|
|
|
#include "test/lib/cql_test_env.hh"
|
|
#include "cql3/query_processor.hh"
|
|
|
|
#include "gms/inet_address_serializer.hh"
|
|
|
|
namespace raft{
|
|
|
|
// these operators provided exclusively for testing purposes
|
|
|
|
static bool operator==(const configuration& lhs, const configuration& rhs) {
|
|
return lhs.current == rhs.current && lhs.previous == rhs.previous;
|
|
}
|
|
|
|
static bool operator==(const snapshot_descriptor& lhs, const snapshot_descriptor& rhs) {
|
|
return lhs.idx == rhs.idx &&
|
|
lhs.term == rhs.term &&
|
|
lhs.config == rhs.config &&
|
|
lhs.id == rhs.id;
|
|
}
|
|
|
|
static bool operator==(const log_entry::dummy&, const log_entry::dummy&) {
|
|
return true;
|
|
}
|
|
|
|
static bool operator==(const log_entry& lhs, const log_entry& rhs) {
|
|
return lhs.term == rhs.term &&
|
|
lhs.idx == rhs.idx &&
|
|
lhs.data == rhs.data;
|
|
}
|
|
|
|
} // namespace raft
|
|
|
|
using namespace service;
|
|
|
|
static raft::group_id gid{utils::UUID_gen::min_time_UUID()};
|
|
|
|
// Create a test log with entries of each kind to test that these get
|
|
// serialized/deserialized properly
|
|
static std::vector<raft::log_entry_ptr> create_test_log() {
|
|
raft::command cmd;
|
|
ser::serialize(cmd, 123);
|
|
|
|
return {
|
|
// command
|
|
make_lw_shared(raft::log_entry{
|
|
.term = raft::term_t(1),
|
|
.idx = raft::index_t(1),
|
|
.data = std::move(cmd)}),
|
|
// configuration
|
|
make_lw_shared(raft::log_entry{
|
|
.term = raft::term_t(2),
|
|
.idx = raft::index_t(2),
|
|
.data = raft::configuration{{raft::config_member{raft::server_address{raft::server_id::create_random_id(), {}}, true}}}}),
|
|
// dummy
|
|
make_lw_shared(raft::log_entry{
|
|
.term = raft::term_t(3),
|
|
.idx = raft::index_t(3),
|
|
.data = raft::log_entry::dummy()})
|
|
};
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_store_load_term_and_vote) {
|
|
return do_with_cql_env([] (cql_test_env& env) -> future<> {
|
|
cql3::query_processor& qp = env.local_qp();
|
|
raft_sys_table_storage storage(qp, gid, raft::server_id::create_random_id());
|
|
|
|
raft::term_t vote_term(1);
|
|
auto vote_id = raft::server_id::create_random_id();
|
|
|
|
co_await storage.store_term_and_vote(vote_term, vote_id);
|
|
auto persisted = co_await storage.load_term_and_vote();
|
|
|
|
BOOST_CHECK_EQUAL(vote_term, persisted.first);
|
|
BOOST_CHECK_EQUAL(vote_id, persisted.second);
|
|
}, raft_cql_test_config());
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_store_load_snapshot) {
|
|
return do_with_cql_env([] (cql_test_env& env) -> future<> {
|
|
cql3::query_processor& qp = env.local_qp();
|
|
raft_sys_table_storage storage(qp, gid, raft::server_id::create_random_id());
|
|
|
|
raft::term_t snp_term(1);
|
|
raft::index_t snp_idx(1);
|
|
raft::config_member srv{raft::server_address{
|
|
raft::server_id::create_random_id(),
|
|
ser::serialize_to_buffer<bytes>(gms::inet_address("localhost"))
|
|
}, true};
|
|
raft::configuration snp_cfg({std::move(srv)});
|
|
auto snp_id = raft::snapshot_id::create_random_id();
|
|
|
|
raft::snapshot_descriptor snp{
|
|
.idx = snp_idx,
|
|
.term = snp_term,
|
|
.config = std::move(snp_cfg),
|
|
.id = std::move(snp_id)};
|
|
|
|
// deliberately larger than log size to keep the log intact
|
|
static constexpr size_t preserve_log_entries = 10;
|
|
|
|
co_await storage.store_snapshot_descriptor(snp, preserve_log_entries);
|
|
raft::snapshot_descriptor loaded_snp = co_await storage.load_snapshot_descriptor();
|
|
|
|
BOOST_CHECK(snp == loaded_snp);
|
|
}, raft_cql_test_config());
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_store_load_log_entries) {
|
|
return do_with_cql_env([] (cql_test_env& env) -> future<> {
|
|
cql3::query_processor& qp = env.local_qp();
|
|
raft_sys_table_storage storage(qp, gid, raft::server_id::create_random_id());
|
|
|
|
std::vector<raft::log_entry_ptr> entries = create_test_log();
|
|
co_await storage.store_log_entries(entries);
|
|
raft::log_entries loaded_entries = co_await storage.load_log();
|
|
|
|
BOOST_CHECK_EQUAL(entries.size(), loaded_entries.size());
|
|
for (size_t i = 0, end = entries.size(); i != end; ++i) {
|
|
BOOST_CHECK(*entries[i] == *loaded_entries[i]);
|
|
}
|
|
}, raft_cql_test_config());
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_truncate_log) {
|
|
return do_with_cql_env([] (cql_test_env& env) -> future<> {
|
|
cql3::query_processor& qp = env.local_qp();
|
|
raft_sys_table_storage storage(qp, gid, raft::server_id::create_random_id());
|
|
|
|
std::vector<raft::log_entry_ptr> entries = create_test_log();
|
|
co_await storage.store_log_entries(entries);
|
|
// truncate the last entry from the log
|
|
co_await storage.truncate_log(raft::index_t(3));
|
|
|
|
raft::log_entries loaded_entries = co_await storage.load_log();
|
|
BOOST_CHECK_EQUAL(loaded_entries.size(), 2);
|
|
for (size_t i = 0, end = loaded_entries.size(); i != end; ++i) {
|
|
BOOST_CHECK(*entries[i] == *loaded_entries[i]);
|
|
}
|
|
}, raft_cql_test_config());
|
|
}
|
|
|
|
SEASTAR_TEST_CASE(test_store_snapshot_truncate_log_tail) {
|
|
return do_with_cql_env([] (cql_test_env& env) -> future<> {
|
|
cql3::query_processor& qp = env.local_qp();
|
|
raft_sys_table_storage storage(qp, gid, raft::server_id::create_random_id());
|
|
|
|
std::vector<raft::log_entry_ptr> entries = create_test_log();
|
|
co_await storage.store_log_entries(entries);
|
|
|
|
raft::term_t snp_term(3);
|
|
raft::index_t snp_idx(3);
|
|
raft::config_member srv{raft::server_address{
|
|
raft::server_id::create_random_id(),
|
|
ser::serialize_to_buffer<bytes>(gms::inet_address("localhost"))
|
|
}, true};
|
|
raft::configuration snp_cfg({std::move(srv)});
|
|
auto snp_id = raft::snapshot_id::create_random_id();
|
|
|
|
raft::snapshot_descriptor snp{
|
|
.idx = snp_idx,
|
|
.term = snp_term,
|
|
.config = std::move(snp_cfg),
|
|
.id = std::move(snp_id)};
|
|
|
|
// leave the last 2 entries in the log after saving the snapshot
|
|
static constexpr size_t preserve_log_entries = 2;
|
|
|
|
co_await storage.store_snapshot_descriptor(snp, preserve_log_entries);
|
|
raft::log_entries loaded_entries = co_await storage.load_log();
|
|
BOOST_CHECK_EQUAL(loaded_entries.size(), 2);
|
|
for (size_t i = 0, end = loaded_entries.size(); i != end; ++i) {
|
|
BOOST_CHECK(*entries[i + 1] == *loaded_entries[i]);
|
|
}
|
|
}, raft_cql_test_config());
|
|
}
|